From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id 9034C3858D33 for ; Fri, 29 Dec 2023 12:39:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9034C3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9034C3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=89.208.246.23 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703853586; cv=none; b=w4/TpSnirAgT9zL9vRadGDHzppqgsqZBvzHFnY6TVEiX/ajThCwbNBVEyDRceF7ebuaU5Soxnd7eKInxqeP0rZE3tiRY8B+pLsA2qCpauAdplJ+SwHwahkMcIlprY0O9tV9iylWSKD8yQD/9R1GGGpKXplT/Rq5kxeUU8/llRWI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703853586; c=relaxed/simple; bh=V+V+RLVz4ledTJNVkWvnk4kquZr7sRh6Wtv1QsxhXc8=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=tl0kHu50cuU6ZazTMRcwHfPlSY3Bq4ZjZKlDYm+A1ZH0de5AGI3J2HT6EIlc18K1SqaY9Rkq62DviI9UOCBQh3v5hH7+55Fv2bsVUA8l222DdqKAIKFpWGZXKPer+vBeLO2U/JH42ZM0/uD/YyetDE8YwiTrUASHksklv0awgDM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1703853582; bh=V+V+RLVz4ledTJNVkWvnk4kquZr7sRh6Wtv1QsxhXc8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Kv0Td65e5tVQhrpKuru2dcGJuN57r2QyHmtxoqGRTCfxqeSyAmMgS1Z2epjW2oItQ TkVGTO8Kz+fv7EXlYqpgjfQehIy61gh1HFmeHvD6XaPNX1eDdug5bg7S8jaepZkYnW ocfIYt+v8DRe5+V+oL2Sh4DjJhRphJ+s4xsIzr5I= Received: from [127.0.0.1] (unknown [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 06ED666E33; Fri, 29 Dec 2023 07:39:37 -0500 (EST) Message-ID: Subject: Re: [PATCH v5 1/5] LoongArch: bfd: Add support for tls le relax. From: Xi Ruoyao To: Hannes Domani , "binutils@sourceware.org" , changjiachen Cc: "xuchenghua@loongson.cn" , "chenglulu@loongson.cn" , "liuzhensong@loongson.cn" , "i.swmail@xen0n.name" , "maskray@google.com" , "cailulu@loongson.cn" , "luweining@loongson.cn" , "wanglei@loongson.cn" , "hejinyang@loongson.cn" , "lazy_linux@126.com" , "mengqinggang@loongson.cn" Date: Fri, 29 Dec 2023 20:39:35 +0800 In-Reply-To: <1635652366.9475871.1703843588198@mail.yahoo.com> References: <20231228033957.108449-1-changjiachen@stu.xupt.edu.cn> <20231228033957.108449-2-changjiachen@stu.xupt.edu.cn> <1635652366.9475871.1703843588198@mail.yahoo.com> Autocrypt: addr=xry111@xry111.site; prefer-encrypt=mutual; keydata=mDMEYnkdPhYJKwYBBAHaRw8BAQdAsY+HvJs3EVKpwIu2gN89cQT/pnrbQtlvd6Yfq7egugi0HlhpIFJ1b3lhbyA8eHJ5MTExQHhyeTExMS5zaXRlPoiTBBMWCgA7FiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQrKrSDhnnEOPHFgD8D9vUToTd1MF5bng9uPJq5y3DfpcxDp+LD3joA3U2TmwA/jZtN9xLH7CGDHeClKZK/ZYELotWfJsqRcthOIGjsdAPuDgEYnkdPhIKKwYBBAGXVQEFAQEHQG+HnNiPZseiBkzYBHwq/nN638o0NPwgYwH70wlKMZhRAwEIB4h4BBgWCgAgFiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwwACgkQrKrSDhnnEOPjXgD/euD64cxwqDIqckUaisT3VCst11RcnO5iRHm6meNIwj0BALLmWplyi7beKrOlqKfuZtCLbiAPywGfCNg8LOTt4iMD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.2 MIME-Version: 1.0 X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 2023-12-29 at 09:53 +0000, Hannes Domani wrote: > =C2=A0Am Donnerstag, 28. Dezember 2023, 04:41:38 MEZ hat changjiachen Folgendes geschrieben: >=20 > > Add tls le relax support and related relocs in bfd. > >=20 > > New relocation related explanation can refer to the following url: > > https://github.com/loongson/la-abi-specs/blob/release/laelf.adoc > >=20 > > This support does two main things: > >=20 > > 1. Implement support for three new relocation items in bfd. > >=20 > > The three new relocation items are shown below: > >=20 > > R_LARCH_TLS_LE_ADD_R > > R_LARCH_TLS_LE_HI20_R > > R_LARCH_TLS_LE_LO12_R > >=20 > > 2. ADD a new macro RELOCATE_TLS_TP32_HI20 > >=20 > > Handle problems caused by symbol extensions in TLS LE, The processing > > is similar to the macro RELOCATE_CALC_PC32_HI20 method. > >=20 > > 3. Implement the tls le relax function. > >=20 > > bfd/ChangeLog: > >=20 > > =C2=A0=C2=A0=C2=A0=C2=A0 * bfd-in2.h: Add relocs related to tls le rela= x. > > =C2=A0=C2=A0=C2=A0=C2=A0 * elfnn-loongarch.c: > > =C2=A0=C2=A0=C2=A0=C2=A0 (loongarch_relax_tls_le): New function. > > =C2=A0=C2=A0=C2=A0=C2=A0 (RELOCATE_TLS_TP32_HI20): New macro. > > =C2=A0=C2=A0=C2=A0=C2=A0 (loongarch_elf_check_relocs): Add new reloc su= pport. > > =C2=A0=C2=A0=C2=A0=C2=A0 (perform_relocation): Likewise. > > =C2=A0=C2=A0=C2=A0=C2=A0 (loongarch_elf_relocate_section): Handle new r= elocs related to relax. > > =C2=A0=C2=A0=C2=A0=C2=A0 (loongarch_elf_relax_section): Likewise. > > =C2=A0=C2=A0=C2=A0=C2=A0 * elfxx-loongarch.c: > > =C2=A0=C2=A0=C2=A0=C2=A0 (LOONGARCH_HOWTO (R_LARCH_TLS_LE_ADD_R)): New = reloc how to type. > > =C2=A0=C2=A0=C2=A0=C2=A0 (LOONGARCH_HOWTO (R_LARCH_TLS_LE_HI20_R)): Lik= ewise. > > =C2=A0=C2=A0=C2=A0=C2=A0 (LOONGARCH_HOWTO (R_LARCH_TLS_LE_LO12_R)): Lik= ewise. > > =C2=A0=C2=A0=C2=A0=C2=A0 * libbfd.h: Add relocs related to tls le relax= . > > =C2=A0=C2=A0=C2=A0=C2=A0 * reloc.c: Likewise. > > --- > > bfd/bfd-in2.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 4 +++ > > bfd/elfnn-loongarch.c | 75 +++++++++++++++++++++++++++++++++++++++++++ > > bfd/elfxx-loongarch.c | 55 ++++++++++++++++++++++++++++--- > > bfd/libbfd.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2= =A0 3 ++ > > bfd/reloc.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2= =A0 7 ++++ > > 5 files changed, 139 insertions(+), 5 deletions(-) >=20 >=20 > When this patch was committed, it also added a bfd/.elfnn-loongarch.c.swp > file, and I doubt this was intentional. Hmm interesting: why don't we have *.swp in .gitignore? --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University