public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
Cc: Binutils <binutils@sourceware.org>
Subject: [PATCH 0/4] gprofng: small testsuite adjustments
Date: Fri, 16 Dec 2022 09:26:58 +0100	[thread overview]
Message-ID: <fb6f3da8-42fc-6911-fcc9-a444bc41df0c@suse.com> (raw)

While the latter two patches are purely cosmetic, I wonder how things have
worked properly without the former two. I'm therefore not going to exclude that
the changes done really need to be conditional upon some environmental aspects,
but it's not clear to me what these would be (or why).

Beyond / independent of these small fixes I'm still concerned by the time
running these testcases takes: The few tests here take quite a bit longer than
building _and_ testing all of the rest of binutils (not gdb of course) for
those targets where gprofng is actually available. One aspect I'm wondering
about in particular: What is it that is actually tested when the binutils build
is a cross one? The produced binaries are host executables, so it's unclear to
me what meaning it has to run on them a profiler (supposedly) targeting another
architecture. Eliminating the testing in such cases would already speed up the
mass testing of many targets in a noticable way.

There are still "warning: always_inline function might not be inlinable"
instances left with the gcc version I'm using, but I can't tell whether that's
a reason for worrying.

1: adjust linking of synprog
2: correct names for signal handling tests
3: correct line continuation in endcases.c
4: eliminate bogus casts

Jan

             reply	other threads:[~2022-12-16  8:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-16  8:26 Jan Beulich [this message]
2022-12-16  8:28 ` [PATCH 1/4] gprofng/testsuite: adjust linking of synprog Jan Beulich
2022-12-16  8:29 ` [PATCH 2/4] gprofng/testsuite: correct names for signal handling tests Jan Beulich
2022-12-16  8:30 ` [PATCH 3/4] gprofng/testsuite: correct line continuation in endcases.c Jan Beulich
2022-12-16  8:30 ` [PATCH 4/4] gprofng/testsuite: eliminate bogus casts Jan Beulich
2022-12-16  8:36 ` [PATCH 0/4] gprofng: small testsuite adjustments Jan Beulich
2022-12-16  9:13 ` [PATCH 5/4] gprofng/testsuite: skip Java test without JDK Jan Beulich
2022-12-16 20:16 ` [PATCH 0/4] gprofng: small testsuite adjustments Vladimir Mezentsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb6f3da8-42fc-6911-fcc9-a444bc41df0c@suse.com \
    --to=jbeulich@suse.com \
    --cc=binutils@sourceware.org \
    --cc=vladimir.mezentsev@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).