From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2072.outbound.protection.outlook.com [40.107.22.72]) by sourceware.org (Postfix) with ESMTPS id EDB9D3858415 for ; Tue, 25 Oct 2022 06:02:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EDB9D3858415 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bfsog3yPxiJv4FdQNoasAh7WMLH7rF1qlz2Kh6T1FHtK0V9Mx3U9VCwdsi6W7Gv4SBrx+6Wepi7XP2Z2gnikY4Y9jlfPP/QnzahR56jAjw+/I2mDzu5Plq95ihaOONBtWKdYOH3LakMRXlmQvhqMupd3uliUt1k2UYifnraNFbjGnne8d9ljYmxiVk5RnHDv0MPF3lzTrpsWQzHW2eFTjezRS2r3TSbcYUoQq6t1kQg2X6gYBDglHp6vIXKFNyPYe6ddmvAu7Rk3/HN8ArZxUUD8tp0tPsJqbVHMwBNhG/YQlcsKRDFl1+tJ/UrfRNexzMmdyiCk3QRNGfWfupFqRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bmMhWNkgEyjOHBa6OTi/DDKIPeZMw/IpMG+nMwGoROo=; b=QwfSHD1lCuvXIUFYVL/LKAMQgt7Mq8ax3yXcIJ7dfCO1N4QL6Y52CPrpsWYzAklJj1QXphavEPVZ1lV09IU2qEfnCey0p8RBFDORJSiboMD+LEa3dUi1ZncCmlsQtV9YkW+CCVTPodtidJb7+96aVTh6NypoLwcJ1SsKWdP+tEqsu78VhWGjwXXlPdpi/muLIcUJIJDOeHee+tNThGDeXTrtuighnDFtARgOt5o9cXMFALljLLdRADLGZB1gkOD1VS53OTtOZhVZrsElOJIj4W1OaC8NXZQQfsjVxosHA5vBRNYhEOgrh3gJsrYl/MU2/fSTmOHTp+pJZM7BSBAOYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bmMhWNkgEyjOHBa6OTi/DDKIPeZMw/IpMG+nMwGoROo=; b=y4eBmJ8syGp1aikrFxYbr7lAjCacKasMDYXln2UBIqyWjtluwd++lSKadQH05amvFM6+8HkwGr8vc9plshcOLE1+y6Ia/P3cmw9ryLYHCsA/+kpgedtoRGzoy9WU/dZRbQHr4TQj4AEupfXWbMq8Hp6qh3Fh5W4eF8Mk8bw6QbMsWVIbVauVr3tMssRAs7IuaDkY1vfD70U9kcMoBvfe6lmcqaRTwDmQLL3HiVWcgsRw7i3x6E41unmp7xqRaa3HoBn/9ppyRf7zIUWjq9BhpyRXYcdvKF8FJ2/y6cOY6iciprUD5yI2Oo/Lyj8PMLjAvLMt1NyR0guHLmY/5kZgvQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8687.eurprd04.prod.outlook.com (2603:10a6:102:21e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Tue, 25 Oct 2022 06:02:04 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Tue, 25 Oct 2022 06:02:04 +0000 Message-ID: Date: Tue, 25 Oct 2022 08:02:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH 09/10] Support Intel AMX-FP16 Content-Language: en-US From: Jan Beulich To: "Cui, Lili" Cc: "hjl.tools@gmail.com" , "binutils@sourceware.org" , "Jiang, Haochen" References: <20221014091248.4920-1-haochen.jiang@intel.com> <20221014091248.4920-10-haochen.jiang@intel.com> <8e2d8a02-1521-5fa2-d97f-3de4c997818f@suse.com> <5b7c68cd-3e39-7b5a-bff6-3b966ab33be7@suse.com> In-Reply-To: <5b7c68cd-3e39-7b5a-bff6-3b966ab33be7@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0147.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8687:EE_ X-MS-Office365-Filtering-Correlation-Id: d5fa26a6-ec29-4d24-267e-08dab64e70df X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 69BdKy0zk2rCuaTXVF/BEWV7PHOtIM8RhmJ7cy8ALhx2KXaKSXOFCJqjepH+Cc482InQZ6UlLYFUiQz64WYlqsl4KMDaEuPxdEKDROrOEEZJ7fwowlzDG+x2iUGnRj0pkXyd1sW3iZo9gXtXkrEOgYWVvqRFO2tQih1cIec4otedZKYydp4xW7J8OkOQYlP07X6QyT9LVpRTNT2G86UDMRMpBb2N1/C5JP3EToTOMr1fvrNXlk7rKZDt9rX/qKIKNPIeQBymzWB/+JfI1W7KvaPxFKI99tQLSf1IGaeo5qjZO3ScxWnT8qAFEYOtKQnv87zXMaXvecIyX3ovOyCPfSRaBdwqzklrnXflQSwyGp/jH7jAOrpRZwiBTyF8j0mCbJM7kBiQuOJsB1yKt3eHomRZDPr0Xv4rg17O1KLgyg9ajQKq1e5/LKK+/KoGaXWGLVQNhvA9PGNaFHLNQA6ufMIS2LUx7myA2hk/Ci4/8wLi1f1POqL1iHrDEz2D59u+XKlsYc2j8UgMvA+/mRigk2D5QHIhOP3dkwJCHXOrR5BLe0EUMX2JfMwUGVIcXTNhVcg883GeOth8RVKo5akx8LGr62YDgeVcAX5J3+A2lbXl/QVEN/Z9suF0psMyg7OsqjwTOuA3ypMiizdWi4QVdYeiu5LAgHCc3jus4hZogHvwm4Q/jpXErAmAiDVKmCiuLECuIYVUl5ElCiuUjUrQPzdInKamHY1/oTVBiODGggsxsuwwobIviBndfSOEhqnM0dJivszObcUEJJhAbD2qoR6RjSQaWiqWaVG+LiHtGEY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(346002)(136003)(376002)(366004)(39860400002)(451199015)(26005)(6512007)(478600001)(6506007)(53546011)(186003)(2906002)(2616005)(316002)(6916009)(54906003)(6486002)(8936002)(5660300002)(4326008)(8676002)(66476007)(66556008)(66946007)(41300700001)(31696002)(86362001)(36756003)(38100700002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eVl4S0pDNGNKcUxyYVVKM3RFR0VPUm1iY2tYanBsc0lqQVBDUGdrMjkvTm9C?= =?utf-8?B?T2FUMXkydTMvQzFobmtXVStqemphRy9LZ1ZWS3NHQWdoanE2RGRTQlN0cU1K?= =?utf-8?B?OFhCWkRxV3RDUEdldGR2THFCMlgxWllYR0x3dEREU0VyV04zWk4vNGJJUkZx?= =?utf-8?B?NWpCeS8wUUVGZWl3dkp6RUkrUTNZRU1KU0JYbHlVdG11V0RpS3NSNUxtSUNL?= =?utf-8?B?U21YR1lLYmtYbks0RmFXWFJhNExzSmxxSVh3WVBZMHJheHpYa1ZGdjFabjc1?= =?utf-8?B?SG5Db1YvbWwwaE5yTjlmQ1UzYjUwcG9hWWZnYmdpNFN1bkYxK1pnMEhSbXE4?= =?utf-8?B?cHIySUZpamUwUVB5UGhWVEU4K0RtRUZzaDkwYkNhd1R6MUduK0VVVzU0NlE5?= =?utf-8?B?aUZIaGJWNXBJcVU3RVJHYTJ6eDJGcERodE9PbitoRUFHR2tWRkhoWnBtcWFC?= =?utf-8?B?ejhQY1B6VjdPbWVvKzBIa0xlVGZIMWV2QW1HUFRVN1ZCa1dQUlltQ2lZbUdY?= =?utf-8?B?U3Q0TyszZ25nazZnK3ZBSTh2S3pqUjMwK1I3N2htNjExR3hNWS9GdTdwVmF1?= =?utf-8?B?ZzN6aFUwbE9NSjA1ck1YMEtMWjZFUTRvVFhlQXJKUFl5VDhDcGtFanpSa2Vm?= =?utf-8?B?UzJYb0ZSMGF5SzUySnpyNFFyUFFVVzk5c1VscnVHd1k1U2R1VW5SbWVQQWhR?= =?utf-8?B?QlRzTDdOdzUzZHgxZEFRV2dnclJYSDUwVXNHV1FzRld1Njd0czYyT2NwZDF5?= =?utf-8?B?ZzRFL3FaVW9mMTdFOFlMWGpuazNQVXBOdjYzUnRqWjdFY2JjcTNxSVluNjl4?= =?utf-8?B?KzdWWHRwQzczYlh3R2o1T1lzWWF5S2tSZkZMTzZCeUtZbFFPSnJGYTNkc2Fl?= =?utf-8?B?Vlg2SjNOTEkwV21FZGpRRzhBbFRIRkxrWmJNVVViZ0k3NXdmU1U2K2VYOGZi?= =?utf-8?B?YVBuUVhLdmZJOFBRL3B0OFhzc2UydHBRb1VVRUJoMFRvVk0zbWNGc3ZnNXRE?= =?utf-8?B?NlY3ODJEUzhmcHRkYm8wQmtKaGNwUWVya1l6TGVPS1UzMS9RQzc3Um1FWjI5?= =?utf-8?B?YU1uZjkxSHJnbUhZTjZCQldBSnhSdlI5YnZBaDM0dktiKzJRNW1lQTVmWksx?= =?utf-8?B?QmRYc3REMW45NnVabVYxNHNiK05RUXNIdEd4RElKMzJRcXlMd0NuUEFZcHZ3?= =?utf-8?B?Q1hMaUFWcXBLdGtvb3dWOWQrZWJDR0xEdjJaRVNEdC9OUnZnY01laElmeklo?= =?utf-8?B?MVZnWCtMdDRPd2h6QldZbjNCTktXNEFjclNpSHNMdlM5djE2eWtVNTJmMlM4?= =?utf-8?B?N1ZwbjhaOERsNDBJanR4cjZLWnNVeVFjSmdjbEtHNlF2dnIzbkxxbGFnN2Zm?= =?utf-8?B?TFI1WnVHMUs0K3BIK0c4Sk4rTGRuM2pTZ3gvNnEzRXVhQVZXUFE2aytOcDk1?= =?utf-8?B?MU8wODBGNnRiVmFrSExVOHAwcklpVnlOMndVK2hRdHplR0xYSUprUTZnaW9Y?= =?utf-8?B?SDRnaXJKQnE0S0huZGdYbFd4ellOUUpCS2JGd0xrY2ExL2lGQS8rMzdUa1d6?= =?utf-8?B?ZnA2WkhEQ2U5bUNzV1FQYXhHT2xsMHdlTEwrMWthWVh1YTM3SEpNWFNvYnRS?= =?utf-8?B?aXVxTGxMckQ4bVh2TFJQS001ckZtaTUzczliL0dpNGdBNHk2aHR0TU1zVGdO?= =?utf-8?B?WFJLZFVjdXlBWisvQTBVMDlrTGc4Y1U2Y3ZGSmNjLzFsWEl1V09pSlJac25Y?= =?utf-8?B?YTZTWEd2VXVqWDJEeFlMOXFBZUkwK2JnMm5WVWdmQmx6NWRpYWhmUGxLQW81?= =?utf-8?B?VTlZODlpVDFmRzh2Y1l1M2tTT0RPZGFveXBOd3JxZzIwcng4ZHZvdmVVeVRu?= =?utf-8?B?OWxaRjRqcHE0c01PUkZYSzNSSjhIVmVIQXAvWm00ZVpibkVKTThtYUFCVDdm?= =?utf-8?B?N0twODIxYXdsbmczcnZxcWx5WkFtQXB5cGdjYTRPTmFOZmlBTm51ZXNwbDJh?= =?utf-8?B?bVZxWE01QlpodGdmQy9pUC83S2tPWW5YWGk3N2R6bjNFTjkzUlNmeGpkMU1G?= =?utf-8?B?WWdUUlZEZ3NydGtOVUtWTnNsdXdweDVBQ3NGQS94aWttR3pQTHNLeUpMRFRy?= =?utf-8?Q?A6wXkbCmSDQvXrq1TE81ip8VY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5fa26a6-ec29-4d24-267e-08dab64e70df X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 06:02:04.5754 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lGe3VlzRogyhbdiD5tgfMs+/V28W5tUN7MWMA6OhEgHbRB06ukTtXbPT70Ht0E0Lvd4lj6VassolIOxhh5EiNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8687 X-Spam-Status: No, score=-3029.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 18.10.2022 11:23, Jan Beulich wrote: > On 18.10.2022 11:01, Cui, Lili wrote: >>>> + { "CPU_AMX_FP16_FLAGS", >>>> + "CpuAMX_FP16" }, >>>> { "CPU_IAMCU_FLAGS", >>>> "Cpu186|Cpu286|Cpu386|Cpu486|Cpu586|CpuIAMCU" }, >>>> { "CPU_ADX_FLAGS", >>> >>> Can you please insert next to the other similar AMX entries? Seeing the flaw >>> here, I'll be making a patch to address the lack of CPU_AMX_TILE_FLAGS in >>> the similar pre-existing entries. When you move the insertion, it'll be easier >>> to keep things in sync. >> Done. >> >>>> - "CpuAMX_TILE|CpuAMX_INT8|CpuAMX_BF16" }, >>>> + "CpuAMX_TILE|CpuAMX_INT8|CpuAMX_BF16|CpuAMX_FP16" }, >>>> { "CPU_ANY_MSRLIST_FLAGS", >>>> "CpuMSRLIST" }, >>>> + { "CPU_ANY_AMX_FP16_FLAGS", >>>> + "CpuAMX_FP16" }, >>>> }; >>> >>> Same here then. >> Done. > > I guess my comment here was a little misleading (I'm sorry for that), in > that in addition I was expecting you to consider the comment regarding > the need for the *_ANY_* constants that I did give for several of the > patches in this series. I think the question applies here as well: Are > there dependent features known to appear? If not, there's no need for the > extra constant. I have to apologize and take back the _ANY_-related comment here (it applies in the other places I've explicitly given it for this series). It was only yesterday (in the course of automating the dependency recording as much as possible) that I realized that there's a two way requirement for re-using the non-ANY form in the initializer of the 3rd field of cpu_flags[] entries: There must not be dependents _and_ there must also not be dependencies. Otherwise disabling a feature (via command line option or directive) would also disable the feature's prereq ones. With my work to (mostly) automate this, I guess there's no strong need to patch this separately - there are many more issues that will need taking care of once the base logic is in place. Jan