From: Jan Beulich <jbeulich@suse.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] x86: Check register operand for AddrPrefixOpReg
Date: Thu, 1 Oct 2020 10:22:31 +0200 [thread overview]
Message-ID: <fbf7c8ee-2c87-2d15-8672-9f59a34e8e3a@suse.com> (raw)
In-Reply-To: <20200930233002.3044234-1-hjl.tools@gmail.com>
On 01.10.2020 01:30, H.J. Lu via Binutils wrote:
> I am checking in this patch and backporting it to 2.35 branch.
But this is wrong, as can be seen from e.g. ...
> + +[a-f0-9]+: 66 0f 38 f8 0d 00 00 00 00 movdir64b 0x0\(%rip\),%rcx #.*
> + +[a-f0-9]+: 67 66 0f 38 f8 0d 00 00 00 00 movdir64b 0x0\(%eip\),%ecx #.*
> + +[a-f0-9]+: 67 66 0f 38 f8 0d 00 00 00 00 movdir64b 0x0\(%eip\),%ecx #.*
... the middle line here not matching up with
> + movdir64b foo(%rip),%rcx
> + movdir64b foo(%rip),%ecx
> + movdir64b foo(%eip),%ecx
... what was written here. Without your change this
movdir64b (%rbp), %rax
movdir64b (%rbp), %eax
movdir64b (%ebp), %rax
movdir64b (%ebp), %eax
movdir64b (%rip), %rax
movdir64b (%rip), %eax
movdir64b (%eip), %rax
movdir64b (%eip), %eax
yields consistent results for both blocks - the middle two entries
get an error issued.
Please revert, and once again please don't commit (let alone
backport) patches without giving people at least _a little bit_ of
time to look at them.
Jan
next prev parent reply other threads:[~2020-10-01 8:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 23:30 H.J. Lu
2020-10-01 8:22 ` Jan Beulich [this message]
2020-10-01 11:35 ` H.J. Lu
2020-10-01 13:07 ` [PATCH] x86: Update register operand check " H.J. Lu
2020-10-01 13:23 ` Jan Beulich
2020-10-01 13:44 ` H.J. Lu
2020-10-01 14:57 ` Jan Beulich
2020-10-01 15:08 ` H.J. Lu
2020-10-02 6:58 ` Jan Beulich
2020-10-02 11:33 ` H.J. Lu
2020-10-02 12:18 ` Jan Beulich
2020-10-02 12:27 ` H.J. Lu
2020-10-07 18:17 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbf7c8ee-2c87-2d15-8672-9f59a34e8e3a@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).