From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id B38593858401 for ; Thu, 11 Apr 2024 05:14:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B38593858401 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B38593858401 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1712812453; cv=pass; b=ewdFV1RrFX07cDnJ2ng3znNlq4JAfM/KQbKpTuzIsYyq3KBDSh6717r6nK3eJgi+lM0BZQIR83KKCNDbriLA7dto4/Ks493OqqaDwTCJ0nSPWByfA6BOZw9lDss52XdjfdUKR7bVvvJabdidGHgSxrNdATueBXnW2/iqaVq/mNs= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1712812453; c=relaxed/simple; bh=p7ofrEyXWZzTBvkAaY8ipSs6gviNjAdlocrGPzbU0ng=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=bXPmW3FM58jRJjRZUxQJ/PHrpwwSpx3asEP/zPoQVj0JjnBnSegoooN95tGTV3UY1X3jjFR0y4avuOScCNrQBZvEUz5ZotwHfWn6uCa7BS/Gv7ScraGMPf3p5pIBcznCSLbayOBCO3YWy7zGV5e0TdoJ4Hcs7W61MODROb9KlO0= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43B543uP029503; Thu, 11 Apr 2024 05:14:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=7KkTo/dwQPgVmBeFqm1WSXiPr/FyZyOrwX1VJgFpqAg=; b=muVfXw9u5X8j7wCdB2QXmFNKLw3O87cJhchLNlor42jDHdZM/azFg4/0w8eaDyr1flZ0 /ZVEUePrg/j3hgsbgMVcTYPvAGGojLtxmJwEZrxRM5Il1FsCJk8Rm5tSO3GThG1C9c38 1jZ2BOktIVZJ5cviW23SWmfRY9vhoFXekOyAu1IJHoSE8biJva8YcLdCJyBXKV58YnRI gUOvlV5WQ9jZ7XNYzeNW12HQluXdS7Ha0nVXAxLuXpp1+hIUQpu7HZ8htMeFiGWAVK4k r3lKhNvk4AaeFeK8gC4WHyHlEU0Q5cSluJ5lueo31xROyRbQy8eBs+zW8u1WxWEm92ar pg== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xawacru2s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Apr 2024 05:14:09 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 43B59Tb2040728; Thu, 11 Apr 2024 05:14:08 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2041.outbound.protection.outlook.com [104.47.66.41]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3xavufchbu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Apr 2024 05:14:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OlXnvnqROnqPh7+TZiHeaP7Kea880iosYJtMc/bZgeNGfeeVAC+nc0O55qa/SF/npKJkMDYzLO0SAmbjENkaZaIytV+1zBzx53Jzb3/7a0AHE5Hu2see12k8hR5g5JLnf+140vpCq1oYo32aOxVMHZR+wD+Dq+eugcm3C7r/clnQehuTewpczkle9hJ+iqX1+LO3g5WEZM19Ba33yZSFR+nAaYjhjBJ6dT7RsctY4fAJ2mT2H4VYN9PSIhseAFkDOQBiBJK/6akEaxtzPNbSt9De+wnxrj031DOj7xsug1vmUDpkvWsqox93sLZpAc3Ju8nCVZTRPiDRp4bSmGcVzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7KkTo/dwQPgVmBeFqm1WSXiPr/FyZyOrwX1VJgFpqAg=; b=WfQ/CB0V/dKkMmfA73KhHUoX7MZ9Mb8ZWuV3yfYi83xBlhY9EazblpzALBihHJrEBtyyw3g6Ui8lloxS39pOW5IUvU6vlEBjgEMaUt2qB9CxOTdzpDIBB8JBjUHnjqHPn5NhrBwMAFclUv8q1YweWtpc1X2MpXxMTqn92IIxLatgfe0TRmt3oTAtlg3D4qkm7VkECSs4BBt6oXJQ/2HNjZrwFr/QfJVHuhXFLDfhBhOvpEnQTgwxjsPxr0paNm453fnQTBPa3qjLlKokRt4ju/ZEHt/YiP3AQGUqvOqHgvjgTwHgn8hv1oXz6+q3DMbG4uSbMnqRz6IgmXwyUAuQaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7KkTo/dwQPgVmBeFqm1WSXiPr/FyZyOrwX1VJgFpqAg=; b=rwpt+u/uh1JpeCNkbKTwhGe50cLYPFKxC55stfWnoh1pDEoQQG1t5OJPHte0fh9XO69IxKj7DHdP5HY0HhCU6dCcr/JkKl7jqKz3gAPM3k3HSmkGfwLZYgEPRgOs+EiXXHKW09GdXvhC0r6TEGOOYoo1T91hPkrkW2OGx2BTrsk= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by DM6PR10MB4332.namprd10.prod.outlook.com (2603:10b6:5:220::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Thu, 11 Apr 2024 05:14:03 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6ae9:dd4d:17bc:4f2]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6ae9:dd4d:17bc:4f2%7]) with mapi id 15.20.7409.053; Thu, 11 Apr 2024 05:14:03 +0000 Message-ID: Date: Wed, 10 Apr 2024 22:14:02 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gas: Fix memory leaks in ginsn.c Content-Language: en-US To: "H.J. Lu" , binutils@sourceware.org References: <20240409230518.2466527-1-hjl.tools@gmail.com> From: Indu Bhagat In-Reply-To: <20240409230518.2466527-1-hjl.tools@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR04CA0080.namprd04.prod.outlook.com (2603:10b6:303:6b::25) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|DM6PR10MB4332:EE_ X-MS-Office365-Filtering-Correlation-Id: dbc80c95-1b6c-4415-7c8b-08dc59e63451 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KynsxJxBQayxQaYtgkFMjiZVre0hms4dMFNFwzQP3XxRTwznd4tJMHnaxvfefrAxENdownQaiXOxUOl12bu7suSmg822WKo+G+grUA508uwjM17y5IA6kUkg3Q/DPbzxiXhO6cLANRMkAaMR+3byirL4Y59IZv3FJy3mc1a2HS4K4J+T//t1Ysmy4TZGU9V+ymSqSCnGZ9dMuE9IY3jd6Rx2BmTYm+FXyGw+6yTj4cMTa5hoclcpGSw4HvNaWSzBs9rKdVfuWLVFqRUkzcdF/whi5Ifhc+u3kDZOz7smI6BdJ6JixWlT1aoZX2r/TtBsbR/DfZnKlMScUC/j/jwsFIB7UXxBAeVkYvoG6ZchGZiQYnZK7hVoNQ8aXW0XKpku9aEk4F/I7u2V2smFEaFCZSlDPd4GC4KDcXIShMJjy02VW7iM3XrPBwD/p/NneuvJb1Fdelv7PGc7RJ0UNT9w4ubzlcq7cVfmjlqoOYmmbNEdK3Pt7NfBnsS0B0cH2N350IKo327wxd3WinwQS8t/4X2qQAz1L0mZXj+4fRG76I3gQpk+wM3uEsLCkH3UVieL551ESIhRnansN4XSgzDgv3G1Mi2uWYKkWzTA/Ncy9fPUMV3yGxaQmM+UFtlPIGyd2rWO8EwxKkH4RwKRSDmd/0EiJGehQcJ2J/G7pptB4s0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eDdoY3dvbGRvclhJQW03VTNEM0ZENm9QRFd6K3JrdnV5ZEpHL3FkUEdLem9u?= =?utf-8?B?N0QzVHI2ZHk2L014VDBQQkx3QTJxN3hmUURFYy85N3RiTHFmWnljaVZFR0Zk?= =?utf-8?B?Y1FGdExIV2ovem5Zb2JWdS8vNVVIVEZMaGxldVpyS1dPY1F3eC9RVjZyMHBH?= =?utf-8?B?S2paZ2ZvUGNHUVE2eGFhWCt2R1U1alUwRUFIWEZndHR5YWtpcW9RQWtVNUxL?= =?utf-8?B?L2xPSkh0cm9FMXdtdHpsOUk2N1hKUzRxRWlMdWxnSHM0TjlXL0RpY21VR3JZ?= =?utf-8?B?dHRLanNtaXVNR1ZHWUxsanhHeFFOZ21YWVJyK1ZSQ2YvR21ZREhwQWtOb2Ew?= =?utf-8?B?NnpXZTZGUVNQczlmZitqM2xpb1R3ZjFNMXhCQURJUlRVRGhMU0hrYmVESndL?= =?utf-8?B?ZTlxTzBLM0UwZmJ3M1ZMUldsbGh5bnUrcWNSZHUzTHFMU1NWTHdiNytKWEEv?= =?utf-8?B?U3pTYmZSQ0NNZ3V0dFhudG0rend2RUJIQXBzT20wMlRKMWVWclQ2SEpBM3hi?= =?utf-8?B?czF4dExCSUhNK2dDdVRuaGNHdklYTlgyWklHNEpZaFo3dVZXQ0FDZ3NKYkJU?= =?utf-8?B?YTFvdWo0c2dkVkxVbWJHTms0djdraHI1QUtqeGR3UGk4MWtETFo2UFFOdW8r?= =?utf-8?B?ejNjU04rUWtrbWpYSytkbTVZVmtHWk5ZSm5ZR0ZxSklFWkQra2JTNzVKWnhP?= =?utf-8?B?RWtzNlQwWXY0L1crcnlZeitFWWJSTkNROFZaWkROYk94dDVKK0JrSEt0YW1M?= =?utf-8?B?dE12c0UwMS90RFhiUFRLMlFTYmFhUjdTYWgrVk4vWEpNM0k4U0ttdEdRWFVh?= =?utf-8?B?V2hsTHdoVTVWOWxtZFdZVUJyUVd5OGgreEJndHNYWHAwWVBSYjl2ZG54TTZq?= =?utf-8?B?eGpOdFRJQ1RTZDBHMmg2UTh6STR5NzBkRTlCS1BjdmpUalVvMllYQzZoVm5n?= =?utf-8?B?SjY4d1c2MThVa05sUHI0Q3lCMnYzbWlyWkNVN3Nuc0o2OWpONThML01LZTgr?= =?utf-8?B?ME9sQ0JxaGlJL1BlbWM2U1JFT3ZsQWtEYThGK21tVjNkTnZSUUw5bDAya0ZV?= =?utf-8?B?WUlqYmZuS1Q1eDM1cmloMHJFeTRJK0krUGlObDFYcFpncDNEa1BaVktWdGk4?= =?utf-8?B?ZWdRMnNESGt3TElXajB0dW9HekZxZ3JjekFJYjE5WnpKMlhPY3BxTWZIRjgr?= =?utf-8?B?WkYvWGJuZkwrWi9uY0ZYNitVVC80RHNmNmF1MHNBR3Y5Wm5PWDdaSUZMbVpo?= =?utf-8?B?Nzg1b1MxdURIMTdoNnF4MmJRRWlLNnZ2cTVBRjJJTXpxb1ZNRWJLK0t1QjVD?= =?utf-8?B?T1N6SlBhMWdROEJ5bE9IL0pERC81My84K2NWS2xxNk51akZlSGNzaVkwc1hy?= =?utf-8?B?OHJCODlyMHZPR3VFWGJteXpxSTJJb0N3OGtXWlZ0a1hGQ29HRFVUWHdKRE5q?= =?utf-8?B?SnlzV3liQ29SOGdDRUd6UjhkQUtZQTBaeVk0UzBuSzg1SHVWbUkvV1dzeFhz?= =?utf-8?B?SWhJeEVTeGFNZDZmaFB1TTdCczJtVWJFOEJZZHNKVWhPSk9lemphUHczcHVX?= =?utf-8?B?SEFrUnhob1JCd1hwSlhMb0I5RFVwRnhXbjFPVm9LTTgzZGdOdHdCOXJLWXo5?= =?utf-8?B?dktuTEVZeVBoWFBNakVZVnNzRjliOU5ENEhYUGVsZUZhYlFBTFhmd2tEQ29h?= =?utf-8?B?VUY3QXpmZWFCMmFUbm1ZbTg0azNVcXhvckozOENhZitkaUtia1JSdDFsRHM4?= =?utf-8?B?VVA5NUE4VXY2OVJLYlAycGFGRENxdXVrRm9rbHh6TDYwZHZjWlhRMjM0anht?= =?utf-8?B?VGNFbGJONnFQRXR6bG1hbE04c3dCRjZzZHlyVGk1UjVDUjNGdVVPUS9rdDBk?= =?utf-8?B?WTJJQVFXRGpMTkhuaEZLeGJETEZsK3pqS1F3Tzh6RHhDdlhzd0E1WDdmbkE3?= =?utf-8?B?Rm04czBKcWl1TS9XdUFaRk5SK0R2Z0FrcGlYOE92OTlzVDl6Y1JBaERGK0xD?= =?utf-8?B?bmljaDdYTk9HMXprWkl4OHgvN1V4blgrR0pKS2NxNUZmd1NCQkJRNks1SWRm?= =?utf-8?B?NWxDQUc3N3E4aUFXRnpaaUkzbjh2MGpSSVlFbFZBeXcyVFFoODkzQmJYS3JF?= =?utf-8?B?WmlxNmM0T0VaMGtlcWVhZmVHc25tTUhFMHRNbjFLbnR4YVF0QStjanNZbVBn?= =?utf-8?Q?coT7il+LvhxXhQCdySXKD8M=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: xAxOAfK9Kv0MCeioq6oY6i/0uv7xFckR5VO3JfbgAVAOR32Z9XDy/OL6PmGC+eY+g11aeXLo+sFeed998uBeMIst4dArSOV8h9Mf5x3ISmsHZ3S3pgk9RsEX7/cS9AooRX9UHBtWgihM0w7OgoQ5qzfHa0P/9+GKCtjut0MEPTXhDXBdqKB6bW1Strt+cixScQRZuohHuij4s3pEUBKq4wNvxPBsDpQTSgrJmssEWNeiBuah6f7W+cwB1N2OuCS3OhvrPCxYqKXWiQnlDfNuRC8hj1QiivrgIGwutTkO10cJi2lIaxqVugoPm/l9YselDhWMcUHmdQPFounRJ2hRh1iXarxA04JqDur5JR8KJFe18Q5KUX4Qz8CwO8GpFQVxdF6ST35o3pSRuomPvFjkxVzgZxAPNrf1vGZCbEwkJZUQKICe6k6zSFjR5neM0mtX9qBOE58nYD59pRomWXXSMyu04BHCX5IHr/USMo6nRbKiJNj2FkgxO6foux1615xwMDst0tVt8yKv5o3w4Bitqynlu6t9QY092p7CgaV3PVXOFgWUJU/V6IvLowRucB/MdLmA1HilwQGqG9aHetFHGk6ZDJrzTQVbgyoT2+lIsuM= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: dbc80c95-1b6c-4415-7c8b-08dc59e63451 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2024 05:14:03.6293 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RtVCYbNlDvjVJxe3zMCE2gEN+PmmzM1vfvFclLnoUiHUSGqdDcMLj101M+Ti12V4dYgTJgpIjPv3yxyphF8bRA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4332 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-11_02,2024-04-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 adultscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404110035 X-Proofpoint-GUID: 7wc6xkHL6kFBMHE2QXaO4boX4U_K7sy_ X-Proofpoint-ORIG-GUID: 7wc6xkHL6kFBMHE2QXaO4boX4U_K7sy_ X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/9/24 16:05, H.J. Lu wrote: > Free buffer memory after use in ginsn.c. > > * ginsn.c (ginsn_dst_print): Free buffer after use. > (ginsn_print): Likewise. Thanks for fixing these. I saw that ginsn_dst_print has these weird way of creating a new buffer and strcat'ing it to the original buffer. I can fix those patterns to use an snprintf like the rest of the file, after your patch goes in. Indu > --- > gas/ginsn.c | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/gas/ginsn.c b/gas/ginsn.c > index 492e161876b..fe7a5253310 100644 > --- a/gas/ginsn.c > +++ b/gas/ginsn.c > @@ -507,6 +507,7 @@ ginsn_dst_print (struct ginsn_dst *dst) > char *buf = XNEWVEC (char, 32); > sprintf (buf, "%%r%d", ginsn_get_dst_reg (dst)); > strcat (dst_str, buf); > + free (buf); > } > else if (dst->type == GINSN_DST_INDIRECT) > { > @@ -514,6 +515,7 @@ ginsn_dst_print (struct ginsn_dst *dst) > sprintf (buf, "[%%r%d+%lld]", ginsn_get_dst_reg (dst), > (long long int) ginsn_get_dst_disp (dst)); > strcat (dst_str, buf); > + free (buf); > } > > gas_assert (strlen (dst_str) < GINSN_LISTING_OPND_LEN); > @@ -570,20 +572,26 @@ ginsn_print (ginsnS *ginsn) > > /* src 1. */ > src = ginsn_get_src1 (ginsn); > + char *src_buf = ginsn_src_print (src); > str_size += snprintf (ginsn_str + str_size, GINSN_LISTING_LEN - str_size, > - " %s", ginsn_src_print (src)); > + " %s", src_buf); > + free (src_buf); > gas_assert (str_size >= 0 && str_size < GINSN_LISTING_LEN); > > /* src 2. */ > src = ginsn_get_src2 (ginsn); > + src_buf = ginsn_src_print (src); > str_size += snprintf (ginsn_str + str_size, GINSN_LISTING_LEN - str_size, > - "%s", ginsn_src_print (src)); > + "%s", src_buf); > + free (src_buf); > gas_assert (str_size >= 0 && str_size < GINSN_LISTING_LEN); > > /* dst. */ > dst = ginsn_get_dst (ginsn); > + char *dst_buf = ginsn_dst_print (dst); > str_size += snprintf (ginsn_str + str_size, GINSN_LISTING_LEN - str_size, > - "%s", ginsn_dst_print (dst)); > + "%s", dst_buf); > + free (dst_buf); > > end: > gas_assert (str_size >= 0 && str_size < GINSN_LISTING_LEN);