From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 30AC83858C00 for ; Thu, 14 Jul 2022 06:42:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 30AC83858C00 Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26E6dUNV026304 for ; Thu, 14 Jul 2022 06:42:02 GMT Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3h71sguju6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 14 Jul 2022 06:42:00 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 26E6fSEm013561 for ; Thu, 14 Jul 2022 06:41:59 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2102.outbound.protection.outlook.com [104.47.55.102]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3h7045d6p9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 14 Jul 2022 06:41:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OVqGLEi/OtDVfvNGglDPKhe74maNduO9moICpwDlUHq0SPOKLSmZxqOI5vNIUe8siH/iHtXQAw8PsvuFrb17K2Zk+Kghn8NXuQy8jl8b6gBJtk+15tTWrSeJ3J3g36/g+pzDvpFpnV71VP7TSYQJ6ivlwxDUucanO96XQJgmYu5zYOHteLB+NeILDHvNC/UVKt2dXRvz2OBMdsJg5P0ph3Wn3+n3d7+Mk3eUD8H3O4nuONIckyQxYtwC9FP6XVTpDdrUwG4NmPIk5C9cTEpFodL9g9YmZChf+DYg98KaQeCst58lT8kD0bjma3c9LRCr5ow7ZFMeZQsOjNVPAOv0nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aWyRGygOYRd/FbA7HmZeyKY1szalawdtg5bLEsyUP48=; b=F8Qr1DG1qy2DhXKOuoWyS7KPDPgawYGbYt4RC/UiMxtwWg8SsunkGtrjdd8cp7QIZuNLEC9pzeE3kyeum9mo2Qwmnh1PPTsg/g0isZHn7LCYnjYjLas0mILdzsMKwPMS0fZoM8P6Wphtg0wjXVJJabKViDuOyMVbapbyPueg/RkxVNlAHhwaSwI6hTQzqzStuxAw4B67uRSOIS3oUPd+dUExKX+UfOOxK7V6rfL8KFtRe4mqVsyHUlsTBlggRHLs8KSF2liguBvGJA0U7MNct+myMKubsl7gHo0XK/lB1kJjulMnIqv8hxeEUBoru9VgXF1EeXIaDe4jgCn0MtCppA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) by DM6PR10MB3802.namprd10.prod.outlook.com (2603:10b6:5:1f9::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Thu, 14 Jul 2022 06:41:56 +0000 Received: from SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::cc8d:db23:414b:ce5f]) by SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::cc8d:db23:414b:ce5f%7]) with mapi id 15.20.5417.026; Thu, 14 Jul 2022 06:41:56 +0000 Message-ID: Date: Wed, 13 Jul 2022 23:41:49 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US From: Vladimir Mezentsev Subject: About 329338 - Declaration conflict for basename To: Binutils X-ClientProxiedBy: SJ0PR03CA0113.namprd03.prod.outlook.com (2603:10b6:a03:333::28) To SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 29056c45-e1cd-454c-15e8-08da6563f1e1 X-MS-TrafficTypeDiagnostic: DM6PR10MB3802:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YTE5WwQHhghTqtCqA4IXKBjqRum+G+2YO0PeJOcN3B1sblZqgcn3wXgfYq6zIO64B4fCPhtBM+G9ES/h3UzW5yuavwPbCCMQI5lpUd1xK5P115W+/VFROKlINyn05GqgY5TquPQbDljYmtz23nQQuoPzvNNny7RDPyzHTRcbAPCdkSieblwcDvItZZ1lgxeIPuVXSpyVWEPhil95EzTlKASHzsEON04OqWHHL7iacULOnxj2Z+JjaVwAlXBedSyzGDZZ521G5eHwgeCw1UtIyQ4pz9V0yW0Z+MlMMJPQWS+7XAs7ilGRj0x4y3A9t3/GPnHK/rEO5vRZ+6Xlpf7EZuYIlSO8sb/N5sucpwMp0IGpr9zDndrqO4q0z0dnKG3LiLzh/SOjPy9wpChuB4ApJDb2pLZ9JQc/oTv89yXh63KwYcp6807wpMt2b4DYpUPfXaAvrygwt49Ki2Wc7WwWHJpyzGZails6A8JrFUix4gl8JYNyA/oJsgfuNtsmbXbtdsRRxxGJ3Su3bkYjJW6vDLFkXimYAWZtyk05Iug/twUpCRp8KHwBn5pmAC44yIN0Hyt2UVo3/lmC4fpd9IxAH+7YFZaufUdb225wdZlOpJfzpHAP1JyFYLs/aqJUM3X0X/iEp0sQJfkkEflcoAvfnfbQUhtu4ZaG/LZljTH9Z6XwNqiHr6yzCmWuZMbuY7UHIkGYjidkX44hy2Do1HOpiraQJYmr7bU94xW5UW3oEGvRnGCrwpxUEUz8nnono8wlYoKJbg7D1LKQjoWNGWgNAS//nM6d4hWklSAxOgAPcVmgUyQtQXKpSJbddgU5B0zRAPXDiSZ/VOfcQmnESF89W9O8uqRIeUkCIuoFy96rWHY= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR10MB4636.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(376002)(39860400002)(136003)(346002)(396003)(316002)(6486002)(41300700001)(2906002)(6666004)(44832011)(6916009)(8676002)(66476007)(36756003)(33964004)(6506007)(31686004)(66556008)(186003)(6512007)(66946007)(166002)(86362001)(2616005)(31696002)(83380400001)(8936002)(38100700002)(5660300002)(478600001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1ZQVEhhcTh1dUh2dS9Pam5IRDFBbVUxQ0ttd2ZkYmRlM0pCb2IwSjZYcUVw?= =?utf-8?B?enpKNzBPZzhzN2MxOTVUVXZkMmFBNkozaG4zeThjbmJrajkxUGZremQ1bDdh?= =?utf-8?B?RjVRWEdDdGRPcUI2aEhlaktvV3ZVSUdrRHRpdHdjeHh5bnJYMEYzVFlrZ1E4?= =?utf-8?B?K3ZYVEJKUEtReXJuTnB2TG10Szh2a1g2dlFwWGNzMzNpaHVJa3RlVFhIRkJZ?= =?utf-8?B?bjZicXRXS290a01aamFSUzBuaThJWjRaME9BNmdzRUVUbHl0UmFxTnJDemhK?= =?utf-8?B?dURacUJaMEdLQkdYNEx0QTlkdVBpU1ByU1NockN6VXpJNWpGMjZMaUU4eHc1?= =?utf-8?B?Ny90TVowTTBRNDJBN2F0bktQSzRvdkFlUnNZc0pNdkltMEtJTjBESzczWVJw?= =?utf-8?B?ZVhGOElWc295YkcxR2k0VWxZUEs0NW5oY3M2VGZEaitSVXRnM2RXU1ZTNDdo?= =?utf-8?B?RVpkVGRWQlpGYWpGQnRndFJhMEIzS3RVZW9qbGF2eHpLdTF1djQ2ZHJ0c2cy?= =?utf-8?B?SktMaHJnT3RESWM3dm5lZDNqeDhuWS8vblc3dlREUFc4V2ljSUVvdWRjYVVw?= =?utf-8?B?bWtIK3FzV1R0ZURZWE0xQnEyd2hncmUyNm9wbnltV21XSi92NDgrUzcyTVk1?= =?utf-8?B?YWppOHhERnl3N3o0UzJCYWx2akxTZmNXcEV4REhDeE83dTQ1WC9hSk0wVzNs?= =?utf-8?B?clZTc0tkVFBwYWY3TjlWQk4yMytDbm5mbEVuS1c0NWJPdzVPZ2ZqQ2hIdUNo?= =?utf-8?B?QlpoUXkxMUkxaHg1QzVZeVo3K3R6T3FiRzZ1T3gwZzZJYnk5SzFVY0plMUtD?= =?utf-8?B?ZE90U1dlM1BYV1hXdWJ6NUtBeXFQWXV6bDRJUDdKSldHMjhFSVhwNlhDY1pQ?= =?utf-8?B?T3NNRW8xWWl3UXp4MDlSNHdwN0dVZ1VuVG5CWVNuN3QyNStjd002WE5aSWQz?= =?utf-8?B?YUhIQ1piakdLcXBtb3dFS0d5cEJLR3dUWjd0bFVWVzdzNVpic0ZIeWt3QXFu?= =?utf-8?B?UGd4NGU3VDFzL05pUTRVWEQxWDZuRFYxWWQ5aStyUnN6b0M3RFlKcUc1bGVS?= =?utf-8?B?QjZkZGlDc2lRZjJkMG1lcUttNzA4T1V1aGk4cUFGbk9uRXFpdDZwNDZ6RTZs?= =?utf-8?B?MHVWNU91Nmxzd2tCSTl0UGd6bTl6SHhwb3lEdGpwSXdubUU2cnF5a29OOVdR?= =?utf-8?B?U1g3ZEFaLzFPSlo1Ky9PKzJ4aDVaeUtIc2IwWUthcHk1bGVraFI0Z0M2VjBC?= =?utf-8?B?TWw5ZDk2S0toMEpSY2o5cnFTR1RUWDNYSE1xUGM0dEt2SU9TeEhTdURaSUZB?= =?utf-8?B?a05TQnJaRlJodUprSnVSNG1TbWlGY0QzM0ozRG1YL2pPMXpPejQxVjRGMlpK?= =?utf-8?B?YU9EN2hEZlljcDA2SUhIa3FaeFJzcXRDOUUxU0lQbytCQ09BYzh2VHJDVXNI?= =?utf-8?B?VnozRU5FVGFPbFhhNVhxcU9INC9IUnQvdnRQMkdpVVJyWVRENlo5aWpXTFFl?= =?utf-8?B?SmdFQUExWUlKQmhja3RWQkJsT2tJV0tIMVZKbFFYemVyT0VSTWdXKzdKSnV1?= =?utf-8?B?QmF6N1BYWFpRS3pTWlZoME5QT0llSCt6bUs5Q3lJTzM2YXZIZHNNYitPL20w?= =?utf-8?B?OFE2MWh6L3U0L2d1V3RpWXpONDRvWWpQSi80WXl3djF5c2wvQ20xd0UzdDdY?= =?utf-8?B?OW00UFU5NCs5WWNRWVJ0MGFDQzl1clNjWDRTdlNsUk93M1E1akg1a2ZlUDM3?= =?utf-8?B?RS9KckdFZEpKTU9TamhXNjZ6Y08vVEVUd1hXSlI5NmdvbE85K3dTSW5RZXBF?= =?utf-8?B?UHBKcXNTV2dybFZ6bE82blVveFBldERXV0tGUytGd3VDb1FJU0tlZkRzNndW?= =?utf-8?B?eUFoc3VQUFAwbEs2NU02dEhIU0I5eFFuQjFuelk1K3lKMTFpYVBadlQ3RHpk?= =?utf-8?B?Si9laU9sS0x5ZlRudUh3d2lKbU4yR3JWbzJTSnF6OWc0cGFVV3FIZklaYWN3?= =?utf-8?B?Lzhhcm55OHVVckszNDNKNnV1VlMwQzBseXZFaUpuelpqYVpVTVB3cVdiOHMz?= =?utf-8?B?RlpTL1ZFOUR4QzFZSjBXbGRSZG1nYkNXQU5YdWE3aTVNOGpMaE4vWVVFUGMv?= =?utf-8?B?RjM4azdRNzMrLzVkQS92Z0Z2T1ZBVHdHSG1sTklEK1ZxaUtjQ1AzbE5NSVl2?= =?utf-8?Q?qeP/cFd2ISdAP+WxXGcgv+alfE2/f9lTqVz9yhGApM7P?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 29056c45-e1cd-454c-15e8-08da6563f1e1 X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4636.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 06:41:56.1668 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Pn1xBlLTsbA5W48ySe0U9qZ8rAxvmuqmRWVTmw61Cn9hPvIqcUlYMtcqO3PS0rMJWh8PNEzj96kUzujv+IUxl19k4jp9TEIk5TLqQAcBxJQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB3802 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517, 18.0.883 definitions=2022-07-14_04:2022-07-13, 2022-07-14 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 phishscore=0 spamscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207140026 X-Proofpoint-GUID: vOn4sLMNrh3wc6sKx51QDnc2fwADd7a6 X-Proofpoint-ORIG-GUID: vOn4sLMNrh3wc6sKx51QDnc2fwADd7a6 X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HEXHASH_WORD, HTML_MESSAGE, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jul 2022 06:42:09 -0000 Hi team, I am evaluating 29338 - Declaration conflict for basename and I see a regression in the efbecf1e953 commit. % git log --pretty=format:"%h - %an, %ar --> %s" --graph --name-status* ...  efbecf1e953 - Nick Clifton, 6 days ago --> Update version number| | M     bfd/configure | M     bfd/po/bfd.pot | M     bfd/version.m4 | M     binutils/configure | M     binutils/po/binutils.pot | M     gas/configure | M     gas/po/gas.pot | M     gold/po/gold.pot | M     gprof/configure | M     gprof/po/gprof.pot | M     gprofng/common/config.h.in       <---------------- This update is wrong. | M     gprofng/configure | M     gprofng/libcollector/configure | M     ld/configure | M     ld/po/ld.pot | M     opcodes/configure | M     opcodes/po/opcodes.pot | M     zlib/Makefile.in | M     zlib/aclocal.m4 | M     zlib/configure But the real problem is in our configure.ac scripts. % grep -n AC_CONFIG_HEADERS gprofng/configure.ac 220:AC_CONFIG_HEADERS([config.h:common/config.h.in])   This config.h is used in all our sources. % grep -n AC_CONFIG_HEADERS gprofng/libcollector/configure.ac 65:AC_CONFIG_HEADERS([lib-config.h:../common/config.h.in])  autoreconf updates ../common/config.h.in, which is not what we wanted.  lib-config.h is not used. In build time, we use config.h from the ../ directory.  We use AC_CONFIG_HEADERS() in gprofng/libcollector/configure.ac to pass -DHAVE_CONFIG_H for compilation. I can make the following fix: % git diff gprofng/libcollector/configure.ac diff --git a/gprofng/libcollector/configure.ac b/gprofng/libcollector/configure.ac index d3c6bd5588d..2e2185a11a3 100644 --- a/gprofng/libcollector/configure.ac +++ b/gprofng/libcollector/configure.ac @@ -62,6 +62,6 @@ ACX_PROG_CC_WARNING_OPTS([-Wno-nonnull-compare], [GPROFNG_NO_NONNULL_COMPARE_CFL  AC_SUBST(GPROFNG_NO_NONNULL_COMPARE_CFLAGS)  AC_CONFIG_FILES([Makefile]) -AC_CONFIG_HEADERS([lib-config.h:../common/config.h.in]) +AC_CONFIG_HEADERS([lib-config.h])  AC_OUTPUT % ( cd gprofng && autoreconf ) This will fix build. But gprofng/libcollector/lib-config.h.in will be created. % git status On branch vmezents/2_39 Changes not staged for commit:   (use "git add ..." to update what will be committed)   (use "git restore ..." to discard changes in working directory)     modified:   gprofng/common/config.h.in     modified:   gprofng/libcollector/Makefile.in     modified:   gprofng/libcollector/configure     modified:   gprofng/libcollector/configure.ac Untracked files:   (use "git add ..." to include in what will be committed) * gprofng/libcollector/lib-config.h.in* Maybe there is another way to fix this. We need a fake AC_CONFIG_HEADERS that will pass -DHAVE_CONFIG_H for compilation but will not generate lib-config.h and lib-config.h.in. Thank you, -Vladimir