From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by sourceware.org (Postfix) with ESMTPS id 65FAC3858D37 for ; Mon, 21 Feb 2022 13:24:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 65FAC3858D37 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-16-776UYUyLPFWETjbwLp3TKw-1; Mon, 21 Feb 2022 14:24:13 +0100 X-MC-Unique: 776UYUyLPFWETjbwLp3TKw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K3vx+F3m8uF/SMGdp3VqK22kFQCvYNJisVa6yOf21dKl4SCx+x8q5DIZWzaPy3amOeLyLpZAs29pkPLjsEWoc3hTT1dNVVB7KZH8RNYjig8KkXKkVc0oAWmAT4dNTWDYpMTVo6W6zynYbUyN9jNc7eq8C/yAjQjCYEcbZ0EW4LaiByHmJfzoQJc0mmG45MVpS6EIzOEFJny/1WOPK/4d5ZBX3+5WuCf1CysR7lI1P5MwNcFBwGXLZltL7yONUDxyUrHGhHh4sHssHIdLrqToFDXfdVkkeRvoyPN0yx72HkmTiDc75vDvg500NCeZdsnvz751Rrpxump7mNYfU6zk4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tznmF37uxVLpqoVApI8o5mo6EuPtsHxhP/vSjtAVKFY=; b=WVLkkCQIe42T9EpTFnAcAeBl35BAj37AL4cLmkTmZVGYU/Pncm6A0PnAkJCQ4usZfkZsHUuq2zAuPnig9TlW07pgcKohVeLPjLvNC76ZK4lrr8UWi+mEVFCY06M9KvxdG5JT3bKf/PYLPoow6mVGrhiabHZS0cSmAqi9Oy5ceXizOsj5ybpjALKNm3sIoLyymul7eUS5N8y7FdkISDXub0Te00aGrEeQbp1xtfgq29YhvTrsFGj+W2sv5dugtFBvmS47qrWyxupR0uVSK8x2OreCqDPlOKB67QMy/gpviEEZznGbz0krM/6D/j0RvxaBRrKge78gYly/TskpoK0Pvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AS8PR04MB8675.eurprd04.prod.outlook.com (2603:10a6:20b:42a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.26; Mon, 21 Feb 2022 13:24:11 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.4995.027; Mon, 21 Feb 2022 13:24:11 +0000 Message-ID: Date: Mon, 21 Feb 2022 14:24:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v4 1/3] RISC-V: Minimal support of scalar crypto extension Content-Language: en-US To: jiawei Cc: kito.cheng@sifive.com, nelson.chu@sifive.com, jimw@sifive.com, philipp.tomsich@vrull.eu, mjos@pqshield.com, ben.marshall@pqshield.com, cmuellner@ventanamicro.com, palmer@dabbelt.com, andrew@sifive.com, lazyparser@gmail.com, siyu@isrc.iscas.ac.cn, schwab@linux-m68k.org, binutils@sourceware.org References: <20211115030343.276103-1-jiawei@iscas.ac.cn> <20211115030343.276103-2-jiawei@iscas.ac.cn> From: Jan Beulich In-Reply-To: <20211115030343.276103-2-jiawei@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0411.eurprd06.prod.outlook.com (2603:10a6:20b:461::25) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9dfb0f48-ce48-4d44-a5c4-08d9f53d727d X-MS-TrafficTypeDiagnostic: AS8PR04MB8675:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O7b4vgiY8VNy5uK+EqZ6VdwdyfqN7QiYcNuKGnzwYRuf+qFlQljjGhVFXpCKLuWSMKDKCJulwQ3SPqPrv55IcoSr3dGU4gQLEo4ZLCLadozn2dcPdb/XZzPc3l8H8kldLBUhZJIXec7K2k71flLw7sCo5gHMwYDfYolNMS+/qUcykI5t4iobEKcCJpuVYYccjYnsQePq/wmqvlHd86JOIvXnsoPgNvI3+ODqGZ4qOIArjTlUsG1kqPm1o90TKUCt7P38t7VBXnWvBR4H/xFxjJmVtsQT9FURL1mXjozhXuEduF6rD2cJveiQItLD49kO7FYspBwus+TrXArwVAFWKj17JhIb6W4vu59iqfCAefX361Y6yPmIIbTEHptVxpmrbN+i55eoVDKNAJkTHgtn9zproInRar3sbd0JJYHMJh6NfdPYJ9s2KeEOONhrU9ZMIrCjAnUvLlQ2UMElkmzsKasBWB9qsnKN1iCipKFytQQcNFJQEceT+319SXcEYU/5Fh7S1PHcaZQn9fhvzo1It9R4aP1Fx7YkWpgOtiUHr1/+IYeX7O4iS1E4gYwzXMPZEaBvIFg/qx6CkTUQ4gblrlYOlTLHZo/Zi3J0p14RR9wl18oX4UaqpD5ngprHjLVYzdJwaLlXvCP+UFbJUeCbfL9WmxIK2hUFZkdxEhrsvj87I4YQw4iQuZTcLjp38yd2eqhecw4su0qKBg/egVEoKXz0EMObvYmPX1eqzjH+YHVqfOgw8e/7QfeaQjz5Rbt5 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5600.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(186003)(53546011)(6506007)(38100700002)(36756003)(66556008)(66946007)(8676002)(4326008)(31686004)(66476007)(26005)(6512007)(8936002)(6486002)(508600001)(5660300002)(316002)(2616005)(86362001)(7416002)(83380400001)(31696002)(6916009)(2906002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V3ZlUmt1VG1BbnVPUVRkTkU3UGxNTEp6Z3RtZTVaZ0tUczc4cW80ZUF5aVdH?= =?utf-8?B?RkZuejFXWVE2MG5UVjI3dk5sanFzZGJXWFQ3dndOcmJiNW1DMDV6UGUwU3FT?= =?utf-8?B?TFd1dWt4akplYWkzdGFXOHl1UE14czZqS3hHTStwWktkVkhuVXlRTnk4NGF1?= =?utf-8?B?M3RrQ25GVmgrc1M1NGRXS2haOEJ5NHpDNWtxcUFESXo5MHFGOFJDL09vanZr?= =?utf-8?B?cEFmVXBWeW1NMzlmTjNrOUxRTlFSd0FpK0tiQkp2YTdRVXFtemlCUGlGZEhW?= =?utf-8?B?QzV4MU5YaVR4NjdKUGx0YSsrUWZvRm1WdHRvZ25FSDRSQk5ab1JNMWlRL0dK?= =?utf-8?B?Q0tRYm9QcFFTQWNhZ2lhUFk2eWtvdW1MVDZMRk1ycysxMEE4K1FMNzNhT2hl?= =?utf-8?B?VURsMnBSQkY1RXRja3ZzMHp1OHExSEVQQlJhTnNGY01RbWVTalNISTlOZmd6?= =?utf-8?B?cStuMXZPTmx4S2MrTGM3bVY2WlB4eCt2c05xdG5aR0VHRmRaK2svNHBpSVAv?= =?utf-8?B?QUdpZW5iMnBFVHlmL25lYk4zTUVVTXYvN0h2L1RML095Mk5BRU41TWtxdDJG?= =?utf-8?B?QTBaVHJQd0J4a1NvQ21kd013TUxnR095TUovamZZSTZTYXQvMUlmMStVaGV1?= =?utf-8?B?Z3BwbElTaVFYK0ZTUUFEcU03NTBabXllOEVsaEtzeisrS3lHWkpqM2ZCTjFa?= =?utf-8?B?MmtHOVI1NURGb0dhbW4zcmsrM0t4V1h0Wk5BQ1BueG83NlMxY3dIcTFjMExt?= =?utf-8?B?Rnhad3Z4YmYvY0lyR1N6UnhLU1gzbmZjMXBZYTJMb1VuL3NKclFXOEpmVnRF?= =?utf-8?B?TG1oK0R4WWtUQzc2YmtDdXVVTk9GVkY3OFNCTVFCVnpGTElZVEl5Q0hjcmhY?= =?utf-8?B?eXJKRnk3aWxndzZjNkU2OVNhTE44YjlFcnJNZnprRjM5VTdqTnlodGEvQnZU?= =?utf-8?B?cG1XNHZHeWVqVUQraUo5NnZHMzdIalJWaGZsRFRBYml5Zk9PajZDWGd6aHZS?= =?utf-8?B?M0FoNlZqMklGOUlYRzRxQXZDOHlMVVl2ZzVuT3Rmb0p6UVZ3bGp4b0lrUThG?= =?utf-8?B?d0ppbzNQSlNhNjFMVjBMWWZUaTdBWkJDM25RR0FBaC9uYUZsTlcraDJiMkFP?= =?utf-8?B?aUwvRDFRUTZ3UGZYWGQ2RFMvU0JDR2pmYk5ubzVBT1Z6emdTbXAvNHd3bnZm?= =?utf-8?B?ZFBXSVNFdi9MVVhQOC9UaW9YNGJzVjFjWmh0eXc0TG16T25CT2R6Qk9BWUc5?= =?utf-8?B?RFRoNnoxR0xwNUFPNU0ydUs3MGlBa3BOR0R3Mi9SZk5PU3dGd2doZnVZQThi?= =?utf-8?B?SDFPN3U5bFFNR2p6ZVNFUWVyd3FIbzkrNXR5WlRiSkk3VkJ0TStHNUxJQTBX?= =?utf-8?B?aFZNYmJmM3crZlAvUlJibVhMZmZXNXYzTVRidVlmL3cxRytENDVQLzNaTEdl?= =?utf-8?B?cUN1akpoelhOYVJkaWNINzFhQzZBWjhnUm5MVzhoL3BITG92Mmh4R0RTZ09k?= =?utf-8?B?NFJ3dHZYM1hZbGliNHR6c0VLdlNtRjM2V1JFVjZlUTI2eTFEN2M1c3AyazNW?= =?utf-8?B?aHFUcTY3TjkwRnV5VVMxN2hNdzdzTEZuMTlzM2JnZ1ZFYitoUC9oWURoRzE0?= =?utf-8?B?NWxheXRrS2ZtOHJEdFVTNG41N1dOSGFRREZ1ZzRjSk1TczdhRkFtZU0vTDFt?= =?utf-8?B?UGhjYy95T0xVTkphc0o0V3d3eEQ4b055M0QwSi8ralFEMDJueWN2cEVocUp5?= =?utf-8?B?a1Y5RHhsM2N0V2JKSDkzQ0hSdmNEUHUySFAxS2kzYlBCczJXVEhMeDlJWS9P?= =?utf-8?B?YWt0dE1lT1VnMHAvbWNsTDlsSTFzWTlCMUZmVCt4THlxWHVKUFo1K1haOUZj?= =?utf-8?B?R05zQ0ZHUTlBd3pRVE9ZODNRcnFxTDdsMzNUUVVUaG1UWjRkT3lHZm5ZYmdF?= =?utf-8?B?M2t1Tks5WkdDa3ZLdklhVGcwNGxySTMvdW5Vb25TQ0h2VXRDUU9GVGF0WXdQ?= =?utf-8?B?ODJ5TmdmeVlvTHRRRlhwZG54MnBxbXVyWFRML0RkeDg4SHVBUmJGWjdoaEdY?= =?utf-8?B?MG14c1ZzdzhGYzNFZUZ0S1Fqc1RXcUtYK2JHSHltZjNHZVdKU1hPQmVGQUpz?= =?utf-8?B?Ly9pSVdBMnJmYm1EcjM3dHVsMU14aGJTb3VTNzNTRTZxWllvSTk2TGtpUVZ5?= =?utf-8?Q?1biUntWkMADSgzgvsZhHfOU=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9dfb0f48-ce48-4d44-a5c4-08d9f53d727d X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 13:24:11.3845 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i8TL3xMQB5Dtp+nPvF8kvnL+pzF3qLJdCGhvyA4NbpaInUs6RQ0mELKp9MuYBjBD2ZdI5DoJO2ytWJPZKfpSkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8675 X-Spam-Status: No, score=-3038.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Feb 2022 13:24:17 -0000 On 15.11.2021 04:03, jiawei wrote: > Minimal support of scalar crypto extension, add "k" in riscv_supported_std_ext[] to make the order check right with "zk" behind "zb". "zbk*" is sub-extension for k-ext, so it added behind "zbs" in riscv_supported_std_z_ext[]. > --- > bfd/elfxx-riscv.c | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c > index 3ffbaad66dd..152fbe3d160 100644 > --- a/bfd/elfxx-riscv.c > +++ b/bfd/elfxx-riscv.c > @@ -1075,6 +1075,20 @@ static struct riscv_implicit_subset riscv_implicit_subsets[] = > {"q", "d", check_implicit_always}, > {"d", "f", check_implicit_always}, > {"f", "zicsr", check_implicit_always}, > + {"zk", "zkn", check_implicit_always}, > + {"zk", "zkr", check_implicit_always}, > + {"zk", "zkt", check_implicit_always}, > + {"zkn", "zbkb", check_implicit_always}, > + {"zkn", "zbkc", check_implicit_always}, > + {"zkn", "zbkx", check_implicit_always}, > + {"zkn", "zkne", check_implicit_always}, > + {"zkn", "zknd", check_implicit_always}, > + {"zkn", "zknh", check_implicit_always}, > + {"zks", "zbkb", check_implicit_always}, > + {"zks", "zbkc", check_implicit_always}, > + {"zks", "zbkx", check_implicit_always}, > + {"zks", "zksed", check_implicit_always}, > + {"zks", "zksh", check_implicit_always}, > {NULL, NULL, NULL} > }; > > @@ -1127,6 +1141,7 @@ static struct riscv_supported_ext riscv_supported_std_ext[] = > {"c", ISA_SPEC_CLASS_20190608, 2, 0, 0 }, > {"c", ISA_SPEC_CLASS_2P2, 2, 0, 0 }, > {"b", ISA_SPEC_CLASS_NONE, RISCV_UNKNOWN_VERSION, RISCV_UNKNOWN_VERSION, 0 }, > + {"k", ISA_SPEC_CLASS_NONE, RISCV_UNKNOWN_VERSION, RISCV_UNKNOWN_VERSION, 0 }, May I ask what purpose this addition serves? Without its use enabling smaller scope extensions implicitly, I find it at best unhelpful that ".option arch, +k" is accepted without having any effect. Jan > @@ -1146,6 +1161,19 @@ static struct riscv_supported_ext riscv_supported_std_z_ext[] = > {"zba", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 }, > {"zbc", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 }, > {"zbs", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 }, > + {"zbkb", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 }, > + {"zbkc", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 }, > + {"zbkx", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 }, > + {"zk", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 }, > + {"zkn", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 }, > + {"zknd", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 }, > + {"zkne", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 }, > + {"zknh", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 }, > + {"zkr", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 }, > + {"zks", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 }, > + {"zksed", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 }, > + {"zksh", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 }, > + {"zkt", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 }, > {NULL, 0, 0, 0, 0} > }; >