From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zmcc-2-mx.zmailcloud.com (zmcc-2-mx.zmailcloud.com [52.37.197.7]) by sourceware.org (Postfix) with ESMTPS id D89BE394D82A for ; Wed, 23 Sep 2020 15:29:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D89BE394D82A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=symas.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hyc@symas.com Received: from zmcc-2.zmailcloud.com (zmcc-2-mta-1.zmailcloud.com [146.148.52.56]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by zmcc-2-mx.zmailcloud.com (Postfix) with ESMTPS id 0E27040605; Wed, 23 Sep 2020 10:29:04 -0500 (CDT) Received: from zmcc-2.zmailcloud.com (localhost [127.0.0.1]) by zmcc-2-mta-1.zmailcloud.com (Postfix) with ESMTPS id 8EA6ACD76D; Wed, 23 Sep 2020 10:29:03 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by zmcc-2-mta-1.zmailcloud.com (Postfix) with ESMTP id 74516CD771; Wed, 23 Sep 2020 10:29:03 -0500 (CDT) DKIM-Filter: OpenDKIM Filter v2.10.3 zmcc-2-mta-1.zmailcloud.com 74516CD771 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=symas.com; s=37C7994C-28CA-11EA-A30F-68F90BB9D764; t=1600874943; bh=1FlB3NYmaVLb5WUqMlQQYzt9B9ORVqQB/v+wBbLuQdg=; h=To:From:Message-ID:Date:MIME-Version; b=X9ntNULqBBrDUCL+bdodEiwZHJNJja4V5WGozGjEd0h4Nx4wfzTYsrfC2tTkApfu0 3V7/gxVgZMq0OjUOmwOufGbEDGFqoOdmisBa5o93LZFlxfyZ0DZ4jhMkgwsYrxuy62 SZw8D1QpsddFauqc8nI+KKrg18xlqeTD7Zi+cT2qwvp0yLJ4K8cIDYENt9xpEq//FC 5Ht1XgXyG2Zw9McF9GHFhivkClADXOuFgWQZqrUosatct7OdO76J3QuqKjiVtLBbud Mha112srHYs5IvnHCKwAd9XA70wMPOJYqwmMbdYWxUwn+QEMr65Wk81eLUwgzLSSXJ 7nfQ5YSRP+LwQ== Received: from zmcc-2.zmailcloud.com ([127.0.0.1]) by localhost (zmcc-2-mta-1.zmailcloud.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Ji5AcQvISGa8; Wed, 23 Sep 2020 10:29:03 -0500 (CDT) Received: from [192.168.1.155] (unknown [84.203.28.168]) by zmcc-2-mta-1.zmailcloud.com (Postfix) with ESMTPSA id 9425DC095F; Wed, 23 Sep 2020 10:29:02 -0500 (CDT) Subject: Re: [PATCH] dependency list for static libraries To: Nick Clifton , Fangrui Song Cc: binutils@sourceware.org References: <53b8973b-40a4-2550-3307-66d7f13707d5@symas.com> <64fe82bd-9c00-b232-98d2-f46182fb16ba@symas.com> <9889c54b-4dd3-2275-6621-c2391cfd268d@redhat.com> <31f9062e-175d-06e9-695a-797c7ee11420@symas.com> <58620dc1-3bb9-aaae-b476-ebb613ecb627@redhat.com> From: Howard Chu Message-ID: Date: Wed, 23 Sep 2020 16:29:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 SeaMonkey/2.53.3 MIME-Version: 1.0 In-Reply-To: <58620dc1-3bb9-aaae-b476-ebb613ecb627@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_RED autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Sep 2020 15:29:25 -0000 Nick Clifton wrote: > Hi Howard, > >> Sorry for the noise, this attached is the same as previous but with fixes >> to whitespace / indentation. > > Thanks - the patch looks good now, although there are still a couple of minor > issues - and one major issue: > > * The new test fails for the alpha-vms target. This is not serious however > as almost all of the ar tests fail for this target. One day I will track > down what is going wrong and either fix it, or arrange to skip these tests > for alpha-vms. > > * There are a couple of minor formatting issues. Specifically: comments should > end in a period followed by two spaces before the closing marker. /* Like this. */ > Plus function calls should have a space between the function name and the > opening parenthesis of the argument list. like (this) I can send an updated patch after the major issue is addressed. > The major issue is that I would really like for this extension to be supported > by the LLVM community as well. It would be a shame to add it to the binutils > only to have a different solution implemented there. I might have misread the > emails but I believe that Fangrui still has some misgivings about this approach. > Is that correct ? If so, then I would very much like to see them resolved > before we commit the patch. It still seems pretty obvious that handling dependencies once at the library level is more efficient than sticking a bunch of free-form notes in every single object file. And it should also be obvious that choice of library is a buildtime decision, not a decision made solely at the time the source code is written. (And for shared libraries, it's a runtime decision - even further removed from the time of code being written.) -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/