From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2088.outbound.protection.outlook.com [40.107.105.88]) by sourceware.org (Postfix) with ESMTPS id 5C2643858D28 for ; Sun, 16 Oct 2022 06:25:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5C2643858D28 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VdPVX2x/GPPAwJdIoldmoiMVNX8fwMEKlIq5V63+i3jEXlPnTfx8KtSQ31L2E4j6e+18DcY0kIKlF67cdTt99EVMHeLUaxcUxyWRQXAs48Slr6hmLVjVDlWcPsAwEg5aa5nrW6QbOF2dI6FMsZC/7CbIivELi7jvX6xs3OMsbVdvQaYPapdhtuY34+ifT26T1uqaUWuLaBlnCRN3laI4L8aY90rf8dDWTmgTF+8KOFp8ZECDAP7LEy3h8Gi/5Dz8vFkinNQ0ejvqfQIqnloFragkV9Sj/WQGGGhKIpsFxgtilFv2urFipYi2h8ZxvliL5ofq+P/tWntoj2hZslpuSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iIbjBOLSDLy/FgXR/yVM3y+HntWiLY362dMsqxZVW+I=; b=FPoFr6qKYkyq1UrJHvrTAz0fc6ZbYhL6AV1fUvEJHm8mv3bWByjR5BBryoZDQcZIp2XyazSmqSAZSLnBILnsK+Uf1W+oZ9zSVkezIiGYoLodBjq5OWBbGHmntJ8Jd5q0x1oJ7g+U369rQzlxTqNiFyTe3EzPFw+VLnDvK0ALaWCH/s9atgXiMPmOHiwsY8B1SPoRofxtsu6bWZvFwVjQLpxeYYR/e+B0h2b+oCfKR8PnifvcaskQuOLelNrDY0EXLkqYosc/ExiKsM41U60zYCWngRp06ZYLJX6Ht6+7mS+zvKclcfyzBfzh0rDYeSYI9xKr6zXpgdcBxu8RbEqnBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iIbjBOLSDLy/FgXR/yVM3y+HntWiLY362dMsqxZVW+I=; b=3SCu0vAuBM6d03Qyv177STGNfgEpIs22HqmEJ8KyD5QdazHlpaDwloqT6cdnvUmE8wD799zV97K+CkN8qGSjRB3UQmtA9Hg/ZppeM0let4j5iLS/51t7XWPwHs0ZBeKubOWsFms2kluEwMiGYSBwZ5OiF5JdE6/EwnOrgTD6p8w9GDiIM2keBrI0ODDxwacKOs6cMqoY5iH3wC65anfyEtEpnb/YyntMFV5v4oPaazx62AGqbWybhAQ+hk/fa/wvAMiqN7UsbDemGXS8inbhGT9NthAjyNR8r66JdM3y7nu9BJdNO2D/6OOkp6JTsaXMl04tALDfGbjjGFyhSyMj2Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8538.eurprd04.prod.outlook.com (2603:10a6:20b:435::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Sun, 16 Oct 2022 06:25:50 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.032; Sun, 16 Oct 2022 06:25:50 +0000 Message-ID: Date: Sun, 16 Oct 2022 08:25:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH 04/10] Support Intel CMPccXADD Content-Language: en-US To: "H.J. Lu" Cc: Haochen Jiang , binutils@sourceware.org References: <20221014091248.4920-1-haochen.jiang@intel.com> <20221014091248.4920-5-haochen.jiang@intel.com> <1d847a52-b1ff-b816-1507-7077724901bb@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0701CA0059.eurprd07.prod.outlook.com (2603:10a6:203:2::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8538:EE_ X-MS-Office365-Filtering-Correlation-Id: e14209e3-cbce-40ee-cefd-08daaf3f4526 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I+x+ff64GnHvOWUUcN07wS0LM0cbR40P/JEmL13Yqb/UBvbJFXmI4q5I5G5FkoMmezd7S8eJAlLLBJ/Eu0b82DXelWBjM0swIOpfIeHjN83b0VIKmc1Txt3vNMOvuDjoM5yuMzCChsVITa/06kkbLjkHLLhr57qJ8RS7HLBkvlOgyUwNkTr30RvPTAYN2ERjNOmLrSGfKzwTX7k9elGAOZ3GOVYUjsNo1ulo/HyU8zALbdGQvBaHyx/SqAQD60Vo+UBLtvgpTL+YqPpwRqJY3bOLYzh5sbOA0OMhtxCiwBaQES4g6z85VehVZGRIzSXDZRaXPjuzPwDmahv+WAjeqgjzk5crsGNSzcQhidVPac/l9pgZnNx5syp7D/6pbgLmjX3UrJHdFCT1BuMi3dnAgd8tFqd+2U3NYVIvq+ICuzYA6eBA6zj0LRpXOeswXBnYMMieZzu57fzIz5wHTqnh1OsfCO+TojhRvhtma2T68kQ5OlXjnCKZ+RNuriWXIXeUPZxjFXkG7TOEt6A61B0+ee6JXY0s2JDejhxeI4bOyMTC+DL/k+RNdX1vES1fHCuyJbFn0LR3HO/NGWp9CrysggycMvOF5K4/Ep5Bz5ixao2bSQJOxwVy6FmkGgoSq644lalo3k5tYLN2NmzFq0CUMjxqCcPiNNu3uWt3DYo6eysk1ngRK4b/k8aX0ihivLjdA4RN2W0E0XXXnskyWKh4yaLrzhAWVn0XRkxJsZhAbaUSBGsPkmi3iHavo3Pr7RD0OSqxpCeihpXHZ96UmxLOW582Q73YdfzdN18yQn6Jyk8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(366004)(39850400004)(396003)(346002)(451199015)(6916009)(31686004)(5660300002)(66556008)(66946007)(66476007)(316002)(478600001)(4326008)(6506007)(41300700001)(53546011)(8676002)(6512007)(186003)(6486002)(2906002)(8936002)(2616005)(83380400001)(36756003)(6666004)(38100700002)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WEJSZXBOSXZTZVRoc1o3MEY2LytENmVYd2FNRHVWbnJ2eVhnanJWYlR0WlRj?= =?utf-8?B?N210S0pnU1ZVbmY1NXRPQmxzK0RzVjMzTDN5cVJtSjdLS3hqMWxRRkoycUxH?= =?utf-8?B?K3U5dEFDNEUrMlBHU2x5cnRTMXdJbmkycjRZUkN6MnRPUGNHWGp6V0pVOWhr?= =?utf-8?B?VGtWa2dqOVh0c2pERmpGT3FZOHRhN093cmdQek1idE9PQU04WXBtSmt6UTBm?= =?utf-8?B?clQvdUNuWnVtY3hzYUJyQTN2WmNMR0FnWnB3aU9xeitFV2c4MnpZUmFsc25R?= =?utf-8?B?djdkbWlpZ0ZjUjdKWjFIRnFUYlJ0VnpzV2p2aXRuNWZHU1JaMGxpc1VuNW12?= =?utf-8?B?clloQkdQMEF6QTdBRmwwWHlvUVlDazdKb3dXeitiS3NvcEtqc2daalR4bm1t?= =?utf-8?B?aXpGVVhUL1VjMWlYRXhMbEY1d0lQaGFWS1Ezb2t3bmFFc285MWJUenRHc1VC?= =?utf-8?B?SWN1V2N0eHBELzVteGRHSFlUbmFsb1p6Z2JjWWViN25ieEt5Tnl2Z2pleXVt?= =?utf-8?B?dFhvU0pMenF3NjV4THFyTm5zM3I1ZXhYQWp3VmNFMFcwa0lNMU1nMFJBUWxW?= =?utf-8?B?YUZ3NjRiemc1bmltQ0ZoVTAzbWdoSGR5YmtLeUgvWktvY1R0ME85b0lYOWRL?= =?utf-8?B?b0lQTkFNd011ZWVBa0FZSktNaXFua3dZWllWaWRxRzNHT1JydnNySU16eGt5?= =?utf-8?B?K3RYay9ybjMrOVpsWkFyNVB5OEdsVHFFTEUxTnVGQVpSNjhoRjNzSWZITFBT?= =?utf-8?B?SkdkNzVWb0w5Ly8waDNlVlVvcWVIL1hEaUpBc1o2QmgrZytwWW9NTGw1SjZy?= =?utf-8?B?Mk5aZlVPVEV2bTRzRnRNQWJrUXhKa0NhZllxTkFtQStZaXJESkxxN2pLN3dy?= =?utf-8?B?d0xDNzlMVXlEdExpRnJweHFueVAxa0VxZnNKU0hUbU1wTVRKdjNzbng2czZv?= =?utf-8?B?UFFVd1NNaGlpZm1EQ3dXeGtSUlQ3M29ySUtLRFBqQkJzREE1VXQ3Q1poTTNK?= =?utf-8?B?L3JoUEExNnZSZzdBbDRrUkhOempPbldkZmFpTzdTdG9VLzk0V2FyR0Fybzhh?= =?utf-8?B?OW5uWERlQUpYbTkvL2tQRTBna2tvdFZ6TmQyeWkwcnMvcjZ6ZEErRFdESzRt?= =?utf-8?B?Mkk5SFk4SWhFTTQ3SzFMK0FLZWtLbTFWWVF4SnpnNUNNSjRTdndjdDJmSnIy?= =?utf-8?B?NWtoR0FBd1J6MFBqOHk3enRrWDVFZUs3dHdqcE45YUkrajRPeHhXb2l6RWdh?= =?utf-8?B?T2J2Vm5HWEwwYU80bWl2bkZDRlEyRi9RTFNEYjJzbllicjJUVCtwMFJUeEdh?= =?utf-8?B?eUdvdkV5c2twdDdsV1I4aXVlMVpnWU1kMTJqR1pNNzZtNlVqZXR0VnpsZUpF?= =?utf-8?B?TXFPc0pqK0pvT3ZaVkN1anR5VjIvbWR6WUFsVlR1YWZFSkFQVERpYVZhdm5n?= =?utf-8?B?M1ZKZ0t2S3JkeWdIcHFXc25GS213S1llY2VUMVZ6dlg4R2NGdjJPSFBXWFNu?= =?utf-8?B?bExleHBmOFl1Nk9uc21QOWNoYys1MlJ0UXZ3bHNSeE5PZDVCNWsyb2FNQllG?= =?utf-8?B?eDBaaEZGaHRodkZFdVN2c3RHNFZsQ3d0TlQ2YlBEQTU2cmM3K3dqUHdNUXVW?= =?utf-8?B?aG13RGtWM0NGK3U4ZVhDcU1raGY1UXU4WWp3UmVKZUU3dngzSDEzakMxTUdY?= =?utf-8?B?K3dMVU92SWtTZjE4cjJpR21JMUlwRElxYWZPMHlhZzhtSWtmMzEvVXMzNW1j?= =?utf-8?B?OVJXY25WM1phZGp2N21uSDBUbmM4NUV2RnFIMkVlSEM4UGF3Y09DYmR5R2Ft?= =?utf-8?B?MW1GMk80UWhBNjAxZ1podmVrWW03Rld5TTNJT0JtVFVPNUUreFZ5ZUl0RjN4?= =?utf-8?B?TnpLQzRQbWt4MXhHYmFDUFJpeGdBcVk1WWkzemhUdW1sL0N1eGZicmhyRDJ1?= =?utf-8?B?b3VOL01HdkhzRER1dkpqVHJCNVZUOWhoSW4xaE1Tc054NjJNaDhYaXNpTGJH?= =?utf-8?B?b2dKZzFUcitVZGlNWG9rSFNYL3Bab0FRaGlUT1Z3QWhCaGdvNXViTnBLTFlB?= =?utf-8?B?QmF4ODhJdDZ4RW16blZDRnZjNDNIRnhSQ0t2Um9jOHNPZzArM3lRajRiZjVy?= =?utf-8?B?ZkJmcVN5UHUxazBQaWN5RG54eldLL3BCV3JiZ0pzVjF3UVJPbVVISWkzN0ZM?= =?utf-8?Q?kZC9hi6CHTj/lz+eLoO+hy4vFD2AZMsw/T9b0X0QNrj6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e14209e3-cbce-40ee-cefd-08daaf3f4526 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2022 06:25:50.8536 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JpcmlUsVrgdznHzoNwAWFp22qaa+ttHMuRk1zap4KCcN3dDqO/1LB6KwjkJRj+TJ+5oV5g5qsp5PT5RhP7d8Tw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8538 X-Spam-Status: No, score=-3029.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 14.10.2022 20:27, H.J. Lu wrote: > On Fri, Oct 14, 2022 at 6:46 AM Jan Beulich wrote: >> On 14.10.2022 11:12, Haochen Jiang wrote: >>> --- a/opcodes/i386-opc.tbl >>> +++ b/opcodes/i386-opc.tbl >>> @@ -3296,3 +3296,24 @@ vpdpbsud, 0xf350, None, CpuAVX_VNNI_INT8, Modrm|Vex|Space0F38|VexVVVV|VexW0|Chec >>> vpdpbsuds, 0xf351, None, CpuAVX_VNNI_INT8, Modrm|Vex|Space0F38|VexVVVV|VexW0|CheckRegSize|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, { RegXMM|RegYMM|Unspecified|BaseIndex, RegXMM|RegYMM, RegXMM|RegYMM } >>> >>> // AVX_VNNI_INT8 instructions end. >>> + >>> +// CMPCCXADD instructions. >>> + >>> +cmpbexadd, 0x66e6, None, CpuCMPCCXADD|Cpu64, Modrm|Vex128|Space0F38|VexVVVV=1|SwapSources|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, { Reg32|Reg64, Reg32|Reg64, Dword|Qword|Unspecified|BaseIndex } >> >> Along the lines of the earlier comment - you want to use the >> template here, eliminating the need for 16 almost identical lines _and_ >> supplying all condition code representation in one go. >> >> Apart from that you forgot CheckRegSize here afaict. And please again >> VexVVVV alone, without =1. Also for non-vector insns perhaps better plain >> Vex instead of Vex128. Further these insns should allow for l and q >> suffixes in AT&T mode. > > l and q suffixes here are totally unnecessary. For new instructions, > suffixes should be required only if needed. I disagree, and I'd like to ask that decisions like this not be made behind closed doors at Intel. As said many times - there needs to be consistency, which is a prereq for predictability. A programmer shall not be required to read gas sources to know for which insns suffixes are permitted and for which they aren't. Plus do you realize that "new insns" also covers RAO-INT, where suffixes are permitted (as expected)? Jan