From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 14D1E38AAB8B for ; Thu, 8 Dec 2022 18:38:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 14D1E38AAB8B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2B8HhjeQ010472; Thu, 8 Dec 2022 18:38:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : from : to : cc : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=oBEhxIkxTKG7FqTUpm9BPNy10fdoWfGXzHFwzOvMooo=; b=ORT4HnkGWPydoaGAvDEQ764SH0G2C++TbhXkGwSw9P4tFOIY5WUI9ZKplGimukRbmffM E5IsvvN23o076atwEObWWir10/agQpVWia8OiuRXIuaD26z8fZ9m60X9oFEc9PbiZdHU b1dh4zW2KZy8zaZjqzWPyaDrK1oZDnr1lnF6dY+8mC8XGvXgwnuzXag/v1c3ajvnEePn krQY5V305SX7sw1q9LWluFLkcwiE6a8uves4lAJMrPTjZ5+u+XhukhEczH4yOoGKv6l1 U6756OJ37pMSehnX43a+Td6BFadNs7OORVYiLxDZIgetnw50nl9Hz77JWS2CO6XRN+t8 Ug== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3maubakkvu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 08 Dec 2022 18:38:48 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2B8ISvqf025415; Thu, 8 Dec 2022 18:38:47 GMT Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam02lp2045.outbound.protection.outlook.com [104.47.56.45]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3maa7yyaag-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 08 Dec 2022 18:38:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c38HSHt+4xc0PDZvaGJ1bYv4axwGEDBRo36V0fa2Gm3fkunqX+elF4WvANAKU9NLXmH94wR8AA+KIrom6qdS/7ZNR/kFfba+OYllSc8noT+dLWzyCgq2p2fKdbXXvPK51OGQvKXkkQpgEBRq7ADGVmdoE/Y3AUPI7eQD8C0+QCLtOz2Ef4ASjNefvlNSXkdE6xv3uXWk0qXcuirUZajzAJEoqFP+BL8l3M0j9YuEzj2N9dqQlW4vtDvItr+I4kCFsshnHaQdL2ydHeZEhWCAZLii/v9Dy9UKhM+OdPZGAI7FPCf3sdIiGecGlmySG6S3B3cGGzrxmGsfeDs2alSLYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oBEhxIkxTKG7FqTUpm9BPNy10fdoWfGXzHFwzOvMooo=; b=m1SQZJU6JjdQww8sXsKx7dgKpkCZYvXeXRGidO5jLT3gqCfl49nl5c2kvRD30ocLZUGerBBJmZkm9Jd4dG+TnqgobbZQCrUQFSjZLr5vliWguc7FhREcCScJxzsooMys0BSS8nq6sz75dlHQja8Zp0rREpzihN3S6J0hbUtrtkOLbS8Rv+Oue18b+87o8ZK9Q4okr8/8EZtVNqntPJt42Hadt9vdvzHEpShwBj5ee/3s12Zgw8BMIH73EwArIst0LZQBdKGZBFyBGYfDeYMXfdKsZLK+p6Nx35pGikpqdyl9QR2V/J36FHGrKsBb/A+oOGbeCT4E5KibqC2blfjNZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oBEhxIkxTKG7FqTUpm9BPNy10fdoWfGXzHFwzOvMooo=; b=C8LdODBK13F1cJyeSFslDqd7FjRKC3dmD+pE0q2dOqAQJoWxZVBKKVzSVfoOL5sNUB+9IXmOx7EGnrlpInF4ABVHB+qU/qBMfwXTSe5+EKBC5+PkDO3MC5GtvfyASdXguf6qGQ47VCHa0iQUzynUqXOlM/l3rhebd1mqtKX1rWQ= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by CH0PR10MB5388.namprd10.prod.outlook.com (2603:10b6:610:ca::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Thu, 8 Dec 2022 18:38:45 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::ee70:1952:4416:1bdc]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::ee70:1952:4416:1bdc%5]) with mapi id 15.20.5880.014; Thu, 8 Dec 2022 18:38:44 +0000 Message-ID: Date: Thu, 8 Dec 2022 10:38:40 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH 3/6] sframe: gas: libsframe: define constants and remove magic numbers Content-Language: en-US From: Indu Bhagat To: Nick Clifton , binutils@sourceware.org Cc: weimin.pan@oracle.com References: <20221207195222.1182788-1-indu.bhagat@oracle.com> <20221207195222.1182788-4-indu.bhagat@oracle.com> <3f2c38f1-e08c-1584-2e4c-77b4eb50351d@redhat.com> <20345278-1db0-d176-d51f-59723a757225@oracle.com> In-Reply-To: <20345278-1db0-d176-d51f-59723a757225@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MWH0EPF00056D0E.namprd21.prod.outlook.com (2603:10b6:30f:fff2:0:1:0:12) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|CH0PR10MB5388:EE_ X-MS-Office365-Filtering-Correlation-Id: de20c3bd-cf1f-4177-1fba-08dad94b6fa9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YWQympi9/nh9YK4JKEUPx4X1XPFGY0JBGJXRrbK+TxsjBT6H4ZUy82OTe/PY3j30+fL8jmg+zhY8o1kiAB6yGh69BV4OS8tjPgFL++6GzsNnnDU7CKes1ifVdw5tfpHzgsRQVqc/glvOhHZofziu+GkKrGKnXe75c7YBcz6yEfDY9bW4TdzTV/FQqXLMcAqaNauVHID27TI/qeKaF51JEuUIV5kjqUD0DG7lguj45IX18y5PREEzJ8yMsYXiqCHnoJDo8r4GEmIZJ99N3O6bA1MqrKwyIS7VME77OU5J7pwmGhbpDHpO7UYuRHVwIwPwnP8okUwtGp9iyjIBumhYBFG3EsnK6IltSxj8j1I3ZmBzb+D9PDMd2boWpOe43OiCUNRFUf9Zw8Qd6oCwIKiwUzeY3zHZrDNsnMOrkN28eGYVxBLEh4Xn5A2Q/ZvT8fHv2gCSBZDiCS/1xjTM0azIx0TplY3/nE+ANKU7D8BGIMBFDworA74crbvi1uG1sv/vbtSoVM2mxex2/npq5TZYYhtnK0TM4KyWkMCUSbzpcO5Nc30MJ6xlGEbGdWiOaT9BpqjBbvNt5cKdnoguv+ROY//6KHHs60VcWL6D+IZPsvjscHo3Qf0hrVouXe5AsaeJdElxzFfHI6pk/mrxeOAhykJU2hoxztxwY4FvaMxJDO9AB9JVGvaFsg2TLhT3DPluOFelkV/tY4TI0WHz84oKfYkytcXSviQa2/LLLDTC/fQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(396003)(136003)(39860400002)(346002)(451199015)(36756003)(31696002)(6486002)(86362001)(8676002)(66476007)(44832011)(186003)(2906002)(107886003)(5660300002)(4326008)(6506007)(316002)(8936002)(66556008)(41300700001)(66946007)(6666004)(478600001)(2616005)(53546011)(6512007)(83380400001)(31686004)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cUt3TnlaYVVYV1JOSTFEN0VvRDlQWVh0SlhZY2RZempvaEZOd1hJMVl0eFJH?= =?utf-8?B?bFVUTTRwZHQ2SnJQdG9veHhUSjFOTlZUNXlkTjM3UURscy9SdVZuaTNuVERW?= =?utf-8?B?VHRRVG5PN3dlUEJwRjNMUmZra2kvTUxrN21BZy9TRjZMWDdzL05jelNjUXJN?= =?utf-8?B?Rm13RGJtOWdrUzhmRm9SSm1SMzhwMHovTzExbGpzRTBTbDhZRXlGRG9HUXlq?= =?utf-8?B?bTRqYUtBMWdoT2dVeHRXRU80T3g0V21QVmp6dkh6ZEZGM0FBSlBsQUVOVTZr?= =?utf-8?B?bmRoT0dHY210VHZVaGdvVmtLcTJRa3JkOXlLckI5cVliVFNDSGNNWlR3dm00?= =?utf-8?B?STB5VG1KQ2huNUs2TWdTWjJpZzNlNXN3Y3VzQ2ZDaGZBQ3luVTBJaVB2TWNv?= =?utf-8?B?a2xtSlpSTldCSGdsREFWeThTYW9lNklYNnpabThnaVY5cTZKbS9HamhKRitz?= =?utf-8?B?QzgxeDg4czF3Y1FBZVRCR096aUVXVy9rZVpVWE1XMy9QR000bVBVNTJRZWtv?= =?utf-8?B?bmZGMGxWTWVqcjBDbWkxMWhRSVZlQ3ZQVVpYenpjUUpmelh1U2h5Znp3R3R5?= =?utf-8?B?Y0E5YXhIL3pUcmtWalBrYTRYQ25rVUp2UmlVTldZMDQrcmNhenVBVjF6R0Vy?= =?utf-8?B?UGFGRTBmK0pjd08vMURlZ2hHRENxYWJlMTJ1YVNGZHFYNGVFMjFpbEtoSVAw?= =?utf-8?B?dXpsTUJTTEJHRDdIbG5vRDFaSGZ3TUJPQm5ZTjRBNU11clBEZUVZaGFlYWFU?= =?utf-8?B?MldHWVdlVlpYbnJZeTZtTm9YcEhDTFFMUDFmS1hLS2owbEFsdEZWLzVHNmRT?= =?utf-8?B?SDFvZTJnTjN2MTE5WUFueU82eE1yTllBNFlXZWNxYXYzY0t4RXR1RitWK0hT?= =?utf-8?B?dHNBckV0WmV1K0tpd0kxNGRBRG8xNGR3Ny91clBHTEw4UHR1OEp3NklJTmxo?= =?utf-8?B?MzJaZEs3eDNzdmhyYXlaOUsyMWdzMjUwN1Rab0ZrODE2QU5HTWxoclE4cGpU?= =?utf-8?B?V1lJQUIrMC9OanNFUDhvdXlIaUNXVVYyalFqZlRyQkN6dWJRbS8zN01wL0tH?= =?utf-8?B?MWl3bnZ0Vmxnb290cHdsMk94RGZsVU5KSERSWGlvZTdVNFA4eldDZjlXdURS?= =?utf-8?B?c2VhZjN3UnRWckxnVjNXYW1TWUdybEFKQ1lNTTNEbDNkUDAxamZBKzJNYklN?= =?utf-8?B?Rm9HdGhqeis5WURxTlZtcFBacVNxZmpXa1dPNVZmMTRrUGIxQTJIRzZocTFE?= =?utf-8?B?YUF2Z2VSNEtUQllyYU95UU9TZXRFUDRENllyUHFaUlRVNG0zSkVJMy9wQ3I1?= =?utf-8?B?Q3VSNE40T1R4RUp3QTVuRzVZYlMwVHZQdjdSenRWdFhIK3ZMaUNUcVUvcEVY?= =?utf-8?B?MVROQmJIQlFKc00xTldOVlhXSGxYbEFtZVgycGJuRFhFTFI4dzNxKzBYclow?= =?utf-8?B?TmQ2UVk2ZDlLcmVnNmNvWm0zUTdyaE5PaGNXWUxtUjNDdmN0dURmZWNKTHR0?= =?utf-8?B?OFJqWmJQSmxwNmlWa0lCN29LK0NYWjJKYzc5c3Zsb2s1by95TUNrZ3c0M1Y4?= =?utf-8?B?cEhWajJsenZVaTg0MDdGeGlER0tzQ0Z3S0ZtYk5DWVhVbVlzYW9MY3dXenor?= =?utf-8?B?SDNSUExtSkhiOE1oZXJGNmVTZDVab3ZLZEQ4WXBja2lWV1FCVHE1a09lOFRk?= =?utf-8?B?Wm5sajJQSGR0U0NIVUcxSXdqaG1sUWpuU0x3cXB0aUZQNnZJU3BtNFZ1Yks4?= =?utf-8?B?MDhDOFIxYUloZmNTeHZwK0dNUEUrZmdrNnRabTh2U3RDZ1ZiOHl1N2VGeEx1?= =?utf-8?B?ZTYzR3Jsb2dYdHo0d3N5NzQxSDRuMUFuUVNhckdmcnhQVkxEeXVWZGNoY2ZZ?= =?utf-8?B?K3lUemFQSGlWVDNTNVgvbWljSlhDYTZrZ2JIT1ZtUnJkVmR0NjloVTc2a1dy?= =?utf-8?B?eHl2QmF3ZDJzWmNrS294aU1vbTFyYlNlVC9rMkNsaWtxYnRlK3dra25lNC9i?= =?utf-8?B?MGEzZVJUeFBMUTJwZjV5ME5WNFdmVERweXMxRys2cmJKcUl4U0lRUE5hVWdp?= =?utf-8?B?TlhrSVFKQUJCYjdNdlVrbWVDWU0zT1lscnEyVm5Rd1FLYmNrRkNhTFVZOURl?= =?utf-8?B?S24wQ01zTXVpZjk3MzhUNjRmRkUyRFg0cjBzOCtJTUVUZTdZZDJYdnZlUWE4?= =?utf-8?B?MVE9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: de20c3bd-cf1f-4177-1fba-08dad94b6fa9 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2022 18:38:44.7506 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xdogxgZYrcspr5R0OQ2vObXJR7PY5vdU/tblNl46GKJ2qpN6zML3iKcGU6rRJpAGDFFjTZc1ulRODUNvDRnWWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5388 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-08_11,2022-12-08_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212080158 X-Proofpoint-GUID: cPse3x7Izw7lzel8CxrqVTNHDJcEzI0Y X-Proofpoint-ORIG-GUID: cPse3x7Izw7lzel8CxrqVTNHDJcEzI0Y X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/8/22 09:43, Indu Bhagat wrote: > On 12/8/22 03:10, Nick Clifton wrote: >> Hi Indu, >> >>> +#define SFRAME_FRE_TYPE_ADDR1_LIMIT  ((SFRAME_FRE_TYPE_ADDR1+1)*8) >> >> For readabilities sake, I would recommend adding whitespace around >> arithmetic >> operations.  For example in the define above a quick glance would >> suggest that >> the definition is for a symbol called ...ADDR11 rather than ...ADDR1 + 1. >> So: >> >> #define SFRAME_FRE_TYPE_ADDR1_LIMIT  ((SFRAME_FRE_TYPE_ADDR1 + 1) * 8) >> >> Is better IMHO. >> > > Yes, I agree. I will fix it. > >>> +#define SFRAME_FRE_TYPE_ADDR2_LIMIT  ((SFRAME_FRE_TYPE_ADDR2*2)*8) >>> +#define SFRAME_FRE_TYPE_ADDR4_LIMIT  ((SFRAME_FRE_TYPE_ADDR4*2)*8) >> >> The same goes for these two definitions as well. >> >> Patch approved with these changes. >> >> Cheers >>    Nick >> >> PS.  Just checking, since I am not actually familiar with the sframe >> format:  Is it correct that SFRAME_FRE_TYPE_ADDR1_LIMIT is defined >> as "(...ADDR1 + 1) * 8" rather than "(...ADDR1 * 2) * 8)" ?  It is >> just that the other two limits are defined using the second formula >> and it seems slightly odd that it is not used for the first. >> > > Yes, it does appear unpleasing to the eye. But it is the way it is > because the constants are defined as following: > > #define SFRAME_FRE_TYPE_ADDR1   0 > #define SFRAME_FRE_TYPE_ADDR2   1 > #define SFRAME_FRE_TYPE_ADDR4   2 > > All this scrambling because keeping 3-bits was deemed sufficient to > encode 3 different values (size of 1 byte, 2 byte and 4 bytes > respectively), and the rest of the bits were provisioned for other > information. [ And I Misspoke :) Sorry, I mixed up the fre_type with the stack offsets type. The latter has 2-bits reserved to encode 3 possible values (1 byte/2 byte/4 bytes); See "size of offsets" in fre_info. ] Correction - There are 4-bits reserved for encoding the FRE types. At the moment there are 3 types of SFrame FREs being used (leaving space for the format to add other FRE types if needed). So the constants SFRAME_FRE_TYPE_ADDR1, SFRAME_FRE_TYPE_ADDR2, and SFRAME_FRE_TYPE_ADDR3 are defined to use up the available space serially. Hence the weirdness in the *_LIMIT formulae.