From: Indu Bhagat <indu.bhagat@oracle.com>
To: "H.J. Lu" <hjl.tools@gmail.com>, binutils@sourceware.org
Subject: Re: [PATCH] gas: Fix a CFI label name memory leak in scfi.c
Date: Wed, 10 Apr 2024 19:09:59 -0700 [thread overview]
Message-ID: <febce986-b3e4-41b1-9c08-42fcc82e11b2@oracle.com> (raw)
In-Reply-To: <20240409230416.2466475-1-hjl.tools@gmail.com>
On 4/9/24 16:04, H.J. Lu wrote:
> CFI label name can be freed only after use.
>
> * scfi.c (handle_scfi_dot_cfi): Free CFI label name after use.
> * scfidw2gen.c (scfi_process_cfi_label): Add a comment. Remove
> TODO on freeing CFI label name.
Thanks for the patch.
> ---
> gas/scfi.c | 1 +
> gas/scfidw2gen.c | 4 ++--
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/gas/scfi.c b/gas/scfi.c
> index 37cc85cfed7..f34150cb08a 100644
> --- a/gas/scfi.c
> +++ b/gas/scfi.c
> @@ -1137,6 +1137,7 @@ handle_scfi_dot_cfi (ginsnS *ginsn)
> break;
> case CFI_label:
> scfi_dot_cfi (CFI_label, 0, 0, 0, op->op_data->name, ginsn->sym);
> + free ((char *) op->op_data->name);
> break;
> case CFI_signal_frame:
> scfi_dot_cfi (CFI_signal_frame, 0, 0, 0, NULL, ginsn->sym);
> diff --git a/gas/scfidw2gen.c b/gas/scfidw2gen.c
> index ebf2d24dab2..2b018fac8bd 100644
> --- a/gas/scfidw2gen.c
> +++ b/gas/scfidw2gen.c
> @@ -57,8 +57,8 @@ scfi_process_cfi_label (void)
> frch_ginsn_data_append (ginsn);
>
> scfi_op_add_cfi_label (ginsn, name);
> - /* TODO. */
> - // free (name);
> + /* NB: Can't free NAME here since it will be used later. Free it in
> + handle_scfi_dot_cfi after it is unused. */
>
> demand_empty_rest_of_line ();
> }
prev parent reply other threads:[~2024-04-11 2:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 23:04 H.J. Lu
2024-04-11 2:09 ` Indu Bhagat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=febce986-b3e4-41b1-9c08-42fcc82e11b2@oracle.com \
--to=indu.bhagat@oracle.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).