From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2067.outbound.protection.outlook.com [40.107.21.67]) by sourceware.org (Postfix) with ESMTPS id 1A1633858008 for ; Mon, 20 Nov 2023 16:33:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1A1633858008 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1A1633858008 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.21.67 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700498015; cv=pass; b=a3YrceWRfihszl2niIx3HOvbr6T39ietCbHN1SyDaCS4gff+NqXZz+hhz/KbNstpLL84+sKQkXdmdqFzFdlDR7mlqHGCqdGltpmLDaQLa6m0mA/EovarVgquKBBIoYxOCfmT3BxxUh7P9WlrbVC/R5w0tM2qd6OqzoVMuaQ1AEo= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700498015; c=relaxed/simple; bh=39pf4cmawtCclskaYU1nc1ff9NfAjIGz9R5A+wV9IV8=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=YnsnF5GnPG8Unm3t5MB0p7Wc/Pwwl9bMmA9ey9941NRTAs/jiQSJ/rBbJLCm7YIKpv9o01cbzCJLDhDEwZ4n2xM66g18YEJCvSJiH9B9tz2PEm72oOwr5C9c4AN4YkS3EzoomsGjEoOHLqkrOay4mfaJl20eBMRAoHxYu+ekJOA= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y+EdHFGXj2h6ycjpfdesvoHcECpHx6M0PbsdBlV9dMdo+GwfxIJG1dHvS3QxLytSmc0dTzAireIg6PeJZXO9snIxp7aYGon+RJWArPVH2bECP72I7aU8vImS2pMLC/KW98yx+DoE98iubKu90CZX2DjAUvMQ5UHi3W7bCboxAO/fTjqLxuVwz/wcI0tBuoY8kZvHeR6hdGEcIsOQBoThMY+ElPBUyrbupJnHRS+1BNsfu/ZEXlSMXcmnMYWwKfWRZNHP/QG3X0ONRE40YWLb2CQlWjGZjgunlo2RdkpQ6Nij92idYPVQdzNxllgRKtvGkmPUQQjucWJqdUfAQcKGRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1fdT152Lux8o84LzFdDtFXJ55Zgxr1jinz+MKCpGai8=; b=iYc8dwHptzH/k2UJmsQdQtdXOr9O8yhGiVnixOMpvbCbjkTL1mYz2FW34ypo6hjDmZH6tsUcH6nuLp133xb0SNa1Ehsb4j+EbmgmccWayT9//93qgAT0Re632h1cQmho4l8Xoh/HphZ9n7yPRGkKugyocVtSwBKewy/auDOTF5S90fBxTPYuLFGHjU7XNMFVSoHkQyv6LdbI8s8ajfd9B9ZyyAd7dRJMOxSxNkQ1C/GTUx4zuUHFAwf8NheYjwQo+D7zfpJ4n4yeH8Srgt2JTPcJjwIoE2XdUraJJHY4lhw4akHcXDKf6NyNTBIWUhYgMQhIwTyV3gLW4noAhk8r3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1fdT152Lux8o84LzFdDtFXJ55Zgxr1jinz+MKCpGai8=; b=L7u8sL4VIW7ye6C5x0/A3ikMmspDcGgjnhGCX2wCa6KGcrGtK7DC4kifmIaqQYoW0H2gDyKlELAuhlE27tjLT5z5Qd0IKxxomKn4bPNVT0D9G68yIlXIQfyGauiogeZ9UJuZ/fQJTjM3MqOiK3MnMHGj6fO2zVQbFuQSfL/1cMPfWoSyHXmvARTl9+TGdQOsiNpOg6qad4HUkIOwFUXWjHoGk83kCwwy0Y6jbm78khs+YCTay1nC9fE7UvbbrkzIwf0ygZh6brayfBio8Z5fZZTui1EGa6rTzNXFWMQtX3juMyXY1Ee3xJoU2VfNQRRhEAU1BuZALLDl0pPmmcLZ0Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB8913.eurprd04.prod.outlook.com (2603:10a6:20b:42c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.16; Mon, 20 Nov 2023 16:33:30 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.7025.015; Mon, 20 Nov 2023 16:33:30 +0000 Message-ID: Date: Mon, 20 Nov 2023 17:33:28 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/8] Support APX NDD Content-Language: en-US To: "Cui, Lili" Cc: "Lu, Hongjiu" , "ccoutant@gmail.com" , "binutils@sourceware.org" , "Kong, Lingling" References: <20231102112911.2372810-1-lili.cui@intel.com> <20231102112911.2372810-6-lili.cui@intel.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0232.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b2::16) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB8913:EE_ X-MS-Office365-Filtering-Correlation-Id: 33f639d5-48af-4ac6-3fc7-08dbe9e66e16 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 78Itm6tBEnwbXbYRP26mwtZodDnCM0DJludPbFG0q2LVL2S1v1/KuYaSIwezoSZhm6hzRFm7GemOPRq60NkN9eaGC3+DbOx4Ah4IJssxEzeJtPGcrH9DNCwUx5f6vQ2cwQ2w5YT4G4nGY4fNonumv7KRcNAkQ9dC8SDD6uzn4az/DjOkvKtm9T/zE5LU48j1O7SRmL0V582/fSY1xpdFA9AVEuxhj76Cc7WTXaV18R11GwHuZUH6sW3thiL9z1VeGiXECosMgvMLCYTVZ9q4TqMEBCQunFAg5Qs7F8TsdvWPTIFJ1MUs4H6LwXQUAKkZmzJo7dqZRR07wf3A3ltEzCJI22ktGsT7RGhRywX/KjjJX8N/si8M+KiWjmkaXQxGdlgpRcW4gPa/9UqLvjMJYKKgtaAcIpUV+s07a5dxLb20bH8fDMEHKnyWP/8SJjXSbNaT/tMujxGEj2xTlzu7byT+qVk0aeg6VU1wDLdlbSigTdv/1UHhywUK8B49vV2GgUuqWIx9F21+SuVewMJAX+fq+y/UfByr3l5PrPgLEVKfCVCkNCZC2P0oF5gqJXlf+J8+UYBuaynMk61ORDreUmiyOoarJQsEf1v2JurP5Gl/hsRI0NfPVAWm1wVeDsjwSJ+ozpoXqq0t1tpLrrnwzA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(376002)(136003)(346002)(366004)(396003)(230922051799003)(64100799003)(186009)(1800799012)(451199024)(6486002)(478600001)(53546011)(6506007)(8936002)(31686004)(54906003)(66476007)(6916009)(66556008)(316002)(66946007)(6512007)(2616005)(26005)(4326008)(8676002)(38100700002)(5660300002)(31696002)(2906002)(86362001)(41300700001)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?czVhU25UYmZIaUo5eWoxemZZV0xKWnVZTkVVbThiZ0lNWktHbmNwdWExNXB2?= =?utf-8?B?QytJUmxoa1lvNEZqWkpVUmFQWGF4VDZubDV0RmZ0VXBmdTZudUZpYVQ5OVAw?= =?utf-8?B?SDliRlFYalVjZGNCWnY3N3pSUWFkYWN0QmwzQUpidkdacGpabnY5RWV3dW5W?= =?utf-8?B?ZEp4NUs5cnFvREFpY2dyMkx0ckZWRXExbTJNMnJXdlN3ZCtWd3A0MFFxZzZ4?= =?utf-8?B?RUZFVFVMcFI3Zmt3T1dLRUEzMit4SnA0a1NkNlNxU1pTVm5JaWUzYnZSekVl?= =?utf-8?B?cUVhVFdVaHJ5eTVRWU41ZXQyS3lzWEUxbWFSdlBITmZWdzNBRjVPQUI1aUhi?= =?utf-8?B?MW1zczB3S1dYd3QrNVJsRUo2R1lZdG44T2tycG96WmZTa05RTElaN21iYXlH?= =?utf-8?B?Yi95NmlLQXp6U2F2Z3RIUHRLL2JHeXdmSjVQNkorZm1md2FhaCtGcXZ5VHZB?= =?utf-8?B?UitnUW9YUXg0aTJha0xVeEVaWnpnQll4ZFZxazl3L3FTbUdRRzZhSDFqYmVW?= =?utf-8?B?N0YzcnZyRjZpbWJVbDhqcnhqeXpONzZDRG11NWhNYnIyMURnbDFzRzVmamYx?= =?utf-8?B?STEzaFRVa3NNRmJ6NU9jaGRtb2JKUFRlTmRsbmdicmtnN1VkVTlyNEo0V2ZD?= =?utf-8?B?YUpYUUM5UXorc2hicnFmYTIrcDdVTDlUSFl4RE5oRkR0a202ZlU5L0txSWFx?= =?utf-8?B?c2lHbDdIelovT0s2aXVUSk5OdjdTU2h0cm16K1Jkd3RRZXJGYy95TFF2R09U?= =?utf-8?B?ejdGVkJtS1NEZHRJSjV4SmZEbUo4bzJMSHBaT1BUVzV3c0RORXdnSDJ3K3JG?= =?utf-8?B?SGhieGhqRXovRzJQQ3dDVnBCL040WVhPdzRnTmw5TVMzMFJGOUU5M0lhbDN1?= =?utf-8?B?NHFCallySjdpUGtmNTJMTmx1Z055c0xMem1BbCtWTjNTQTlrMS9tcnNLV05Y?= =?utf-8?B?ZjRQZXdteDBSVHIxdWttQlR3NHNQc1hwNmRDQTJTZ2tBY2tiTjRUUGtHektZ?= =?utf-8?B?b2tMUWgzSGpEeGY4MUh5TEY3WXZISEQyT2gxcGhWNURGeFlxRVNDWitrV0xR?= =?utf-8?B?UzIzRnlYc0k4K3Y5NjNqUGFzRmFjTy9xc3Ixa0M2UXR3ZTBPL1k5V1N2VVh6?= =?utf-8?B?MmtMMmpvczZJc20wSklHUFo0SDMwVTJQKzBkM0l0TnJMWVlsTkNZS1BiSkw0?= =?utf-8?B?bmVIRUVTbURPc3hMdjIwVS9rS0NRN2x1Wmo2bXNwZU9zZFhienUvbjNWRWhu?= =?utf-8?B?Yk0yY1pNOHlzcFliZTVjSHRMWTF0RkdOOGFhbHFlQlA3TjJWNDJPNWdrcjdw?= =?utf-8?B?UC9oWkwzRjZOamR6VHZLckNkbzZ4d0EyWFR2ZXVTbDIwRDJBS3p1azRCbk1R?= =?utf-8?B?cVYzdVBrSlozRU1nLzV0bzFEd2J4K3BlYXRxUTQzVU9aNGxLdTFQeWpIMk1L?= =?utf-8?B?MmRmK3FlSnoyckFhU3BMTFVOVjM1N2NrNTNiOFV6ODEyQU0wb3BHdUhjL3dv?= =?utf-8?B?L1phUDdkQWF0Qjh1Rm5kSmd2bnNkMytQQ1l4SkEzRERNays0eGN1cytBMExG?= =?utf-8?B?dnZtZXk5L0hBOXlEaEQwa1dxYmM2dmw5NGRRSVBIMWc5bi90RW1qQnJLby9m?= =?utf-8?B?aTUzZG9yWVpuamg3Nms5ejVNb3VpRXI3Y0VFUTFtbzlkbHYvTDJRTHlUZkd3?= =?utf-8?B?MVo4UUt6M2ZCUkhzYnlnNHdwWlA1b0dZclpjZkNCY3ZYcDk2VjZYRDJuamlv?= =?utf-8?B?c2JxajZGOEM4cVVlS2NDOVBaRXNPVXdmSERCNFlHMVRiOFg2d3NzL1U4NWYx?= =?utf-8?B?OCtyYUJhVTdFVEFFakpVR2x6Q3lJa3ZsNys5djI5NGQzOTRvajdZeGZZQlow?= =?utf-8?B?ZmZsK2ZvTkc5OGp5KzJBYmxVOSsvMjNaVk51S1VrdnJTb00xT0NLc0poV2xS?= =?utf-8?B?Yi9ndHM0NUZFSUlMc3JwZ3U1NXV0RGZuMWgxVGhTVXdCR0RFVDl2UjcrOTlt?= =?utf-8?B?eUpURTV5ZlBHa0h4UUUwTll4ZTBLZzl6cG9iaXV6SnJCUGxkQXNqRmhDbHBt?= =?utf-8?B?dmUzS3Y5MGNwSEpNYXlZWW1UbEIrUEdNZ2ZHUFdtWGJPc0tsQ2EySUVmTzI0?= =?utf-8?Q?KmQ5GniNeZpudcUOMYuxaI9gw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33f639d5-48af-4ac6-3fc7-08dbe9e66e16 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2023 16:33:30.4539 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /NYwL8/LScwhQEZlqKHK/kSD35WrMrmE2JPNadrsW+G8D13Lq2PzKekwYt0e4arxM0cp0Qu3phFnE81+CWv0aQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8913 X-Spam-Status: No, score=-3026.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20.11.2023 13:36, Cui, Lili wrote: >> On 02.11.2023 12:29, Cui, Lili wrote: >>> --- a/opcodes/i386-dis-evex.h >>> +++ b/opcodes/i386-dis-evex.h >>> [...] >>> @@ -947,23 +947,23 @@ static const struct dis386 evex_table[][256] = { >>> { Bad_Opcode }, >>> { Bad_Opcode }, >>> /* 40 */ >>> - { Bad_Opcode }, >>> - { Bad_Opcode }, >>> - { Bad_Opcode }, >>> - { Bad_Opcode }, >>> - { Bad_Opcode }, >>> - { Bad_Opcode }, >>> - { Bad_Opcode }, >>> - { Bad_Opcode }, >>> + { "cmovoS", { VexGv, Gv, Ev }, 0 }, >>> + { "cmovnoS", { VexGv, Gv, Ev }, 0 }, >>> + { "cmovbS", { VexGv, Gv, Ev }, 0 }, >>> + { "cmovaeS", { VexGv, Gv, Ev }, 0 }, >>> + { "cmoveS", { VexGv, Gv, Ev }, 0 }, >>> + { "cmovneS", { VexGv, Gv, Ev }, 0 }, >>> + { "cmovbeS", { VexGv, Gv, Ev }, 0 }, >>> + { "cmovaS", { VexGv, Gv, Ev }, 0 }, >>> /* 48 */ >>> - { Bad_Opcode }, >>> - { Bad_Opcode }, >>> - { Bad_Opcode }, >>> - { Bad_Opcode }, >>> - { Bad_Opcode }, >>> - { Bad_Opcode }, >>> - { Bad_Opcode }, >>> - { Bad_Opcode }, >>> + { "cmovsS", { VexGv, Gv, Ev }, 0 }, >>> + { "cmovnsS", { VexGv, Gv, Ev }, 0 }, >>> + { "cmovpS", { VexGv, Gv, Ev }, 0 }, >>> + { "cmovnpS", { VexGv, Gv, Ev }, 0 }, >>> + { "cmovlS", { VexGv, Gv, Ev }, 0 }, >>> + { "cmovgeS", { VexGv, Gv, Ev }, 0 }, >>> + { "cmovleS", { VexGv, Gv, Ev }, 0 }, >>> + { "cmovgS", { VexGv, Gv, Ev }, 0 }, >> >> Considering CFCMOVcc which sits at the same opcode, doing things like this >> sets us up for needing to touch all of these again. Maybe that's the best that >> can be done, but I still wonder whether this couldn't be taken care of right >> away when introducing these entries. > > How about adding a special letter CF% in front of them? Why not. >>> --- a/opcodes/i386-dis.c >>> +++ b/opcodes/i386-dis.c >>> [...] >>> @@ -2660,47 +2668,47 @@ static const struct dis386 reg_table[][8] = { >>> }, >>> /* REG_D0 */ >>> { >>> - { "rolA", { Eb, I1 }, 0 }, >>> - { "rorA", { Eb, I1 }, 0 }, >>> - { "rclA", { Eb, I1 }, 0 }, >>> - { "rcrA", { Eb, I1 }, 0 }, >>> - { "shlA", { Eb, I1 }, 0 }, >>> - { "shrA", { Eb, I1 }, 0 }, >>> - { "shlA", { Eb, I1 }, 0 }, >>> - { "sarA", { Eb, I1 }, 0 }, >>> + { "rolA", { VexGb, Eb, I1 }, 0 }, >>> + { "rorA", { VexGb, Eb, I1 }, 0 }, >>> + { "rclA", { VexGb, Eb, I1 }, 0 }, >>> + { "rcrA", { VexGb, Eb, I1 }, 0 }, >>> + { "shlA", { VexGb, Eb, I1 }, 0 }, >>> + { "shrA", { VexGb, Eb, I1 }, 0 }, >>> + { "shlA", { VexGb, Eb, I1 }, 0 }, >>> + { "sarA", { VexGb, Eb, I1 }, 0 }, >>> }, >>> /* REG_D1 */ >>> { >>> - { "rolQ", { Ev, I1 }, 0 }, >>> - { "rorQ", { Ev, I1 }, 0 }, >>> - { "rclQ", { Ev, I1 }, 0 }, >>> - { "rcrQ", { Ev, I1 }, 0 }, >>> - { "shlQ", { Ev, I1 }, 0 }, >>> - { "shrQ", { Ev, I1 }, 0 }, >>> - { "shlQ", { Ev, I1 }, 0 }, >>> - { "sarQ", { Ev, I1 }, 0 }, >>> + { "rolQ", { VexGv, Ev, I1 }, 0 }, >>> + { "rorQ", { VexGv, Ev, I1 }, 0 }, >>> + { "rclQ", { VexGv, Ev, I1 }, 0 }, >>> + { "rcrQ", { VexGv, Ev, I1 }, 0 }, >>> + { "shlQ", { VexGv, Ev, I1 }, 0 }, >>> + { "shrQ", { VexGv, Ev, I1 }, 0 }, >>> + { "shlQ", { VexGv, Ev, I1 }, 0 }, >>> + { "sarQ", { VexGv, Ev, I1 }, 0 }, >>> }, >> >> As mentioned on the assembler side already, I think we would be better off >> making const_1_mode print $1 in AT&T syntax at least for these new insn >> forms, to eliminate the ambiguity. >> > > It is related to correctness and should be revised. Since they share the same entries, I will created a new patch to modify the legacy instruction and then extend them to NDD. Do you agree? I certainly appreciate any reusing, where it is possible (and it ought to be possible here, yes). >>> @@ -9087,7 +9104,7 @@ get_valid_dis386 (const struct dis386 *dp, >> instr_info *ins) >>> return &err_opcode; >>> >>> /* Set vector length. */ >>> - if (ins->modrm.mod == 3 && ins->vex.b) >>> + if (ins->modrm.mod == 3 && ins->vex.b && ins->evex_type == >>> + evex_default) >>> ins->vex.length = 512; >>> else >>> { >> >> Is this change really needed for anything? > > If it's NDD and ins->vex.b ==1, we need to avoid giving NDD a wrong value. But this is recording ->vex.length, not anything NDD related (afaics). Jan