From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 247FA3849AC9 for ; Wed, 8 May 2024 10:26:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 247FA3849AC9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 247FA3849AC9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715164005; cv=none; b=gdy2C9X74BwbejBrcI+XSinC8tS9cVkBbe4zaRC4G2/klaUAa+PcpTl+IbPjjXhpwDb/vdKRJ4u9cR7uIJEn6dbT35+D7oJCsDg5ZC6C6ughEy88zRWkcbv4eXggX1wLLVacICyLta3lJii/kNUV79yi4Cqp8ujPbtSgV3YpcfA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715164005; c=relaxed/simple; bh=Ib3ITrpxMDlyESF51K/29eZZUyTFNi35v3fXyNJF4TQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=AaWBvoKP0oFko7aIPgEkEeVzrkp7cyG5zsHMRe0DuEoXhdhIxDrlfs8kWm5WhJltUbP+03qQxj89GLRnLGdoVO4znKNihRiW7sTELBdVfIxULH8meZwiXOfl6larcE+e8VHTHf9piQe0+ILhELhDo22GbIqeFlUYmAE/VEilbWM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715164002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3SQvguA8rqcGfnDPmTevOSnwFE3xPLrLwnpnPK21Dyk=; b=jA4H541spvqGFDdFloNLCUGOK99knDG+/lNuPMOqL0MCmMcx/8ptcm89ip16SW/FczCeK3 MVNkHx6Mo/68A2bRq5HHRelM8ZmFU2TIZalNtSKbNhd+5YGS6qFnhUY95+dRxWYjOsjgqz uVJdkTdB+CnSLI+Y/CcFGiW98tjlQBc= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-196-6TKnACmnO9m5vp1XKcepfA-1; Wed, 08 May 2024 06:26:41 -0400 X-MC-Unique: 6TKnACmnO9m5vp1XKcepfA-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6a0ff9833afso12831736d6.0 for ; Wed, 08 May 2024 03:26:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715164001; x=1715768801; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3SQvguA8rqcGfnDPmTevOSnwFE3xPLrLwnpnPK21Dyk=; b=oKp17nUJJ4MV0WD5RaRLVnek/t3p4OrkeQ92cKudYJ9zO4+8cQzEc/sayqxsYp7Pkc 0A+0HCT5DTLyfXp9NENZ8+Bgd2jfsed2hA1nKZde7aRMy1ldRcugTv6a/giQ1RNwRkE/ c5k0wNrSiqryH3twTatr1MYuDYOAdLq/x/jUXw98FhZ7o/s1tvegq5Cc52lLrpIATJp/ qERs7e5WOVzxQf75QiIbBnTY04vnNjL5jZXMsA4SA2F9EnRtcX7pGyTIZ+2NjhTTqJZz lV6dB6iwsGIGuHQHM7YTq0N1tIgVq4M8q+5ibJ513RVAURdZ10KqQhaaYRqprT/oy1Nb /GyQ== X-Gm-Message-State: AOJu0YxyBAdJkmQ5GBXFoBgUuC6VQ8oHc54KtVSho8JOyvBwyxXB0pP3 ga/ey/KRNXusBuukwrStCKRslU/o0PuBIwewtTlHyT/P4npDxNj0VdlZ3tRcfFaXrGJNEp2CcAS 0wULFdGwC8p2PYTKTBTxhOyb5LHW6GWqJg8q9mPQ9q6P2wrUjjwaoNKU= X-Received: by 2002:a0c:e082:0:b0:6a0:f637:667 with SMTP id 6a1803df08f44-6a14600e407mr90012606d6.12.1715164001005; Wed, 08 May 2024 03:26:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEL0nhSI4eJOzzsxdHgaLeQxmGmiEYBTZo/rFNAO2wkcpsGu33LU5+u6yVwDLg5tEjakLz/KQ== X-Received: by 2002:a0c:e082:0:b0:6a0:f637:667 with SMTP id 6a1803df08f44-6a14600e407mr90012386d6.12.1715164000668; Wed, 08 May 2024 03:26:40 -0700 (PDT) Received: from [192.168.1.18] ([79.123.79.31]) by smtp.gmail.com with ESMTPSA id g12-20020a0cf84c000000b006a0f837f670sm5407891qvo.144.2024.05.08.03.26.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 May 2024 03:26:39 -0700 (PDT) Message-ID: Date: Wed, 8 May 2024 11:26:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] objcopy: check input flavor before setting PE/COFF section alignment To: Jan Beulich Cc: Binutils References: <0e96f101-0205-4644-98be-9e75528affe5@suse.com> From: Nick Clifton Autocrypt: addr=nickc@redhat.com; keydata= xsFNBFm/2cUBEADkvRqMWfAryJ52T4J/640Av5cam9ojdFih9MjcX7QWFxIzJfTFYq2z+nb4 omdfZosdCJL2zGcn6C0AxpHNvxR9HMDkEyFHKrjDh4xWU+pH4z9azQEqJh331X7UzbZldqQo 16VkuVavgsTJaHcXm+nGIBTcUbl2oiTtHhmuaYxx6JTMcFjC7vyO5mLBw78wt52HBYweJ0Nj HBvvH/JxbAAULSPRUC61K0exlO49VFbFETQNG1hZTKEji95fPbre7PpXQ0ewQShUgttEE/J3 UA4jYaF9lOcZgUzbA27xTV//KomP0D30yr4e4EJEJYYNKa3hofTEHDXeeNgM25tprhBUMdbV RZpf2Keuk2uDVwc+EiOVri48rb1NU+60sOXvoGO6Ks81+mhAGmrBrlgLhAp8K1HPHI4MG4gH nrMqX2rEGUGRPFjC3qqVVlPm8H05PnosNqDLQ1Pf7C0pVgsCx6hKQB7Y1qBui7aoj9zeFaQg pYef+CEERIKEcWwrjaOJwK3pi9HFdxS0NNWYZj8HPzz/AsgTTQdsbulPlVq2SsctmOnL42CZ OCTppGYwl53CG/EqVY+UQBzFzJBaY8TJRFFYVEy5/HH4H11rMoZwqIkk71EOGU3X6mWlANRi kR3M4GhVITRzuaV69Fed+OeXcCmP94ASLfuhBR2uynmcHpBKpwARAQABzTtOaWNrIENsaWZ0 b24gKENoaWVmIEJpbnV0aWxzIE1haW50YWluZXIpIDxuaWNrY0ByZWRoYXQuY29tPsLBeAQT AQIAIgUCWb/ZxQIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQE/zvid2ePE9cOxAA 3cX1bdDaTFttTqukdPXLCtD2aNwJos4vB4LYPSgugLkYaHIQH9d1NQPhS0TlUeovnFNESLaV soihv0YmBUCyL4jE52FRoTjE6fUhYkFNqIWN2HYwkVrSap2UUJFquRVoVbPkbSup8P+D8eyd BbdxsY6f+5E8Rtz5ibVnPZTib7CyqnFokJITWjzGdIP0Gn+JWVa6jtHTImWx1MtqiuVRDapU hrIoUIjf98HQn9/N5ylEFYQTw7tzaJNWeGUoGYS8+8n/0sNbuYQUU/zwMVY9wpJcrXaas6yZ XGpF/tua59t9LFCct+07YAUSWyaBXqBW3PKQz7QP+oE8yje91XrhOQam04eJhPIBLO88g6/U rdKaY7evBB8bJ76Zpn1yqsYOXwAxifD0gDcRTQcB2s5MYXYmizn2GoUm1MnCJeAfQCi/YMob R+c8xEEkRU83Tnnw3pmAbRU6OcPihEFuK/+SOMKIuV1QWmjkbAr4g9XeXvaN+TRJ9Hl/k1k/ sj+uOfyGIaFzM/fpaLmFk8vHeej4i2/C6cL4mnahwYBDHAfHO65ZUIBAssdA6AeJ+PGsYeYh qs6zkpaA2b0wT4f9s7BPSqi0Veky8bUYYY7WpjzDcHnj1gEeIU55EhOQ42dnEfv7WrIAXanO P8SjhgqAUkb3R88azZCpEMTHiCE4bFxzOmjOwU0EWb/ZxQEQALaJE/3u23rTvPLkitaTJFqK kwPVylzkwmKdvd2qeEFk1qys2J3tACTMyYVnYTSXy5EJH2zJyhUfLnhLp8jJZF4oU5QehOaJ PcMmzI/CZS1AmH+jnm6pukdZAowTzJyt4IKSapr+7mxcxX1YQ2XewMnFYpLkAA2dHaChLSU/ EHJXe3+O4DgEURTFMa3SRN/J4GNMBacKXnMSSYylI5DcIOZ/v0IGa5MAXHrP1Hwm1rBmloIc gmzexczBf+IcWgCLThyFPffv+2pfLK1XaS82OzBC7fS01pB/eDOkjQuKy16sKZX6Rt57vud4 0uE5a0lpyItC2P7u7QWL4yT5pMF+oS8bm3YWgEntV380RyZpqgJGZTZLNq2T4ZgfiaueEV4J zOnG2/QRGjOUrNQaYzKy5V127CTnRg4BYF/uLEmizLcI3O3U1+mEz6h48wkAojO1B6AZ8Lm+ JuxOW5ouGcrkTEuIG56GcDwMWS/Pw/vNsDyNmOCjy9eEKWJgmMmLaq59HpfTd8IOeaYyuAQH AsYt/zzKy0giMgjhCQtuc99E4nQE9KZ44DKsnqRabK9s3zYE3PIkCFIEZcUiJXSXWWOIdJ43 j+YyFHU5hqXfECM6rzKGBeBUGTzyWcOX6YwRM4LzQDVJwYG8cVfth+v4/ImcXR43D4WVxxBE AjKag02b+1yfABEBAAHCwV8EGAECAAkFAlm/2cUCGwwACgkQE/zvid2ePE/dqQ/6ApUwgsZz tps0MOdRddjPwz44pWXS5MG45irMQXELGQyxkrafc8lwHeABYstoK8dpopTcJGE3dZGL3JNz 1YWxQ5AV4uyqBn5N8RubcA8NzR6DQP+OGPIwzMketvVC/cbbKDZqf0uTDy3jP65OFhSkTEIy nYv1Mb4JJl3Sq+haUbfWLAV5nboSuHmiZE6Bz2+TjdoVkNwHBfpqxu6MlWka+P98SUcmY8iV hPy9QC1XFOGdFDFf1kYgHW27mFwds35NQhNARgftAVz9FZXruW6tFIIfisjr3rVjD9R8VgL7 l5vMr9ylOFpepnI6+wd2X1566HW7F1Zw1DIrY2NHL7kL5635bHrJY4n7o/n7Elk/Ca/MAqzd IZxz6orfXeImsqZ6ODn4Y47PToS3Tr3bMNN9N6tmOPQZkJGHDBExbhAi/Jp8fpWxMmpVCUl6 c85cOBCR4s8tZsvGYOjR3CvqKrX4bb8GElrhOvAJa6DdmZXc7AyoVMaTvhpq3gJYKmC64oqt 7zwIHwaCxTbP6C6oUp9ENRV7nHnXN3BlvIgCo4QEs6HkDzkmgYlCEOKBiDyVMSkPDZdsspa+ K4GlU2Swi/BDJMjtDxyo+K0M81LXXxOeRfEIfPtZ3ddxBKPva1uSsuz+pbN9d1JY8Ko5T/h1 6susi2ReUyNJEJaSnjO5z13TQ1U= In-Reply-To: <0e96f101-0205-4644-98be-9e75528affe5@suse.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jan, >>> Of course the value (first) being set on the input bfd is suspicious >>> in the first place: When copying e.g. ELF to PE/COFF, the option ought >>> to be similarly respected, yet clearly it can't be set like this then on >>> the incoming object. The change here is merely to address the testsuite >>> failures observed for Arm64 and RISC-V ("Check if efi app format is >>> recognized") as well as the (latent) memory corruption. > Well, before putting it in - any thoughts on the post-commit-message remark > above? Sorry. Well in the first place converting from ELF to PE is always going to be a difficult process. So trying to combine it with adjustments to other properties, such as alignment, is just asking for trouble. My feeling therefore is that we ought to be have a warning in the documentation telling users to be careful and maybe take things one step at a time. > Is it really meant to stay the way of the input bfd's data is being > altered, rather than keeping that intact and fiddling only with the output? > And thus - afaict - rendering the command line option (silently) useless > when copying ELF to PE? You are right. For this particular case maybe we should add a test for ELF->PE format changing and refuse to adjust the alignments. Cheers Nick