From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2043.outbound.protection.outlook.com [40.107.20.43]) by sourceware.org (Postfix) with ESMTPS id 871283858C2C for ; Sun, 16 Oct 2022 06:19:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 871283858C2C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mWen7umuLAjK64xncsiYWi1KgyFRgRto+7IMQ/bGFQRkZUUmDJpiZUHpKpA+IkVKi+Yy/SjVCMg7ouczi67iyIDwrWMFB1e2BzCsdBSSfwx5u/O5H5RGrET4N5rykcErOtxbL2QoCuElXzZ93Wo884TXKmJlwpDIdC1jpMGW1SBy3alGnwivpV+pnBqBhu8AFLR28V6r1EGkX0rTsda0eZ0sArO4qScdP93O0vDM7nvsAdB/Np0pZBCRwe/LYKOxNxmHPu2YGb2nqdDmkMqkCiqEw30VIcvcV6grfSIAjsf8O6961xwpwDHHnNJs6e040zCsBQye5i6YzCohsLr9kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VlGjx92/vlIyoiyQUAifVfNZbL7cX3/2K3zZys/VL08=; b=PQ+PZkrb+aeGJ5Xa+VzWFOUz6On41+QvuMTC1esnAHB0TU2KwGYT8442ReoEt1p+7HzlYUftXANI7rEx5Xeg5OYIywB/vHJRdvfc/9qa3R67t2kRlUjKdZUMfyFqirxp9GZjTSsv67NA3lUrC3V0qN0+5PVVzMRz2TJ9/4NIBbM27lPv33aenC6bjK7gESfmGTbHfaKvxBEUH7AP2ciO17ZHUqUiQvlSm2H4pC8LMPdMmfRJBdBbymiqvjulWK7L7yBwEhRWHUyPR4pErJekxqbffsx0M6q87i3fl3+Hg8gV8jKJmLqwEhQaw4Jl7GcCHbPnY+A3xM0ZfDQsKOiIVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VlGjx92/vlIyoiyQUAifVfNZbL7cX3/2K3zZys/VL08=; b=mZ5I0AS52whJzBSOq6OQujyYnW0iM6FAylobxUqd13HOIQD6qT+Nfgkz9IYRzC1X8e6RAKXEyrWYw954PX6HG2rtRBf5B4mKLyldIwN6QJEdKAWXMsDFoW8pBJLbdwPQDI8zpH6H/jkUooFHR431J/bMy+3NuceVJPnDdAcOhK3ueNSK2ll2f/1UvQRKqOvFjoj1Y52dw4iG+mIwnaNPn0lOpuxaWJ8iy0UHYtgIXPxutJ74psUFfVdgvNJ8fPdBhQQFbhF6di1Ln1eErLmS5A9NoZI54c9DZEgEhdMO0Ck0vJzrMauaQvlFZZ19BUx3iNX1Qk9OZaPgTPEXO/tP3w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7815.eurprd04.prod.outlook.com (2603:10a6:20b:28a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Sun, 16 Oct 2022 06:19:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.032; Sun, 16 Oct 2022 06:19:08 +0000 Message-ID: Date: Sun, 16 Oct 2022 08:19:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH 04/10] Support Intel CMPccXADD Content-Language: en-US From: Jan Beulich To: Haochen Jiang Cc: hjl.tools@gmail.com, binutils@sourceware.org References: <20221014091248.4920-1-haochen.jiang@intel.com> <20221014091248.4920-5-haochen.jiang@intel.com> <1d847a52-b1ff-b816-1507-7077724901bb@suse.com> In-Reply-To: <1d847a52-b1ff-b816-1507-7077724901bb@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM7PR04CA0007.eurprd04.prod.outlook.com (2603:10a6:20b:110::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7815:EE_ X-MS-Office365-Filtering-Correlation-Id: 3e1a2504-9667-4eac-3d72-08daaf3e557b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t9fPZ6md1DcCUFE/OXJg6BNoV+65ZS9rw6zmHte+zx3ny4YS3DMR8CbYETl40zZasuqjR+xRUIcqIeKr5PUeMTTT9U3Qu0AOtwBOzXsp7lmt3qYN6HFNtgJ+ty+8bN/I82dcGJFgu+Xmc9QTrn1HOdk1sjrzfc4XiswjnInzL61PbP6N/n35yrEGlvoy9TX/xQ82Cp0QhBsv7y01We9AZjorJa6/0T/c+MBEy5T1bbzS2ItBnGKpssTXBCjhzGwRAxrwV/hFU1/K7RFRYMsDBmXI7nJluyVedRnD82kA/PGuDLHDMtCK5DRI3SXJIYXlWhxqlv3TxVUKxX6ppTMOWOjQDSiBF5biFNhkzBV72y5o5004/0KRHlNJtgubLa2XGSFaW734ou8z8ArK8EAYGPvvjI3BVv0yrMJiFss/JJhUdaaoO8aI6QMzPxdvwOQkt0nX05AMQEhOB3mkLOJCYEFT04ybpHS/TsKb/tcd6zODdlAZxZtFCikDv9eBIOz34OjyVBptp2fATEv0t2yMGrni7ddyumb4USre1/3tUp2/8DQVHLLam9yM68ZLtPJZAhy+JH2/McOLRZcm9S0+Sxmvb2lSQARUwkiIOQrQez/WNTvSuY0ZzQH+CD9VTjeTkDtUCHUa+b4vF0uCFsiHYNQEKMQp1v4YjkUaX5309e+j4R1q9qy8utUDIXluWuKPLD54ucSXtaqRLwQGvu/UWcIrssmGFl1CXU9XyFf00M8RMZEke8trWwTrpkNqgQSMT7YTnh1ajA8r1MS3xoF6t4WHZ3++n8Fj3JPn99RgzY0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39850400004)(376002)(346002)(396003)(136003)(451199015)(31686004)(2906002)(2616005)(186003)(4326008)(8676002)(6506007)(6512007)(53546011)(41300700001)(86362001)(31696002)(36756003)(316002)(38100700002)(8936002)(66556008)(5660300002)(6916009)(4744005)(66476007)(6666004)(66946007)(6486002)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WVpkank0Q210TWFrV0tDVXF3b2NWNWY0cDJuTUlXV2tFM1JPSjYrdnRaMkJi?= =?utf-8?B?SlhwSmxwWkRUajdoR0Y1eU95aERHaVNoVFduQ3owamUzU3V2NUQzUmhIZ1F5?= =?utf-8?B?dEhNOEZwdHRIaVRadGgrRWpVWUo5K2xGZitzdjRocUJiMDdjWWdyeTdxdVor?= =?utf-8?B?SStUN3UwYzdpZk9sREkxVEJrcVczMnlPamt5am9sVjlKUlBETzUrUXVENmgr?= =?utf-8?B?MnAyamZYZ0VSdGYvT1VWRkhMUjFYaXhONElZZFFXWlNXU0NjMm9aMjd6WGFT?= =?utf-8?B?TndJZDYrZkRZdFhQWEc1OGduN0pmYlJPMGIrcTFYSER1VmdYU3AybUhFMDdq?= =?utf-8?B?eDRWZUMwNFZzQXliTDh3RWkrM29QV08zWk1lVjRMOXROdXEzbW5helQ4RDJ2?= =?utf-8?B?M0xmZUxIYkFIRFlHQVIwc0ZRRFlMNDYvZ1ptWnc1T2pvd0hsWFA2cFpLWTBM?= =?utf-8?B?bkRXaDRnbnF0VXJjUnRTL3ZLYytFb29oN05LV3RNOHZ3RVU3OUp2VmhnOStj?= =?utf-8?B?cmlxUHIzcEtpVU9CYjI4OWNzREd4NE1JQzdZQkV3SjF2SWhoNVdlNXZqY0tv?= =?utf-8?B?ZmZjL1luNkN0dnJUT09WNDJjdTk2MllLT2FWbnNJQlNBQis1NjVPSkRXRmMy?= =?utf-8?B?eG9FK1J2OE1QUWJCL1l3Zkh1dGdqcUJxK2NVbWxVSmZNR1JrOFViSUFaWkxQ?= =?utf-8?B?K0VrVjJpMkdHcnlkSEZhT1ZsU1ZJQ3ZPOVdPZWFlbXBVSHNjU1d2OFl3YjdJ?= =?utf-8?B?ZlJnK1FZenVEM2RaNVpRUmt2bThCd01HWTJVWU80T0x2OUd1bWZYb0luejRF?= =?utf-8?B?MitKVkxQbWFBclFiNFB5L215cFFXeWhtV3ZuMjBIWUxSblZpN2Q4R2oySFNk?= =?utf-8?B?RXVpd3NBdVRwc3JCb2MxclpweUVnWC9seWhDS2ZmbUNIeTJXT0dHa05xS0dF?= =?utf-8?B?WEd2ekJEOVJBY1J2RFN5dDFyODJCYmRudnhsYmgzdVRuak0zQVBBZkhsbDBu?= =?utf-8?B?R2VrUm4wTEhzTnFNcyszblBnaURvbWIzQzJvcW5wekwvQVpsNTlPUFdpWjJ5?= =?utf-8?B?amMzeTBaUWxDQnF1TUgxSngzRE9vK290QmpOaFM1ZWhtSW9NanNJSjVMV1Bm?= =?utf-8?B?YmQzTFBoMmxjcHpMdVppMFc2OEwwNndYQ1ZmdUVnVFdPYkhvanErcGZkN0FM?= =?utf-8?B?cUNydU0rQmlLUUVNaHFyK3B0UlF1UWl1RFh5N0o3cFhheU0vU2VZSWtLeEov?= =?utf-8?B?K2I2SmZuT3hsaFpBRmlxNC96bVBsdzZyUkhVQzZwN3U5Q1lrVnFlOHVuYW41?= =?utf-8?B?UElNVWFSeGlLdHJJUG90RGhPaHhLSE13UW1NOHVJUVc0U2ZjYy9oV3VVTWFk?= =?utf-8?B?Yi8wbGQwYVJDMHZ6MXdOMUFHN1RxZU1EQklWbEhHY0x0NmxJTnlhT3BCVWxE?= =?utf-8?B?cTRQOEhxM3RIRTFRMUlvM29SbytDT0crRzlJa2wzWklzS2VQS1czVXZxWmNw?= =?utf-8?B?UHFrTHlXRHhobmZETUpacU1zS2tNczlCblZXMTgzNVJyazFMUERmRklObXVm?= =?utf-8?B?Zkg3dURibDE4TW1OYngzYTlKRnNTV1JSWTNkMHkyelNhZUJydXNKeC8xcHZI?= =?utf-8?B?VG93YVltSCtibVd1aG1TeGpnK2FMRTE5NER0Znp1cFVYMFo0SmJpV0hvTUxB?= =?utf-8?B?ZDlQcjdGQW03bk9rZG9HSmJINndaY0VRclVhMVFmWlJmNjh2VFhWS0NwN3Bt?= =?utf-8?B?OU1wdVRNbFhYSW95SmtuVzJlVnFJZE45T0IvK3RHV202Z21rZElPUjdQanVj?= =?utf-8?B?ZVl1U0pqdHNJOHYzUDNETkV3akU2WmxZRlRaUXpNaDBFZmliY3NZdFVyMDVl?= =?utf-8?B?SWQ2WDhWclp3aDVzT25UeVRubXRKb3VhUmgxd3JoN1NMUytKYkF1dTlTL0Vm?= =?utf-8?B?WW9sOHZNTUJjYWprckd3SzAzTGNDZTJ0elhLcTlzRE9Pd01pcmdxa0Q4MTFR?= =?utf-8?B?dkI1bGRyaEhsU3pYQWd5eHpTeEdVV1pHM3czaHc2TGZuM0c3R2s5RlYybUll?= =?utf-8?B?cHJDUlRWMzFUSWNwUXREWWltdWUvb0ZycGRvUm5BbnRWMnBoMTdBOHVQUkJm?= =?utf-8?B?c2IxV2dSTkdkdThHQkRIRlRoZUhlVEpQMkp0SEdmaFFCQWFvcXRCcU8zcEtU?= =?utf-8?Q?s5QmMr9cH+/2j32+wj83VZXg04zbMB7Fljlkkv5nlzBQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e1a2504-9667-4eac-3d72-08daaf3e557b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2022 06:19:08.4569 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gfCuzcqEcoEnTIQQXnkNPwq+fd0sKaQOoNJJZbVA9huXwAgTyhF8DEnHRvO90aaLQAiMynX1o+v2vNFcXwHyLQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7815 X-Spam-Status: No, score=-3029.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 14.10.2022 15:46, Jan Beulich wrote: > On 14.10.2022 11:12, Haochen Jiang wrote: >> --- a/opcodes/i386-dis.c >> +++ b/opcodes/i386-dis.c >> @@ -366,6 +366,7 @@ fetch_data (struct disassemble_info *info, bfd_byte *addr) >> #define Ma { OP_M, a_mode } >> #define Mb { OP_M, b_mode } >> #define Md { OP_M, d_mode } >> +#define Mdq { OP_M, dq_mode } > > You're decoding via mod_table[], so I don't think you need this. Or (perhaps > better) vice versa - keep this (if there's no pre-existing one that fits) and > avoid the decode step through mod_table[]. In any event you will want to add a decode step through vex_len_table[], unless I've forgot about some mechanism making this unnecessary for e.g. all VEX-encoded GPR insns collectively. Jan