From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 7795F3889E06 for ; Wed, 16 Nov 2022 11:07:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7795F3889E06 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668596870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xH5ziwHnUHpVMAkpjwtuPHEdWhTCHzkBDLGun7XILuQ=; b=DF6IH+LuA+MNWGX/83jrQbv789Kgt+YlTPJqDOBKpfA5rhm8S/r9cCu5/ysxBkC7RT/aZx L4NefNB+J3/4HGwC6WbRZ4l34LCXaTlNYGDmbQyoRCZ0W0nfDvFMuQNArgSUE7XgW3ZE79 mLzWciyH0eJZSflIKqhqw+YqWsQjuUU= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-518-ZXaJSBPSOuKwjcnmFbTcQw-1; Wed, 16 Nov 2022 06:07:49 -0500 X-MC-Unique: ZXaJSBPSOuKwjcnmFbTcQw-1 Received: by mail-qv1-f71.google.com with SMTP id nn2-20020a056214358200b004bb7bc3dfdcso13103457qvb.23 for ; Wed, 16 Nov 2022 03:07:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:content-language :references:to:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xH5ziwHnUHpVMAkpjwtuPHEdWhTCHzkBDLGun7XILuQ=; b=LF/aEsZmzdkv7sWsqXmtS3vW4N+oYBPvNOOpKrsi9WkJdIFvrMTozGB6qln00J3njN Kb+n/jLhUpnWrc7TI2y0Y4YkiMq0CpeeZ6HNftoHFlR5wFjG3KhtOeSZjWlOKASfg/o0 R4YK7rjowyK9UtVoDPJ98eh4QBDiurXR3TsKmULOknNdBDff+TT/upBM1vMWJfm7yRK/ +QnXbi9ISe6XtSWc9+UhnfbxAOGip7gZtiTGWIAl9xwakPs1UKhkT553S4JBSyyF1gT6 mGfeN3b7pm2p+9hq2N4SUVkbLdV2vyjBtaDPX/pGJ3cKgcL8Q80iELXWjuv5OQS5ZgEU qLCQ== X-Gm-Message-State: ANoB5plCNTcyVPvC3B3uQ2wEZEKZOd4RICsNEdjdLWCGA8Im/n3B5XNr /0hqDpIefEyFBHxKgpuc8hqyK8SmMOD39J4xJ06Qo67ou3fPS8p2PUEoMs4R/LZHsxCgNpmjUhK +aH947SKlKV1f2ocsEw== X-Received: by 2002:a05:620a:c14:b0:6fa:ca:ba0f with SMTP id l20-20020a05620a0c1400b006fa00caba0fmr18550706qki.266.1668596868718; Wed, 16 Nov 2022 03:07:48 -0800 (PST) X-Google-Smtp-Source: AA0mqf6LUGvgo+mqRfuWav39bOFSRrF+esPiJ1MEDhlA3Cre5P7dvfC6CUHAQfGR+Rh+ldXugxkfng== X-Received: by 2002:a05:620a:c14:b0:6fa:ca:ba0f with SMTP id l20-20020a05620a0c1400b006fa00caba0fmr18550697qki.266.1668596868440; Wed, 16 Nov 2022 03:07:48 -0800 (PST) Received: from [192.168.1.18] (adsl-164-85.freeuk.com. [80.168.164.85]) by smtp.gmail.com with ESMTPSA id h2-20020ac85042000000b003a606428a59sm1175155qtm.91.2022.11.16.03.07.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Nov 2022 03:07:47 -0800 (PST) Message-ID: Date: Wed, 16 Nov 2022 11:07:46 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 To: David Guillen Fandos , binutils@sourceware.org References: <0deaab53-e106-c5e6-6a3a-5f9bbe32af04@redhat.com> From: Nick Clifton Subject: Re: Upstream PSP support in binutils In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi David, > Although I have some idea on how I will create patches, I still have > some questions. Do you guys have some docs and guidelines on how > patches for new targets should look like? Not yet, but I am working on it. I have created a wiki for the GNU binutils (https://sourceware.org/binutils/wiki/HomePage) with the intention of adding information suit able for users and contributors to the binutils. It is a work in progress at the moment, but I hope that it will prove to be useful in the long run. > Any preferences or guidelines to make reviews easy for you? Off the top of my head .... * One patch per problem please, unless the patch is very big, in which case splitting it up based on top-level directory is usually the way to go. * Attached or inline patches are OK, although some people's mailers do tend to corrupt inline patches (by line wrapping them for example) so often attachments are better. * Use git to create the patches (or "diff -rup if the sources are not in a clone of the repository). * Include details of how you tested the patch. If possible test with several different builds, in order to catch potential problems. For example if you are sub,itting a PSP patch which also touches some generic files then testing with a toolchain configured for a ntive linux host would be a good idea. > Perhaps there's some canonical examples you can point me to? Check the binutils mailing list. It is full of them. :-) Cheers Nick