From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id BE6E83858D32 for ; Sat, 6 Jan 2024 10:08:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BE6E83858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BE6E83858D32 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704535706; cv=pass; b=CbWes5EpfocWlqFJzmtEcsfBdU1a+cpg4xbMHwthNI76uHH52Y3mKd9FibVKmkCjfCV/BWLPbQ2sh9M2wlYQHzqHVgWQ7+kRKSPVWHvHlax8yCyw2JPv4MVJ1p0SS2GtBUq+1PKuCZfF7tCqcZSO/aNbKuE3CKvI5s/2V/9FTQU= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704535706; c=relaxed/simple; bh=V4Kj5RWQZTkroJX2dGfxwqPudtBzS6Tn6qTSsd61+BM=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=UlONCn5rtbEIA/sJnunTazay3D67LKfqtFhTX/HfSVvk8Ee84/bIQbYTBsM5XlBQudgxZDXpvEBy9TYNpXqo8y+VWHmmz/jggS28JYaacFiZ6Vd+TibZJ33N6HzbtHTq/qEMdnCCVVfgaAqQ26N220HKK1/nVXd1I+YfcyhY9LY= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 4069YsUd013423; Sat, 6 Jan 2024 10:08:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=MSkTzqNlvk5gOMhx3F1bq0ZPuZ5hA2N7Phmo+Z8Qvb4=; b=kpt1aCcjTqL7PoxX5/9p4LmodNKExHdVX6kJz8qNG7Pks2ps7NDxE9QiQJtcbpSI2EsT z9fkEe4ol2rsrX0Z2BMKRkD/v2yHRe+n+FYKB/S4/GivhYFDJtFtECVDxe8NKQnEjEdR HPqYFqDLtnGqYefqVOpF+8AzhwS46t+4UKIrMS1hZApj+EGpxivZZmPJPNg9dZSINarC 5jB6hn6QVlFr2Sbc03WNk1KQZuMbxVTvanJBOgP1C/GUPigPnexSwOqEt8njsoXZ1XUc SBsbYfgL5kBUZWJPAy/agfU7IhVL9Zstvq5iU6bmg++/hxwgCHsBWauHqn44hZHZbpHv UQ== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3vf4bgg28a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 06 Jan 2024 10:08:22 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 4069U3jT035034; Sat, 6 Jan 2024 10:08:22 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2169.outbound.protection.outlook.com [104.47.59.169]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3vewa3x1d7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 06 Jan 2024 10:08:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jv9VQfmGzKPVqlPm6f5g4wNjEbA10bidL02hOZHgHCAq6o6EF6mraxgyboXu8hI1IWvqBI8auCKyxJpYnsAD1booOQ7P7eU8LIZ1xk63IaTyTraQTqm9kf2rxKH+SR94VT8lDDZQv3hOYGAr1I1dpeKbzkQrIycfBEUTGGmLBcAcLJcazQNr/wmEgqaymApV2udnVIi8rUxw0YDRLaK3YXWmbTnZ6CGZ0T8aT6M8xYfDcgNIC8Tvx3ueLMKXJx7XHPX+K4nvPQO0mE22UX+SzR1WzDPpYJ7Cj5DF7BfNrRFFZcckg3rf5kVK2A/WaaTQ6iI4yBPRfC6z4/tSwT+7Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MSkTzqNlvk5gOMhx3F1bq0ZPuZ5hA2N7Phmo+Z8Qvb4=; b=G6L5pthZ2vY2FkfFMficm2BvvMxtCFW46qzqruu9GnvNKhrBEde2fJK7zhxMsa5+GXUNze9HAJ35PsAH24tfhVNv8uIflpkPoBcMP2HAfCD0p5+pGMEZlLjK+SVm+Xpes6+LysRzEaMumyohINguFdKCTuHolgLj/169YZ15XiI/tqKsEolB67cH3AyBQWhnNs4IrtofP0MGkcfDzHJKfLjhdta24+ciUGQT9B/yS+LIa8eAHq0CbeBsIUCSAh4/z9FpnHnduMC+4+TIr7+WhoAPjq5nmA/AAeCd/apJXxbnjJAyQr/Xx4TClrVJ1/FgjNJr9RshoXlwlZSZF/GY2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MSkTzqNlvk5gOMhx3F1bq0ZPuZ5hA2N7Phmo+Z8Qvb4=; b=vJm2yEsFoIDnE4xD24PoroANBJjzn/ixNJIC2LBuRANfklRtoAo7AgWpqh582j3QTGHfADdKiGtJk/gS2R1xazU6SXJcqDcejdAUiBhc4lGUA2FCMJxLQIl16hG4l3b2kHEfyJvfZQ9F2SZjW7o3zvswD6dCx2oWpz//YgsbJ6M= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by SJ0PR10MB5584.namprd10.prod.outlook.com (2603:10b6:a03:3d3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.19; Sat, 6 Jan 2024 10:08:05 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fde7:fb92:8ea1:a5ac]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fde7:fb92:8ea1:a5ac%4]) with mapi id 15.20.7159.013; Sat, 6 Jan 2024 10:08:04 +0000 Message-ID: Date: Sat, 6 Jan 2024 02:08:02 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH, V4 09/14] opcodes: i386: new marker for insns that implicitly update stack pointer Content-Language: en-US To: Jan Beulich Cc: binutils@sourceware.org References: <20240103071526.3846985-1-indu.bhagat@oracle.com> <20240103074341.3858511-1-indu.bhagat@oracle.com> From: Indu Bhagat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR04CA0187.namprd04.prod.outlook.com (2603:10b6:303:86::12) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|SJ0PR10MB5584:EE_ X-MS-Office365-Filtering-Correlation-Id: 520623d6-7e91-41f1-538a-08dc0e9f5f8b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UrDjbTtUtfrbKBWGHkiY+vPuTBFFINwhPuc7Yl9gTAGlVwZnG1CDtlRfrvVDV40ger5i0mvIqFAImi7uvjDER+fbkxP8eVroJHm5gm3oLQt7tj27cc9y4XLheN0AoihfMzU1NM5Pq9fs4zFTemqB3hVbTZIjZWqbMwHLWxdC9DA9xLjk/20/zpF+HWuO/+UStQInpVkgIoobSUKjxNZkH1Wx1kyG6Lnj2aoKRzgFYmYjCFd+KbemhtIp/Uofh6Dam/mb1o8K7m2ytO47BW0F/8M4vLGhKe0XtliyAN9mwsAiG+7LOstkrOq+BG3ECdMQuGiaxkBQtybRKeIwuyg73pSXY40pumjojYVCcyt+NJMHLPFVNvQS/4iIGDpHBq6TKC1B1tKUvVfmnVuBdccLC9ULEPLqFHYa/Nv9pSKlIat3gYt9gPlX9r6o9QG4M1V5nconp/zEe7AGjr9hcjbw/q+BcFb12Nnl/QmUcNF2v8QyOLpcditvj34Rx/TYYJ3ooNwHZJ/ksQxszQhoSKR8gABXyBqxhYiLXB0cPrDLLHKsfcGoU+AC7q9PU+MOPr1m1rs0njTstKEaWAncPdzWhFBUIhqrzTc02kVvf4niqhh1I0LKGelEuj0imB7z7QrCv0lEm8kROPD+vT7Qjp64ZA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(136003)(346002)(396003)(366004)(376002)(230922051799003)(64100799003)(1800799012)(186009)(451199024)(38100700002)(41300700001)(31686004)(2906002)(6916009)(19627235002)(5660300002)(15650500001)(6486002)(44832011)(53546011)(36756003)(86362001)(6512007)(6506007)(316002)(8676002)(8936002)(4326008)(66946007)(66556008)(66476007)(31696002)(83380400001)(478600001)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmU2SGxqaE15Sll3YS9pczBlZGRoNzVVbklkNjNncWhDb0dpTHk5bk4vTWpC?= =?utf-8?B?bWJmaVlNbFpvbXVuQllsamFLakM0Z3pVZTNXejZaUCt4WHdJeUxGZUdOb3Bq?= =?utf-8?B?NXEyV1pQa3FKaTFrZ3NJZUo1ZWNVVUdmaHBkZ3crS2NLbzk4TTR0UkZlVkhN?= =?utf-8?B?MTUzVXdodXR5VWFmanZRbmVXd0d1L2RBWnBnbkpCckhKRlZ0V1NObDJVMnYx?= =?utf-8?B?OUp3bDQ2TkdOVzdCU2oxaGZqMCt5aml5QmJGbi81SVB2ZlRRYXlvbHJIWVZV?= =?utf-8?B?ejFTVkVPazRYc2U2TWxFRmVpM0J1SHU1bmlXdmx1aUt1djVkTUFVTDlwTkt5?= =?utf-8?B?K3Y3Z1VEY3RYMUp6blJHY3NyOHFDTnJzYzJkeFNTSkRsTVRidVkxSWREQ2dv?= =?utf-8?B?bnR0bEk4VnpaRHNrbUpEQ2ozbnZhQ1ZmOVg0N2V4NGlSVGpBQjJZeVlVY0Nt?= =?utf-8?B?UWdyNHJXWVFlcXRQMUVkTGo4OFBnY00ySGZqaWxsMjBZOHVrQ3dxQ21IYTRj?= =?utf-8?B?eFVDM2VHUklMM2g0ZjdVWmxHWXJ1akdVdUtrR0xNWjBpTGdLZU1ISW05OEhP?= =?utf-8?B?Y3RCV1pBMWFHYVRYL1dnRFQxbVorWEFnTUJEbDM2eWpIcDJ5TFBKSzZvMTJo?= =?utf-8?B?OEZCbmxHemEvemJCRFRKTm1JaEFtakpiMjZ1dG5aMEJXcm4xWndhenhvWXd1?= =?utf-8?B?emYydStTUDgwbytyMTNBUUl6M1Vkem10dU85UjZVNDFVZTlEVzRYS2hvWURk?= =?utf-8?B?MSs2QUc3Qm5abUwzLzhxVnlUVVhlMmcya3c4QSs1cmJlalNLN1BibGI4bWov?= =?utf-8?B?SllMV3l1SjRucUZmeE1tWE1DVkdKTmwwdVlXT3hFckhNdkxPYVlSR08rNFc4?= =?utf-8?B?MEl5dmJJcHZndTVSVFFORno4MWVzb0VPdk9kcElXT2pYMEd2M0krNERhWUE5?= =?utf-8?B?WXIwZGVvamZRaUtZT3BxV0YveERrdXFTbkl2ZkdsbmY5Z0RONjFoODUzZjBu?= =?utf-8?B?V2U2akQ0U2dCckxEdUcvckE4M0lVbFIxNDc0RUgzeFdDL3VjL1h1ZklIekZ6?= =?utf-8?B?WE15aHRFWnovRXlKNk90VU1RbmlHb0VGeVZGUWc2bkFoc0wreS9EU0xiWEpD?= =?utf-8?B?NnlkK0FPK1ZWcGVwNkh3MFJXUnVlc1FVUFkzeDNYQytjQzRnTmU2TnlSdWZB?= =?utf-8?B?ME5xYXlOemtwWEpHU3N3Q1F6dDlrY1BGRjloSW5uaHVjYmVKQTY2Zk9mMm1i?= =?utf-8?B?cFNvUjU3WGU5S1F0VzhCbmF4YkNIbmpWYnFVWXlMc3czSEVJcFZSQWFkTUFk?= =?utf-8?B?SmV5cTA0dnROeUI5RmNwb29RbWR0WkhhMFVhcjdnZ0tkeXJnNmFub1g4SVRq?= =?utf-8?B?Z1BubDUzN04wanFTdENpcFo1eHRFS09CNXZIUXZBWi9qMWtJWjBRc0pUN2Vk?= =?utf-8?B?WllwekZhUHY3bDhBQzYySjZoR1paRGpYcWJnenZzTkVYRTZXT3R1cENmMndM?= =?utf-8?B?NWJwdXB2VG1Vb1JLTkpUYmF4MjUrMldSNVRyeWJuK3c0aTBWSEFCMFRnV09r?= =?utf-8?B?NTdkWFl5eWo4NEtmMk9mdnM3VUY2KzVPZXRGZTNOU3N2SUx5K2lZUjNqQ1Q5?= =?utf-8?B?M1g3Y2hYOGthZnFRc0xSbXFnRUhncmRVOWtqeVBEeWh4c1BpZ0lLN1FHT2RX?= =?utf-8?B?ajhVM1pGUWhOTFJHdWY3SUFPTEE3NFZwS2J5b2w2cW45WUZpUkpPYk9iVTdF?= =?utf-8?B?c0t4K2ZTMTk5SzJqRWY4MHN0cHBLdVUrK09PdEswb2JEOVFMYllrQUZEK1R0?= =?utf-8?B?TkxGRUJNMjVOaXVTcDZNUklkM21UV1JHMDJaSDZrSVRoZGtkOHNpQ0VOTStQ?= =?utf-8?B?WDc2c21lYm03bmppK3FGWVR2c1FnQkkrWjZnVEJ2ZFJoUGpEMzZFMDVxbEVr?= =?utf-8?B?cC9EaDVGQ05jeHhxMWJEK2ZGNkIwdHNqTFYvdXpxeDNHOHZ6SWdNZXhlQkwy?= =?utf-8?B?QVpaRXUyYlIzQkJmZU9jRU9DRllsbTVsMGhucEdKK05hZkRpNGIrcmYrMVZw?= =?utf-8?B?VW5abEEraE5GamsweTRPd1ZsQTMrS2RqMHNjRU4zSVErandVMlVJZWZsT24y?= =?utf-8?B?SlhkalUya0ZvOEVaUFRVRDE2SFJNRXMwVGZpY28zYWNnODROMENjQTRuZUdy?= =?utf-8?Q?FzZkDS5iQ06tN5ResM8B8/k=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: qMHhrLsyc/VN2qB5vUXrZJxsJpiwWR5R950WfMQbOgsSjLeT26lug/tXP3fZdXcLy1ro/6JfMVAawtFrp0o1cnWIIs0y7gDUyIWy8Np9MwvFzTMoK+5I9mHAM2DFJkoWbn9eKf4nIjc/SqU+gOI7aDwpEUSLoDu3QQfprTBtFadJLoj9Y7U4OCwKZwZvv4Y3LxoiKfm2aaMPkUY3/lsLCcY6FA+6RX5JAx8l3hVz8BTv0qhdzCYAJHgGgkV/N97A/QSsFYJxJwT1iATkkb9yWVyh9CchxJcJYKZAjjoj/w24xCVHn+PsFSm1P/Va4xQXtuXd0CK9d/dAEk0Xpg7FgsN/h8P2OTiUAw7PCYGzEQUF5qL4KsppH6XgGiKeYCL42sO0iQhfxb1xiqw28cXl2CZZRej2eYsYO8ntTHNM35/PQnHYkcTf4gvNZ4AqjFxESAfIgrMm/v+Comv2bVkJegUzUZn+oPoRUkSmilCR5z3d6Nr49PI8yh9oYOPMPtCuUs9dlZJN+t/e3tP23JyuctiJ1LpLjwohrVU6UiUnSg0DHwzWwQEoY9LZ/JYU1Uy6oqzSRHGfSL+lc7JuDxCFFxfiKsL5Z/1tE5fhXUM8PxQ= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 520623d6-7e91-41f1-538a-08dc0e9f5f8b X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2024 10:08:04.7792 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WCGWrxFxxMeJuMKhFDApKp2pBux3oiR3CpMroW4LDyENQZMuRyTGamXbAGacyDUa1BgQnjvaviq7PwQy/CUuIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5584 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-05_08,2024-01-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 mlxscore=0 adultscore=0 spamscore=0 phishscore=0 suspectscore=0 mlxlogscore=665 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401060072 X-Proofpoint-ORIG-GUID: kt9UudN3P2vZ9xlxa3xeM_ZOFGrCobiY X-Proofpoint-GUID: kt9UudN3P2vZ9xlxa3xeM_ZOFGrCobiY X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/5/24 06:05, Jan Beulich wrote: > On 03.01.2024 08:43, Indu Bhagat wrote: >> --- a/opcodes/i386-opc.h >> +++ b/opcodes/i386-opc.h >> @@ -750,6 +750,9 @@ enum >> /* No CSPAZO flags update indication. */ >> NF, >> >> + /* Instruction updates stack pointer implicitly. */ >> + ImplicitStackOp, >> + >> /* The last bitfield in i386_opcode_modifier. */ >> Opcode_Modifier_Num >> }; >> @@ -796,6 +799,7 @@ typedef struct i386_opcode_modifier >> unsigned int isa64:2; >> unsigned int noegpr:1; >> unsigned int nf:1; >> + unsigned int implicitstackop:1; >> } i386_opcode_modifier; > > I'm not happy to see a new attribute be introduced for this (a new > OperandConstraint enumerator would seem more appropriate), while at > the same time I can see that the Rex2 attribute used in two of the > affected insns presently makes this impossible. However, with no > other way out, I'd rather see Rex2 become a standalone attribute, > and this one be another operand constraint. > To be sure I understand clearly, the ask here is to: - Use unsigned int rex2:1 in struct i386_opcode_modifier instead - Add a new OperandConstraint=IMPLICIT_STACK_OP - Remove the OperandConstraint=REX2_REQUIRED Is this right ? Indu