From: Nick Clifton <nickc@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: binutils@sourceware.org
Subject: Re: Commit: Close memory leaks in chew
Date: Mon, 08 Aug 2016 14:23:00 -0000 [thread overview]
Message-ID: <fffee1cb-09db-3ca3-d99c-8baa0c95a048@redhat.com> (raw)
In-Reply-To: <mvm37mfwk6z.fsf@hawking.suse.de>
Hi Andreas,
>> - free (buffer->ptr);
>> + if (buffer->ptr)
>> + free (buffer->ptr);
>
> free (0) is a no-op.
OK - I will remember that for the future. I doubt if it really matters
here, since the performance penalty of the test is trivial.
Cheers
Nick
prev parent reply other threads:[~2016-08-08 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 11:19 Nick Clifton
2016-08-08 11:53 ` Andreas Schwab
2016-08-08 14:23 ` Nick Clifton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fffee1cb-09db-3ca3-d99c-8baa0c95a048@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).