From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28188 invoked by alias); 24 Nov 2010 09:28:03 -0000 Received: (qmail 28180 invoked by uid 22791); 24 Nov 2010 09:28:02 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mail-fx0-f41.google.com (HELO mail-fx0-f41.google.com) (209.85.161.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 24 Nov 2010 09:27:56 +0000 Received: by fxm20 with SMTP id 20so8647278fxm.0 for ; Wed, 24 Nov 2010 01:27:54 -0800 (PST) Received: by 10.223.71.198 with SMTP id i6mr6898842faj.140.1290590874496; Wed, 24 Nov 2010 01:27:54 -0800 (PST) Received: from richards-desktop.stglab.manchester.uk.ibm.com (gbibp9ph1--blueice3n2.emea.ibm.com [195.212.29.84]) by mx.google.com with ESMTPS id n26sm74971fam.37.2010.11.24.01.27.53 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 24 Nov 2010 01:27:53 -0800 (PST) From: Richard Sandiford To: Matthias Klose Mail-Followup-To: Matthias Klose ,Tristan Gingold , binutils , richard.sandiford@linaro.org Cc: Tristan Gingold , binutils Subject: Re: Release 2.21 - Pre tests References: <2FB8160A-5560-40C7-8E4F-1A0B7531B63B@adacore.com> <4CEC0D91.7020204@ubuntu.com> Date: Wed, 24 Nov 2010 09:28:00 -0000 In-Reply-To: <4CEC0D91.7020204@ubuntu.com> (Matthias Klose's message of "Tue\, 23 Nov 2010 19\:53\:05 +0100") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00436.txt.bz2 Matthias Klose writes: > On 23.11.2010 17:32, Tristan Gingold wrote: >> Hi, >> >> here is the result of a first pre-test. I still plan to update the target list. >> >> Two comments: >> >> 1) are the arm-eabi failures expected ? > > I see these too, these seem to be introduced after 20101028. They were (rightly, IMO) introduced by the fix for ld/12001: we now complain if a symbol is defined by both -defsym and an input file. The patch below seems to work on both arm-linux-gnueabi and arm-eabi. Matthew, could you sanity-check it? I realise these -defsyms must be there for a reason, so I'm probably missing something, sorry. Richard ld/testsuite/ * ld-arm/arm-elf.exp (armeabitests): Remove --defsym argument from jump-reloc-veneers* tests. Index: ld/testsuite/ld-arm/arm-elf.exp =================================================================== --- ld/testsuite/ld-arm/arm-elf.exp 2010-11-24 08:58:57.000000000 +0000 +++ ld/testsuite/ld-arm/arm-elf.exp 2010-11-24 09:11:10.000000000 +0000 @@ -464,19 +464,19 @@ set armeabitests { "farcall-data"} {"R_ARM_THM_JUMP24 Relocation veneers: Short 1" - "-defsym _start=0x8000 --section-start destsect=0x00009000" + "--section-start destsect=0x00009000" "-march=armv7-a -mthumb" {jump-reloc-veneers.s} {{objdump -d jump-reloc-veneers-short1.d}} "jump-reloc-veneers-short1"} {"R_ARM_THM_JUMP24 Relocation veneers: Short 2" - "-defsym _start=0x8000 --section-start destsect=0x00900000" + "--section-start destsect=0x00900000" "-march=armv7-a -mthumb" {jump-reloc-veneers.s} {{objdump -d jump-reloc-veneers-short2.d}} "jump-reloc-veneers-short2"} {"R_ARM_THM_JUMP24 Relocation veneers: Long" - "-defsym _start=0x8000 --section-start destsect=0x09000000" + "--section-start destsect=0x09000000" "-march=armv7-a -mthumb" {jump-reloc-veneers.s} {{objdump -d jump-reloc-veneers-long.d}}