From: Richard Sandiford <rdsandiford@googlemail.com>
To: binutils@sourceware.org
Subject: [committed] Fix mipsisa32-linux-gnu linker failures
Date: Wed, 11 May 2011 12:55:00 -0000 [thread overview]
Message-ID: <g4vcxho0r1.fsf@googlemail.com> (raw)
Alan's nod in the direction of mipsisa32-linux-gnu made me look at
the 3 linker failures there. They were caused by missing checks for
$has_newabi.
These tests passed on mipsel-linux-gnu because of the default
"from-abi" architecture. One fix would therefore have been to
force the architecture on the command line. I think it's better
to test with the default architecture where possible though,
so we'd need some machinery to conditionally add an architecture
option only when one was needed.
In the meantime, this patch makes the handling of these three
tests consistent with all the other NewABI tests. Tested on
mipsisa32-linux-gnu and applied.
Richard
ld/testsuite/
* ld-mips-elf/mips-elf.exp: Add missing $has_newabi tests.
Index: ld/testsuite/ld-mips-elf/mips-elf.exp
===================================================================
--- ld/testsuite/ld-mips-elf/mips-elf.exp 2011-01-17 15:58:41.000000000 +0000
+++ ld/testsuite/ld-mips-elf/mips-elf.exp 2011-05-11 13:47:02.000000000 +0100
@@ -160,8 +160,10 @@ if $has_newabi {
if { $linux_gnu } {
run_dump_test "rel32-o32"
- run_dump_test "rel32-n32"
- run_dump_test "rel64"
+ if { $has_newabi } {
+ run_dump_test "rel32-n32"
+ run_dump_test "rel64"
+ }
# The first test checks that a mixed PIC/non-PIC relocatable link
# will not introduce any stubs itself, but will flag PIC functions
# for the final link.
@@ -333,7 +335,9 @@ if {$has_newabi} {
}
if { $linux_gnu } {
- run_dump_test "textrel-1"
+ if { $has_newabi } {
+ run_dump_test "textrel-1"
+ }
run_dump_test "got-page-1"
if $has_newabi {
run_dump_test "got-page-2"
reply other threads:[~2011-05-11 12:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=g4vcxho0r1.fsf@googlemail.com \
--to=rdsandiford@googlemail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).