From: Richard Sandiford <rdsandiford@googlemail.com>
To: Tristan Gingold <gingold@adacore.com>
Cc: binutils Development <binutils@sourceware.org>
Subject: Re: [Patch]: complete coff/rs6000.h
Date: Tue, 03 May 2011 08:35:00 -0000 [thread overview]
Message-ID: <g4vcxsxju3.fsf@googlemail.com> (raw)
In-Reply-To: <BB3EC980-9373-46F8-A942-05EC8D2BA877@adacore.com> (Tristan Gingold's message of "Thu, 28 Apr 2011 15:42:40 +0200")
Tristan Gingold <gingold@adacore.com> writes:
> @@ -173,6 +173,8 @@ union external_auxent {
> struct {
> char x_zeroes[4];
> char x_offset[4];
> + char x_pad[E_FILNMLEN - 8];
> + char x_ftype[1];
> } x_n;
> } x_file;
>
x_ftype applies to both name encodings, so something like the syment
definition would seem better. (That'd mean changing the bfd code too,
of course.)
> @@ -276,3 +278,12 @@ struct external_ldrel
> };
>
> #define LDRELSZ (2 * 4 + 2 * 2)
> +
> +struct external_exceptab
> +{
> + bfd_byte e_addr[4];
> + bfd_byte e_lang[1];
> + bfd_byte e_reason[1];
> +};
> +
> +#define EXCEPTSZ (4 + 2)
This part's OK though. Please add the corresponding 64-bit definition
to rs6k64.h while you're there, to keep the two in sync.
Richard
next prev parent reply other threads:[~2011-05-03 8:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 13:43 Tristan Gingold
2011-05-03 8:35 ` Richard Sandiford [this message]
2011-05-03 9:45 ` Tristan Gingold
2011-05-03 13:07 ` Richard Sandiford
2011-05-04 7:17 ` Tristan Gingold
2011-05-04 9:40 ` Richard Sandiford
2011-05-04 11:05 ` Tristan Gingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=g4vcxsxju3.fsf@googlemail.com \
--to=rdsandiford@googlemail.com \
--cc=binutils@sourceware.org \
--cc=gingold@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).