From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19916 invoked by alias); 26 Apr 2011 08:47:30 -0000 Received: (qmail 19908 invoked by uid 22791); 26 Apr 2011 08:47:29 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_20,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-ww0-f41.google.com (HELO mail-ww0-f41.google.com) (74.125.82.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 26 Apr 2011 08:47:15 +0000 Received: by wwi18 with SMTP id 18so2021554wwi.0 for ; Tue, 26 Apr 2011 01:47:14 -0700 (PDT) Received: by 10.227.42.133 with SMTP id s5mr477411wbe.193.1303807634068; Tue, 26 Apr 2011 01:47:14 -0700 (PDT) Received: from richards-thinkpad (gbibp9ph1--blueice2n1.emea.ibm.com [195.212.29.75]) by mx.google.com with ESMTPS id e13sm3694094wbi.57.2011.04.26.01.47.12 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 26 Apr 2011 01:47:13 -0700 (PDT) From: Richard Sandiford To: Tristan Gingold Mail-Followup-To: Tristan Gingold ,binutils , Nick Clifton , rdsandiford@googlemail.com Cc: binutils , Nick Clifton Subject: Re: [patch] Convert coff64-rs6000.c to iso-c References: <49F283B4-757D-4BFF-9FCB-94097A486783@adacore.com> <4DAC3D3A.7090106@redhat.com> <4DB03A7B.4090002@redhat.com> <7D113C3D-4663-40D1-97CA-972703D8C55E@adacore.com> Date: Tue, 26 Apr 2011 08:47:00 -0000 In-Reply-To: <7D113C3D-4663-40D1-97CA-972703D8C55E@adacore.com> (Tristan Gingold's message of "Fri, 22 Apr 2011 10:02:24 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00367.txt.bz2 Tristan Gingold writes: > /* Relocation functions */ > -static bfd_boolean xcoff64_reloc_type_br > - PARAMS ((XCOFF_RELOC_FUNCTION_ARGS)); > +static bfd_boolean xcoff64_reloc_type_br (XCOFF_RELOC_FUNCTION_ARGS); BFD style is to have the (...) on the next line, regardless of whether it fits on the current one: static bfd_boolean xcoff64_reloc_type_br (XCOFF_RELOC_FUNCTION_ARGS); > @@ -241,14 +238,11 @@ bfd_boolean (*xcoff64_calculate_relocation[XCOFF_MAX_CALCULATE_RELOCATION]) > #define coff_bfd_reloc_type_lookup xcoff64_reloc_type_lookup > #define coff_bfd_reloc_name_lookup xcoff64_reloc_name_lookup > #ifdef AIX_CORE > -extern const bfd_target * rs6000coff_core_p > - PARAMS ((bfd *abfd)); > +extern const bfd_target * rs6000coff_core_p (bfd *abfd); > extern bfd_boolean rs6000coff_core_file_matches_executable_p > - PARAMS ((bfd *cbfd, bfd *ebfd)); > -extern char *rs6000coff_core_file_failing_command > - PARAMS ((bfd *abfd)); > -extern int rs6000coff_core_file_failing_signal > - PARAMS ((bfd *abfd)); > + (bfd *cbfd, bfd *ebfd); > +extern char *rs6000coff_core_file_failing_command (bfd *abfd); > +extern int rs6000coff_core_file_failing_signal (bfd *abfd); > #define CORE_FILE_P rs6000coff_core_p > #define coff_core_file_failing_command \ > rs6000coff_core_file_failing_command Same here. > { > union internal_auxent *in = (union internal_auxent *) inp; > union external_auxent *ext = (union external_auxent *) extp; > > - memset ((PTR) ext, 0, bfd_coff_auxesz (abfd)); > + memset ((void *) ext, 0, bfd_coff_auxesz (abfd)); Just drop the (PTR) conversion. (void *) casts aren't necessary and tend to make things less readable. We certainly won't be able to enforce explicit (void *) casts for future changes, so the code would become inconsistent. Same throughout. > @@ -2829,16 +2750,11 @@ const bfd_target rs6000coff64_vec = > (void *) &bfd_xcoff_backend_data, > }; > > -extern const bfd_target *xcoff64_core_p > - PARAMS ((bfd *)); > -extern bfd_boolean xcoff64_core_file_matches_executable_p > - PARAMS ((bfd *, bfd *)); > -extern char *xcoff64_core_file_failing_command > - PARAMS ((bfd *)); > -extern int xcoff64_core_file_failing_signal > - PARAMS ((bfd *)); > -#define xcoff64_core_file_pid \ > - _bfd_nocore_core_file_pid > +extern const bfd_target *xcoff64_core_p (bfd *); > +extern bfd_boolean xcoff64_core_file_matches_executable_p (bfd *, bfd *); > +extern char *xcoff64_core_file_failing_command (bfd *); > +extern int xcoff64_core_file_failing_signal (bfd *); > +#define xcoff64_core_file_pid _bfd_nocore_core_file_pid More cases where the params should stay on their current line. OK with those changes, thanks. Richard