From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2462 invoked by alias); 29 Mar 2005 19:53:25 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 2433 invoked from network); 29 Mar 2005 19:53:18 -0000 Received: from unknown (HELO mx1.suse.de) (195.135.220.2) by sourceware.org with SMTP; 29 Mar 2005 19:53:18 -0000 Received: from hermes.suse.de (hermes-ext.suse.de [195.135.221.8]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id A27A11602A4F for ; Tue, 29 Mar 2005 21:53:17 +0200 (CEST) From: Andreas Jaeger To: "Jan Beulich" Cc: Subject: Re: [PATCH] x86-64: certain pcrel expressions broken References: OpenPGP: id=C272A126; url=http://www.suse.de/~aj/keys.txt Date: Wed, 30 Mar 2005 10:14:00 -0000 In-Reply-To: (Jan Beulich's message of "Tue, 29 Mar 2005 17:16:51 +0200") Message-ID: User-Agent: Gnus/5.110003 (No Gnus v0.3) XEmacs/21.5-b18 (linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-SW-Source: 2005-03/txt/msg00885.txt.bz2 --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1469 "Jan Beulich" writes: > While expressions like "sym - ." were correctly converted to use pc-relat= ive > relocations for 8-, 16-, and 32-bit operations, sign-extended 32-bit oper= ands > of 64-bit operations didn't get converted. Do you have a testcase? Andreas > Built and tested on x86_64-unknown-linux-gnu. > > Jan > > gas/ > 2005-03-29 Jan Beulich > > * config/tc-i386.c (md_apply_fix3): Also handle BFD_RELOC_X86_64_32S. > (tc_gen_reloc): Handle BFD_RELOC_X86_64_32S in the default case. > > --- /home/jbeulich/src/binutils/mainline/2005-03-29/gas/config/tc-i386.c = 2005-03-14 15:08:07.000000000 +0100 > +++ 2005-03-29/gas/config/tc-i386.c 2005-03-29 15:51:21.258603448 +0200 > @@ -4798,6 +4798,7 @@ md_apply_fix3 (fixP, valP, seg) > break; >=20=20 > case BFD_RELOC_32: > + case BFD_RELOC_X86_64_32S: > fixP->fx_r_type =3D BFD_RELOC_32_PCREL; > break; > case BFD_RELOC_16: > @@ -5361,7 +5362,6 @@ tc_gen_reloc (section, fixp) > case BFD_RELOC_386_TLS_GOTIE: > case BFD_RELOC_386_TLS_LE_32: > case BFD_RELOC_386_TLS_LE: > - case BFD_RELOC_X86_64_32S: > case BFD_RELOC_X86_64_TLSGD: > case BFD_RELOC_X86_64_TLSLD: > case BFD_RELOC_X86_64_DTPOFF32: > > > Andreas --=20 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GPG fingerprint =3D 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 --=-=-= Content-Type: application/pgp-signature Content-length: 188 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (GNU/Linux) iD8DBQBCSbIpOJpWPMJyoSYRAtmLAJ9ELMKvOfxIf7xe+FVN0gKZWwp+5ACeJPMN 2+oTfaKItJmnuW60qVZBkhA= =xefr -----END PGP SIGNATURE----- --=-=-=--