From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-38402-listarch-binutils=sources.redhat.com@sources.redhat.com>
Received: (qmail 11515 invoked by alias); 1 Mar 2005 23:20:49 -0000
Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/binutils/>
List-Post: <mailto:binutils@sources.redhat.com>
List-Help: <mailto:binutils-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: binutils-owner@sources.redhat.com
Received: (qmail 11495 invoked from network); 1 Mar 2005 23:20:42 -0000
Received: from unknown (HELO Cantor.suse.de) (195.135.220.2)
  by sourceware.org with SMTP; 1 Mar 2005 23:20:42 -0000
Received: from hermes.suse.de (hermes-ext.suse.de [195.135.221.8])
	(using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits))
	(No client certificate requested)
	by Cantor.suse.de (Postfix) with ESMTP id 75075153A1F3
	for <binutils@sources.redhat.com>; Wed,  2 Mar 2005 00:20:41 +0100 (CET)
To: binutils@sources.redhat.com
Subject: Re: fix a mmix assertion failure
References: <20050301221959.GU5299@bubble.modra.org>
From: Andreas Schwab <schwab@suse.de>
X-Yow: Okay, BARBRA STREISAND, I recognize you now!!  Also EFREM ZIMBALIST,
 JUNIOR!!  And BEAUMONT NEWHALL!!  Everybody into th' BATHROOM!
Date: Tue, 01 Mar 2005 23:20:00 -0000
In-Reply-To: <20050301221959.GU5299@bubble.modra.org> (Alan Modra's message
 of "Wed, 2 Mar 2005 08:49:59 +1030")
Message-ID: <jeoee3uf5j.fsf@sykes.suse.de>
User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/22.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-SW-Source: 2005-03/txt/msg00052.txt.bz2

Alan Modra <amodra@bigpond.net.au> writes:

> @@ -1561,7 +1561,13 @@ fb_label_name (long n,	/* We just saw "n
>    char symbol_name_temporary[20];	/* Build up a number, BACKWARDS.  */
>  
>    know (n >= 0);
> -  know (augend == 0 || augend == 1);
> +  know (
> +#ifdef TC_MMIX
> +	(unsigned long) augend <= 2 /* See mmix_fb_label.  */
> +#else
> +	(unsigned long) augend <= 1
> +#endif
> +	);

That won't work when know is a macro.  You can't have preprocessor
directives inside a macro parameter.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."