public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: dj@redhat.com
Cc: binutils@sourceware.org
Subject: Re: Increment
Date: Fri, 09 Jun 2006 13:42:00 -0000	[thread overview]
Message-ID: <jewtbq1mdg.fsf@sykes.suse.de> (raw)
In-Reply-To: <20060606030414.GH519@bubble.grove.modra.org> (Alan Modra's 	message of "Tue, 6 Jun 2006 12:34:14 +0930")

Alan Modra <amodra@bigpond.net.au> writes:

> On Fri, May 26, 2006 at 02:46:47PM -0700, Ian Lance Taylor wrote:
>> bfd_hash_lookup in bfd/hash.c has an incorrectly indented and
>> misplaced increment of table->count:
>
> This seems to have fallen through the cracks.  Applying the obvious
> fix.
>
> 	* hash.c (bfd_hash_lookup): Correct stray line.

The linker is now crashing very often with an assertion failure in
_bfd_elf_strtab_delref.  Apparently the hash resizing was never properly
tested, since with the misplaced increment it was unlikely to ever
trigger.  In fact, disabling it will fix the crashes.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

  parent reply	other threads:[~2006-06-09 13:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-27 16:33 Increment Ian Lance Taylor
2006-06-06  4:30 ` Increment Alan Modra
2006-06-06 10:52   ` Increment Alan Modra
2006-06-07  1:40   ` Increment Thiemo Seufer
2006-06-07  5:02     ` Increment Alan Modra
2006-06-09 13:42   ` Andreas Schwab [this message]
2006-06-12  4:32     ` Increment Alan Modra
2006-06-12 10:50       ` Increment Andreas Schwab
2006-06-12 18:53         ` Increment DJ Delorie
2006-06-12 19:13         ` Increment H. J. Lu
2006-06-12 23:55           ` Increment Andreas Schwab
2006-06-13  1:11             ` Increment Alan Modra
2006-06-13 10:52               ` Increment Andreas Schwab
2006-06-13  8:53             ` Increment H. J. Lu
2006-06-13 13:49               ` Increment Andreas Schwab
2006-06-13 14:49                 ` Increment Alan Modra
2006-06-13 14:52                   ` Increment Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jewtbq1mdg.fsf@sykes.suse.de \
    --to=schwab@suse.de \
    --cc=binutils@sourceware.org \
    --cc=dj@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).