From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-46318-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 3164 invoked by alias); 9 Jun 2006 13:37:20 -0000
Received: (qmail 3133 invoked by uid 22791); 9 Jun 2006 13:37:15 -0000
X-Spam-Check-By: sourceware.org
Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 09 Jun 2006 13:37:04 +0000
Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) 	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) 	(No client certificate requested) 	by mx2.suse.de (Postfix) with ESMTP id 44A5D1EBF9; 	Fri,  9 Jun 2006 15:37:00 +0200 (CEST)
From: Andreas Schwab <schwab@suse.de>
To: dj@redhat.com
Cc: binutils@sourceware.org
Subject: Re: Increment
References: <m3u07c5uig.fsf@gossamer.airs.com> 	<20060606030414.GH519@bubble.grove.modra.org>
X-Yow: Wait..  is this a FUN THING or the END of LIFE in Petticoat Junction??
Date: Fri, 09 Jun 2006 13:42:00 -0000
In-Reply-To: <20060606030414.GH519@bubble.grove.modra.org> (Alan Modra's 	message of "Tue, 6 Jun 2006 12:34:14 +0930")
Message-ID: <jewtbq1mdg.fsf@sykes.suse.de>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
X-SW-Source: 2006-06/txt/msg00127.txt.bz2

Alan Modra <amodra@bigpond.net.au> writes:

> On Fri, May 26, 2006 at 02:46:47PM -0700, Ian Lance Taylor wrote:
>> bfd_hash_lookup in bfd/hash.c has an incorrectly indented and
>> misplaced increment of table->count:
>
> This seems to have fallen through the cracks.  Applying the obvious
> fix.
>
> 	* hash.c (bfd_hash_lookup): Correct stray line.

The linker is now crashing very often with an assertion failure in
_bfd_elf_strtab_delref.  Apparently the hash resizing was never properly
tested, since with the misplaced increment it was unlikely to ever
trigger.  In fact, disabling it will fix the crashes.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."