* RFA: Fix ARM testsuite selective.exp with installed toolchain
@ 2004-12-01 21:06 Daniel Jacobowitz
2004-12-01 21:10 ` Ian Lance Taylor
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Jacobowitz @ 2004-12-01 21:06 UTC (permalink / raw)
To: binutils
An ARM check-ld run using an installed toolchain will fail the selective
linking tests, because it can't find libgcc. And grubbing around in
libgcc's build directory is bad anyway. The fix was just a couple of lines
down, for HPPA...
OK?
--
Daniel Jacobowitz
2004-12-01 Daniel Jacobowitz <dan@codesourcery.com>
* ld-selective/selective.exp: Use -print-libgcc-file-name for
ARM and v850 also.
Index: ld/testsuite/ld-selective/selective.exp
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-selective/selective.exp,v
retrieving revision 1.31
diff -u -p -r1.31 selective.exp
--- ld/testsuite/ld-selective/selective.exp 18 Jun 2004 15:41:47 -0000 1.31
+++ ld/testsuite/ld-selective/selective.exp 1 Dec 2004 21:04:11 -0000
@@ -1,5 +1,6 @@
# Expect script for LD selective linking tests
-# Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation, Inc.
+# Copyright 1998, 1999, 2000, 2001, 2002, 2003, 2004
+# Free Software Foundation, Inc.
#
# This file is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -110,15 +111,15 @@ foreach testitem $seltests {
}
# V850 targets need libgcc.a
- # FIXME: This does not work with installed toolchains!
if [istarget v850*-*-elf] {
- set objfile "$objfile -L ../gcc -lgcc"
+ catch "exec $CC -print-libgcc-file-name" libgcc
+ set objfile "$objfile $libgcc"
}
# ARM targets need libgcc.a in THUMB mode so that __call_via_r3 is provided
- # FIXME: This does not work with installed toolchains!
if {[istarget arm-*-*] || [istarget xscale-*-*]} {
- set objfile "$objfile -L ../gcc -lgcc"
+ catch "exec $CC -print-libgcc-file-name" libgcc
+ set objfile "$objfile $libgcc"
}
# HPPA linux targets need libgcc.a for millicode routines ($$dyncall).
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: RFA: Fix ARM testsuite selective.exp with installed toolchain
2004-12-01 21:06 RFA: Fix ARM testsuite selective.exp with installed toolchain Daniel Jacobowitz
@ 2004-12-01 21:10 ` Ian Lance Taylor
0 siblings, 0 replies; 2+ messages in thread
From: Ian Lance Taylor @ 2004-12-01 21:10 UTC (permalink / raw)
To: Daniel Jacobowitz; +Cc: binutils
Daniel Jacobowitz <drow@false.org> writes:
> 2004-12-01 Daniel Jacobowitz <dan@codesourcery.com>
>
> * ld-selective/selective.exp: Use -print-libgcc-file-name for
> ARM and v850 also.
This is OK to install.
Ian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-12-01 21:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-12-01 21:06 RFA: Fix ARM testsuite selective.exp with installed toolchain Daniel Jacobowitz
2004-12-01 21:10 ` Ian Lance Taylor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).