From: Andreas Schwab <schwab@suse.de>
To: Peter Barada <peter@the-baradas.com>
Cc: binutils@sources.redhat.com
Subject: Re: [PATCH]: Support new ColdFire variants
Date: Sun, 20 Jun 2004 19:33:00 -0000 [thread overview]
Message-ID: <m33c4qt467.fsf@whitebox.m5r.de> (raw)
In-Reply-To: <20040423190358.06186990F2@baradas.org> (Peter Barada's message of "Fri, 23 Apr 2004 15:03:58 -0400 (EDT)")
Peter Barada <peter@the-baradas.com> writes:
> 2004-04-23 Peter Barada <peter@the-baradas.com>
> * config/tc-m68k.c: Add find_cf_chip to print list of valid
> chips for invalid coldfire instructions, rename selectors
> for ColdFire sub-variants, add 521x,5249,547x,548x and aliases,
> add current_chip to track which chip is referred to(including save/restore),
> use current_chip to select control registers, not current_arch.
> (md_show_usage)Add new chips.
This broke .chip:
$ cat chip.s
.chip 68060
.chip 68k
$ m68k-linux-as chip.s
chip.s: Assembler messages:
chip.s:2: Internal error, aborting at ../../binutils/gas/config/tc-m68k.c line 4395 in select_control_regs
Please report this bug.
I've checked in this fix as obvious.
2004-06-20 Andreas Schwab <schwab@suse.de>
* config/tc-m68k.c (mri_chip): Replace current_chip, not augment.
(md_parse_option): Likewise.
--- gas/config/tc-m68k.c 28 May 2004 23:55:36 +0200 1.54
+++ gas/config/tc-m68k.c 20 Jun 2004 21:16:06 +0200
@@ -5471,7 +5471,7 @@ mri_chip ()
else
current_architecture &= m68881 | m68851;
current_architecture |= archs[i].arch;
- current_chip |= archs[i].chip;
+ current_chip = archs[i].chip;
while (*input_line_pointer == '/')
{
@@ -7264,7 +7264,7 @@ md_parse_option (c, arg)
{
current_architecture &= ~m68000up;
current_architecture |= arch;
- current_chip |= archs[i].chip;
+ current_chip = archs[i].chip;
}
else if (arch == m68881)
{
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2004-06-20 19:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-23 19:06 Peter Barada
2004-04-30 21:50 ` Ping: " Peter Barada
2004-05-05 14:33 ` Nick Clifton
2004-05-05 15:16 ` Peter Barada
2004-06-20 19:33 ` Andreas Schwab [this message]
2004-04-23 19:15 Peter Barada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m33c4qt467.fsf@whitebox.m5r.de \
--to=schwab@suse.de \
--cc=binutils@sources.redhat.com \
--cc=peter@the-baradas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).