From: Nick Clifton <nickc@redhat.com>
To: Salvador Eduardo Tropea <salvador@inti.gov.ar>
Cc: binutils@sources.redhat.com
Subject: Re: RFC objdump new feature to generate debug info using ctags style
Date: Wed, 14 May 2003 07:05:00 -0000 [thread overview]
Message-ID: <m33cji5811.fsf@redhat.com> (raw)
In-Reply-To: <3EC150E0.5070102@inti.gov.ar> (Salvador Eduardo Tropea's message of "Tue, 13 May 2003 17:09:04 -0300")
Hi Salvador,
>> * Please try to follow the GNU coding standard. (In the patch there
>> are several comments that ought to be reformatted to include a
>> terminating period followed by two spaces. Also there are places
>> where there is no space between a function name and its opening
>> parenthesis).
>>
> Can I use some automatic tool like indent? In this case: where can I
> find the indent parameters? I know indent have a "GNU" mode, is that
> ok?
You can use tools like this, but they will not catch all of the
formatting requirements. So it is still a good idea to visually check
over the code yourself. In particular a patch should blend in to the
code surrounding it and not stand out as being formatted in a
different manner.
Cheers
Nick
next prev parent reply other threads:[~2003-05-14 7:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-02 15:50 Salvador Eduardo Tropea
2003-05-12 11:27 ` Nick Clifton
2003-05-13 20:09 ` Salvador Eduardo Tropea
2003-05-13 20:35 ` Salvador Eduardo Tropea
2003-05-14 7:05 ` Nick Clifton [this message]
2003-07-21 19:32 ` Salvador Eduardo Tropea
2003-07-22 13:34 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m33cji5811.fsf@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sources.redhat.com \
--cc=salvador@inti.gov.ar \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).