From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19340 invoked by alias); 14 May 2003 07:05:41 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 19285 invoked from network); 14 May 2003 07:05:40 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 14 May 2003 07:05:40 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h4E75eH04335 for ; Wed, 14 May 2003 03:05:40 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h4E75eI21731; Wed, 14 May 2003 03:05:40 -0400 Received: from localhost.localdomain.redhat.com (vpn50-5.rdu.redhat.com [172.16.50.5]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h4E75TQ30428; Wed, 14 May 2003 03:05:33 -0400 To: Salvador Eduardo Tropea Cc: binutils@sources.redhat.com Subject: Re: RFC objdump new feature to generate debug info using ctags style References: <3EB293A4.30103@inti.gov.ar> <3EC150E0.5070102@inti.gov.ar> From: Nick Clifton Date: Wed, 14 May 2003 07:05:00 -0000 In-Reply-To: <3EC150E0.5070102@inti.gov.ar> (Salvador Eduardo Tropea's message of "Tue, 13 May 2003 17:09:04 -0300") Message-ID: User-Agent: Gnus/5.1001 (Gnus v5.10.1) Emacs/21.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-05/txt/msg00420.txt.bz2 Hi Salvador, >> * Please try to follow the GNU coding standard. (In the patch there >> are several comments that ought to be reformatted to include a >> terminating period followed by two spaces. Also there are places >> where there is no space between a function name and its opening >> parenthesis). >> > Can I use some automatic tool like indent? In this case: where can I > find the indent parameters? I know indent have a "GNU" mode, is that > ok? You can use tools like this, but they will not catch all of the formatting requirements. So it is still a good idea to visually check over the code yourself. In particular a patch should blend in to the code surrounding it and not stand out as being formatted in a different manner. Cheers Nick