From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22226 invoked by alias); 3 Mar 2005 17:21:40 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 22206 invoked from network); 3 Mar 2005 17:21:34 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 3 Mar 2005 17:21:34 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j23HLYlB027138 for ; Thu, 3 Mar 2005 12:21:34 -0500 Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j23HLXK31949 for ; Thu, 3 Mar 2005 12:21:33 -0500 Received: from localhost.localdomain.redhat.com (vpnuser1.surrey.redhat.com [172.16.9.1]) by pobox.surrey.redhat.com (8.12.8/8.12.8) with ESMTP id j23HLWZc006654 for ; Thu, 3 Mar 2005 17:21:32 GMT To: binutils@sources.redhat.com Subject: Remove redundant code in gas/expr.c From: Nick Clifton Date: Thu, 03 Mar 2005 17:21:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2005-03/txt/msg00115.txt.bz2 Hi Guys, Whilst investigating another problem I am across the fact that we have a small piece of redundant code in expr.c:operand(). It was enclosed inside a #ifdef RELAX_PAREN_GROUPING...#endif which is not defined by any target. So I am applying this patch to remove it. Cheers Nick gas/ChangeLog 2005-03-03 Nick Clifton * expr.c (operand): Remove redundant code enclosed by #ifdef RELAX_PAREN_GROUPING....#endif. Index: gas/expr.c =================================================================== RCS file: /cvs/src/src/gas/expr.c,v retrieving revision 1.54 diff -c -3 -p -r1.54 expr.c *** gas/expr.c 1 Mar 2005 22:35:21 -0000 1.54 --- gas/expr.c 3 Mar 2005 17:17:15 -0000 *************** operand (expressionS *expressionP) *** 977,988 **** /* expression () will pass trailing whitespace. */ if ((c == '(' && *input_line_pointer != ')') || (c == '[' && *input_line_pointer != ']')) ! { ! #ifdef RELAX_PAREN_GROUPING ! if (c != '(') ! #endif ! as_bad (_("missing '%c'"), c == '(' ? ')' : ']'); ! } else input_line_pointer++; SKIP_WHITESPACE (); --- 977,983 ---- /* expression () will pass trailing whitespace. */ if ((c == '(' && *input_line_pointer != ')') || (c == '[' && *input_line_pointer != ']')) ! as_bad (_("missing '%c'"), c == '(' ? ')' : ']'); else input_line_pointer++; SKIP_WHITESPACE ();