From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-66561-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 17728 invoked by alias); 15 Jul 2010 08:11:17 -0000
Received: (qmail 17678 invoked by uid 22791); 15 Jul 2010 08:11:14 -0000
X-SWARE-Spam-Status: No, hits=-5.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Jul 2010 08:11:08 +0000
Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6F8B56J012563	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 15 Jul 2010 04:11:05 -0400
Received: from hase.home (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o6F8B3Vb011104;	Thu, 15 Jul 2010 04:11:04 -0400
From: Andreas Schwab <schwab@redhat.com>
To: David Stubbs <stubbs@IceraSemi.com>
Cc: binutils@sourceware.org
Subject: Re: VMA section overlap warnings for overlays
References: <4D60B0700D1DB54A8C0C6E9BE69163700E67DFD1@EXCHANGEVS.IceraSemi.local>	<20100421082441.GG3510@bubble.grove.modra.org>	<4D60B0700D1DB54A8C0C6E9BE69163700E7815C7@EXCHANGEVS.IceraSemi.local>	<20100422011106.GI3510@bubble.grove.modra.org>	<20100422015303.GK3510@bubble.grove.modra.org>	<4D60B0700D1DB54A8C0C6E9BE69163700E7F2F15@EXCHANGEVS.IceraSemi.local>	<20100424021750.GQ3510@bubble.grove.modra.org>
X-Yow: PEGGY FLEMING is stealing BASKET BALLS to feed the babies in VERMONT.
Date: Thu, 15 Jul 2010 08:11:00 -0000
In-Reply-To: <20100424021750.GQ3510@bubble.grove.modra.org> (Alan Modra's	message of "Sat, 24 Apr 2010 11:47:50 +0930")
Message-ID: <m37hkxxizs.fsf@hase.home>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
X-SW-Source: 2010-07/txt/msg00174.txt.bz2

Alan Modra <amodra@gmail.com> writes:

> @@ -5837,7 +5853,8 @@ copy_elf_program_header (bfd *ibfd, bfd 
>  	   section = section->next)
>  	{
>  	  this_hdr = &(elf_section_data(section)->this_hdr);
> -	  if (ELF_IS_SECTION_IN_SEGMENT_FILE (this_hdr, segment))
> +	  if (this_hdr->sh_size != 0
> +	      && ELF_SECTION_IN_SEGMENT (this_hdr, segment))

Why can't an empty section never be part of a segment?

Andreas.

-- 
Andreas Schwab, schwab@redhat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84  5EC7 45C6 250E 6F00 984E
"And now for something completely different."