public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* PATCH: Do not create __exidx_{start,end} for ld -r
@ 2004-10-27  6:06 Mark Mitchell
  2004-10-27  6:32 ` Ian Lance Taylor
  0 siblings, 1 reply; 2+ messages in thread
From: Mark Mitchell @ 2004-10-27  6:06 UTC (permalink / raw)
  To: binutils; +Cc: paul


The armelf.sh configuration is presently creating the
__exidx_{start,end} even when not relocating, e.g., when doing "ld
-r".  That's incorrect; these symbols should only be defined when
creating a shared library or executable.

OK to commit?

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com

2004-10-26  Mark Mitchell  <mark@codesourcery.com>

	* emulparams/armelf.sh (OTHER_READONLY_SECTIONS): Do not emit
	__exidx_{start,end} when not relocating.

Index: emulparams/armelf.sh
===================================================================
RCS file: /cvs/src/src/ld/emulparams/armelf.sh,v
retrieving revision 1.13
diff -c -5 -p -r1.13 armelf.sh
*** emulparams/armelf.sh	1 Oct 2004 12:59:34 -0000	1.13
--- emulparams/armelf.sh	27 Oct 2004 06:02:14 -0000
*************** OTHER_TEXT_SECTIONS='*(.glue_7t) *(.glue
*** 10,22 ****
  OTHER_BSS_SYMBOLS='__bss_start__ = .;'
  OTHER_BSS_END_SYMBOLS='_bss_end__ = . ; __bss_end__ = . ; __end__ = . ;'
  OTHER_SECTIONS='.note.gnu.arm.ident 0 : { KEEP (*(.note.gnu.arm.ident)) }'
  OTHER_READONLY_SECTIONS="
    .ARM.extab ${RELOCATING-0} : { *(.ARM.extab${RELOCATING+* .gnu.linkonce.armextab.*}) }
!   __exidx_start = .;
    .ARM.exidx ${RELOCATING-0} : { *(.ARM.exidx${RELOCATING+* .gnu.linkonce.armexidx.*}) }
!   __exidx_end = .;"
  
  DATA_START_SYMBOLS='__data_start = . ;';
  
  GENERATE_SHLIB_SCRIPT=yes
  
--- 10,22 ----
  OTHER_BSS_SYMBOLS='__bss_start__ = .;'
  OTHER_BSS_END_SYMBOLS='_bss_end__ = . ; __bss_end__ = . ; __end__ = . ;'
  OTHER_SECTIONS='.note.gnu.arm.ident 0 : { KEEP (*(.note.gnu.arm.ident)) }'
  OTHER_READONLY_SECTIONS="
    .ARM.extab ${RELOCATING-0} : { *(.ARM.extab${RELOCATING+* .gnu.linkonce.armextab.*}) }
!   ${RELOCATING+ __exidx_start = .; }
    .ARM.exidx ${RELOCATING-0} : { *(.ARM.exidx${RELOCATING+* .gnu.linkonce.armexidx.*}) }
!   ${RELOCATING+ __exidx_end = .; }"
  
  DATA_START_SYMBOLS='__data_start = . ;';
  
  GENERATE_SHLIB_SCRIPT=yes
  

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: PATCH: Do not create __exidx_{start,end} for ld -r
  2004-10-27  6:06 PATCH: Do not create __exidx_{start,end} for ld -r Mark Mitchell
@ 2004-10-27  6:32 ` Ian Lance Taylor
  0 siblings, 0 replies; 2+ messages in thread
From: Ian Lance Taylor @ 2004-10-27  6:32 UTC (permalink / raw)
  To: mark; +Cc: binutils, paul

Mark Mitchell <mark@codesourcery.com> writes:

> 2004-10-26  Mark Mitchell  <mark@codesourcery.com>
> 
> 	* emulparams/armelf.sh (OTHER_READONLY_SECTIONS): Do not emit
> 	__exidx_{start,end} when not relocating.

OK.

Ian

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-10-27  6:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-27  6:06 PATCH: Do not create __exidx_{start,end} for ld -r Mark Mitchell
2004-10-27  6:32 ` Ian Lance Taylor

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).