From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-46411-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 7806 invoked by alias); 14 Jun 2006 00:41:15 -0000
Received: (qmail 7797 invoked by uid 22791); 14 Jun 2006 00:41:15 -0000
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.12)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 14 Jun 2006 00:41:13 +0000
Received: from lois.corp.google.com (lois.corp.google.com [172.24.0.50]) 	by smtp-out.google.com with ESMTP id k5E0exZx012979; 	Tue, 13 Jun 2006 17:40:59 -0700
Received: from smtp.google.com (mordor.corp.google.com [192.168.15.226]) 	by lois.corp.google.com with ESMTP id k5E0dQZL021818 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); 	Tue, 13 Jun 2006 17:39:26 -0700
Received: from localhost.localdomain.google.com (181.sub-70-199-137.myvzw.com [70.199.137.181]) 	(authenticated bits=0) 	by smtp.google.com (8.13.6/8.13.6) with ESMTP id k5E0dMiT009378 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); 	Tue, 13 Jun 2006 17:39:25 -0700
To: Julian Brown <julian@codesourcery.com>
Cc: binutils@sourceware.org, GCC Patches <gcc-patches@gcc.gnu.org>,         DJ Delorie <dj@redhat.com>
Subject: Re: [PATCH, libiberty] Fix segfault in floatformat.c:get_field on 64-bit  hosts
References: <4489A779.2080101@codesourcery.com> 	<m3slm9c9j4.fsf@dhcp-172-24-103-66.corp.google.com> 	<448EEBB4.3090503@codesourcery.com>
From: Ian Lance Taylor <iant@google.com>
Date: Wed, 14 Jun 2006 02:44:00 -0000
In-Reply-To: <448EEBB4.3090503@codesourcery.com>
Message-ID: <m3bqsw1sg7.fsf@localhost.localdomain>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.4
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
X-SW-Source: 2006-06/txt/msg00220.txt.bz2

Julian Brown <julian@codesourcery.com> writes:

> So, I'll remove that bit and do the following...
> 
> > Please compile the file as a standalone program with -DIEEE_DEBUG to
> > make sure those tests still work.  Ideally on both a big- and
> > little-endian system, if possible.

This patch is OK with that change, assuming the tests pass.

Bonus points if you rewrite put_field.

Thanks.

Ian