From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26539 invoked by alias); 11 Feb 2005 09:34:26 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 26479 invoked from network); 11 Feb 2005 09:34:17 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 11 Feb 2005 09:34:17 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j1B9YBvg026828 for ; Fri, 11 Feb 2005 04:34:16 -0500 Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j1B9YBO01550; Fri, 11 Feb 2005 04:34:11 -0500 Received: from localhost.localdomain.redhat.com (vpnuser5.surrey.redhat.com [172.16.9.5]) by pobox.surrey.redhat.com (8.12.8/8.12.8) with ESMTP id j1B9Y9MR005314; Fri, 11 Feb 2005 09:34:10 GMT To: paul@codesourcery.com Cc: binutils@sources.redhat.com Subject: Re: [patch] SymbianOS Arm executables From: Nick Clifton Date: Fri, 11 Feb 2005 15:15:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2005-02/txt/msg00234.txt.bz2 Hi Paul, > 2005-02-10 Paul Brook > > * elf-bfd.h (struct elf_link_hash_table): Add exec_reloc_p. > * elf.c (_bfd_elf_link_hash_table_init): Initialize it. > * elflink.c (bfd_elf_link_record_dynamic_symbol): Create local dynamic > symbols in relocatable executables. > (bfd_elf_record_link_assignment): Create dynamic section symbols in > relocatable executables. > (_bfd_elf_link_renumber_dynsyms): Ditto. > (bfd_elf_final_link): Ditto. > * elf32-arm.c (elf32_arm_final_link_relocate): Copy absolute > relocations into relocatable executables. > (elf32_arm_check_relocs): Crate dynamic sections for relocatale ^^^^^^^^^ relocatable ? > executables. Also copy absolute relocations. > (elf32_arm_adjust_dynamic_symbol): Don't create copy relocations > in relocatable executables. > (allocate_dynrelocs): Copy relocations for relocatable executables. > Output dynamic symbols for symbols defined in linker scripts. Approved - please apply. But... ------------------------------------------------------------------------ + /* True if This target has relocatable executables, so needs dynamic + section symbols. */ + bfd_boolean exec_reloc_p; There is no need for a capital T on the word "This". Also - this is a just personal thing, not a requirement - I really hate the use of ..._p to indicate a boolean value. We are coding in C here not lisp and I think that we should try to drop hold overs from that language. Thus I would have called this variable: "is_relocatable_executable" or "executable_needs_dynamic_section_syms". ------------------------------------------------------------------------ /* When generating a shared object, these relocations are copied into the output file to be resolved at run time. */ - if (info->shared + if ((info->shared || globals->root.exec_reloc_p) Since you are updating the if() statement, you should update the comment describing it. Cheers Nick