From: Ian Lance Taylor <ian@airs.com>
To: "Dave Korn" <dave.korn@artimi.com>
Cc: "'H. J. Lu'" <hjl@lucon.org>,
"'Andrew Pinski'" <pinskia@physics.uc.edu>,
"'Paul Schlie'" <schlie@comcast.net>,
"'Kaveh R. Ghazi'" <ghazi@caip.rutgers.edu>,
<binutils@sources.redhat.com>, <gcc-patches@gcc.gnu.org>,
<amodra@bigpond.net.au>, <dj@redhat.com>
Subject: Re: Remove parameter names from libiberty.h
Date: Thu, 14 Apr 2005 20:58:00 -0000 [thread overview]
Message-ID: <m3ekddf53a.fsf@gossamer.airs.com> (raw)
In-Reply-To: <SERRANOJIc0y82gv5Gm00000163@SERRANO.CAM.ARTIMI.COM>
"Dave Korn" <dave.korn@artimi.com> writes:
> My two cents is that it's asking for trouble to #define an all-lower case
> word, particularly an extremely common one such as 'mode'. I had a quick
> grep but couldn't figure out where it's coming from. I guess that sort of
> thing is vaguely-ok-if-innately-fragile if it's being defined by the
> m88k-dis source file, but if there's a public header in either binutils or
> libiberty that's doing it, I'd think it ought to change.
It was coming from include/opcode/m88k.h, and it's already been fixed
there by Paul Brook.
Still, I don't think we should use parameter names for well understood
functions. There is no ideal policy here, but omitting unnecessary
parameter names seems to me to be wise regardless.
Ian
next prev parent reply other threads:[~2005-04-14 20:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-14 15:21 Paul Schlie
2005-04-14 16:18 ` Andrew Pinski
2005-04-14 17:18 ` H. J. Lu
2005-04-14 17:50 ` Dave Korn
2005-04-14 20:58 ` Ian Lance Taylor [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-04-14 10:20 Marc Espie
2005-04-15 7:34 ` Thorsten Glaser
2005-04-12 1:21 libiberty.h Alan Modra
2005-04-13 23:57 ` Remove parameter names from libiberty.h Kaveh R. Ghazi
2005-04-14 1:13 ` Ian Lance Taylor
2005-04-14 7:42 ` Thorsten Glaser
2005-04-14 12:41 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ekddf53a.fsf@gossamer.airs.com \
--to=ian@airs.com \
--cc=amodra@bigpond.net.au \
--cc=binutils@sources.redhat.com \
--cc=dave.korn@artimi.com \
--cc=dj@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ghazi@caip.rutgers.edu \
--cc=hjl@lucon.org \
--cc=pinskia@physics.uc.edu \
--cc=schlie@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).