From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1581 invoked by alias); 14 Apr 2005 20:58:54 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 1118 invoked from network); 14 Apr 2005 20:58:45 -0000 Received: from unknown (205.217.158.180) by sourceware.org with QMTP; 14 Apr 2005 20:58:45 -0000 Received: (qmail 20639 invoked by uid 10); 14 Apr 2005 20:58:45 -0000 Received: (qmail 2016 invoked by uid 500); 14 Apr 2005 20:58:33 -0000 Mail-Followup-To: hjl@lucon.org, pinskia@physics.uc.edu, schlie@comcast.net, ghazi@caip.rutgers.edu, binutils@sources.redhat.com, gcc-patches@gcc.gnu.org, amodra@bigpond.net.au, dj@redhat.com, dave.korn@artimi.com To: "Dave Korn" Cc: "'H. J. Lu'" , "'Andrew Pinski'" , "'Paul Schlie'" , "'Kaveh R. Ghazi'" , , , , Subject: Re: Remove parameter names from libiberty.h References: From: Ian Lance Taylor Date: Thu, 14 Apr 2005 20:58:00 -0000 In-Reply-To: Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2005-04/txt/msg00393.txt.bz2 "Dave Korn" writes: > My two cents is that it's asking for trouble to #define an all-lower case > word, particularly an extremely common one such as 'mode'. I had a quick > grep but couldn't figure out where it's coming from. I guess that sort of > thing is vaguely-ok-if-innately-fragile if it's being defined by the > m88k-dis source file, but if there's a public header in either binutils or > libiberty that's doing it, I'd think it ought to change. It was coming from include/opcode/m88k.h, and it's already been fixed there by Paul Brook. Still, I don't think we should use parameter names for well understood functions. There is no ideal policy here, but omitting unnecessary parameter names seems to me to be wise regardless. Ian