From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24173 invoked by alias); 21 Jan 2005 02:00:52 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 24080 invoked from network); 21 Jan 2005 02:00:46 -0000 Received: from unknown (205.217.158.180) by sourceware.org with QMTP; 21 Jan 2005 02:00:46 -0000 Received: (qmail 25360 invoked by uid 10); 21 Jan 2005 02:00:45 -0000 Received: (qmail 18863 invoked by uid 500); 21 Jan 2005 02:00:36 -0000 Mail-Followup-To: binutils@sources.redhat.com, bje@au1.ibm.com To: "Ben Elliston" Cc: binutils@sources.redhat.com Subject: Re: gas cleanups References: <20050120235805.GA15552@namadgi> From: Ian Lance Taylor Date: Fri, 21 Jan 2005 02:00:00 -0000 In-Reply-To: <20050120235805.GA15552@namadgi> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2005-01/txt/msg00319.txt.bz2 "Ben Elliston" writes: > -#if 0 > - /* Alpha-OSF1 adds "the offset of saved $a0 from $sp", according to > - Sandro. I don't yet know where this value should be stored, if > - anywhere. */ > - demand_empty_rest_of_line (); > -#else > s_ignore (42); > -#endif You need to keep this comment, to explain why we aren't calling demand_empty_rest_of_line(). > -#if 0 > - /* This test is triggered inappropriately for the SH. */ > - if (fixp->fx_where + fixp->fx_size > - > fixp->fx_frag->fr_fix + fixp->fx_frag->fr_offset) > - abort (); > -#endif Anybody know what's up with this? That test looks pretty darn good to me, and anything which fails it looks pretty darn suspect. This patch is OK if you keep the comment in the first paragraph above, and don't remove the #if 0 code in the second paragraph above. Ian