Fix to elf common tests

Fix to elf common tests

[Nick Clifton]

Hi HJ,

  I would like to make a small change to the elf common tests you
  created.  The patch below adds an explicit "aligned(1)" attribute to
  the declaration of foo1 in common1b.c.  This is because not all
  ports default to an alignment of 1 for their commons.  The ARM port
  for example defaults to an alignment of 4.

  Do you have any problems with this ?  There are no regressions in
  the x86 Linux port with this patch applied.

Cheers
        Nick

2003-04-21  Nick Clifton  <nickc@redhat.com>

	* ld-elfcomm/common1b.c (foo1): Add an explicit alignment for
	the foo1 array.

Index: ld/testsuite/ld-elfcomm/common1b.c
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-elfcomm/common1b.c,v
retrieving revision 1.1
diff -c -3 -p -w -r1.1 common1b.c
*** ld/testsuite/ld-elfcomm/common1b.c	15 Apr 2003 09:38:10 -0000	1.1
--- ld/testsuite/ld-elfcomm/common1b.c	21 Apr 2003 09:27:40 -0000
***************
*** 1,3 ****
  static char dummy1 = 'X';
! char foo1 [] = "Aligned at odd byte.";
  char foo2 [4];
--- 1,3 ----
  static char dummy1 = 'X';
! char foo1 []   __attribute__((aligned(1))) = "Aligned at odd byte.";
  char foo2 [4];

Re: Fix to elf common tests

[H. J. Lu]

On Mon, Apr 21, 2003 at 10:29:40AM +0100, Nick Clifton wrote:
> Hi HJ,
> 
>   I would like to make a small change to the elf common tests you
>   created.  The patch below adds an explicit "aligned(1)" attribute to
>   the declaration of foo1 in common1b.c.  This is because not all
>   ports default to an alignment of 1 for their commons.  The ARM port
>   for example defaults to an alignment of 4.
> 
>   Do you have any problems with this ?  There are no regressions in
>   the x86 Linux port with this patch applied.
> 

Looks OK to me.


H.J.

Re: Fix to elf common tests

[H. J. Lu]

On Mon, Apr 21, 2003 at 07:36:20AM -0700, H. J. Lu wrote:
> On Mon, Apr 21, 2003 at 10:29:40AM +0100, Nick Clifton wrote:
> > Hi HJ,
> > 
> >   I would like to make a small change to the elf common tests you
> >   created.  The patch below adds an explicit "aligned(1)" attribute to
> >   the declaration of foo1 in common1b.c.  This is because not all
> >   ports default to an alignment of 1 for their commons.  The ARM port
> >   for example defaults to an alignment of 4.
> > 
> >   Do you have any problems with this ?  There are no regressions in
> >   the x86 Linux port with this patch applied.
> > 
> 
> Looks OK to me.
> 

My second thought. Does my patch

http://sources.redhat.com/ml/binutils/2003-04/msg00352.html

work for you?


H.J.

Re: Fix to elf common tests

[Nick Clifton]

Hi H.J.

> > >   Do you have any problems with this ?  There are no regressions in
> > >   the x86 Linux port with this patch applied.
> > > 
> > 
> > Looks OK to me.
> > 
> 
> My second thought. Does my patch
> 
> http://sources.redhat.com/ml/binutils/2003-04/msg00352.html
> 
> work for you?

Yes it does.  Please apply that patch instead.

Cheers
        Nick