From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>,
GDB Patches <gdb-patches@sourceware.org>,
Binutils Development <binutils@sourceware.org>,
"H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH/RFC 02/02 v2] Refactor PRPSINFO handling on GDB
Date: Fri, 11 Jan 2013 17:03:00 -0000 [thread overview]
Message-ID: <m3libzzm7u.fsf@redhat.com> (raw)
In-Reply-To: <50F02661.8020400@redhat.com> (Pedro Alves's message of "Fri, 11 Jan 2013 14:49:05 +0000")
On Friday, January 11 2013, Pedro Alves wrote:
> On 01/11/2013 03:53 AM, Sergio Durigan Junior wrote:
>>>> + /* Generating and copying the program's arguments. `get_inferior_args'
>>>> + may throw, but we want to continue the execution anyway. */
>>>> + TRY_CATCH (ex, RETURN_MASK_ERROR)
>>>> + {
>>>> + infargs = get_inferior_args ();
>>>> + }
>>>> +
>>>
>>> Hmm? We were not doing that before. What exception is that?
>>
>> `get_inferior_args' calls `construct_inferior_arguments', which can call
>> `error' in an specific scenario (not STARTUP_WITH_SHELL, arguments that
>> contain spaces).
>
> This is an example of something that should be split into
> its own change, along with its own rationale. This is
> independent of any refactoring of PRPSINFO handling.
> We're already calling get_inferior_args nowadays, and I don't
> ever remember this error being reported as a problem.
My first version of the patch didn't contain the TRY_CATCH part. It was
Jan who made this suggestion, and I thought it made sense.
I really think a TRY_CATCH does not cause any harm here, but if you
insist, I can easily remove it from the patch.
--
Sergio
next prev parent reply other threads:[~2013-01-11 17:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 4:09 Sergio Durigan Junior
2012-12-18 17:16 ` Jan Kratochvil
2012-12-25 17:38 ` Sergio Durigan Junior
2012-12-30 1:53 ` Sergio Durigan Junior
2012-12-31 19:41 ` Jan Kratochvil
2013-01-04 4:41 ` Sergio Durigan Junior
2013-01-10 18:44 ` Pedro Alves
2013-01-11 3:53 ` Sergio Durigan Junior
2013-01-11 14:49 ` Pedro Alves
2013-01-11 17:03 ` Sergio Durigan Junior [this message]
2013-01-11 17:11 ` Jan Kratochvil
2013-01-11 17:48 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3libzzm7u.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=jan.kratochvil@redhat.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).