From: Nick Clifton <nickc@cambridge.redhat.com>
To: Tracy Kuhrt <Tracy.Kuhrt@microchip.com>
Cc: binutils List <binutils@sourceware.cygnus.com>
Subject: Re: obj_coff_loc Internal Error
Date: Mon, 10 Sep 2001 10:37:00 -0000 [thread overview]
Message-ID: <m3n143hrss.fsf@north-pole.nickc.cambridge.redhat.com> (raw)
In-Reply-To: <3B99142C.5F37716B@microchip.com>
Hi Tracy,
> Following is a patch that I think solves the problems.
First of all - do you have a binutils copyright assignment on file
with the FSF ? Without such an assignment we cannot accept your
patch. (I know that the patch is small, but I consider it to be
non-trivial and not-obvious, so we do need the assignment).
> + /* Skip the comma if it exists; otherwise, give warning. */
> + if (*input_line_pointer == ',')
> + input_line_pointer++;
> + else
> + as_warn (_("missing comma assumed."));
Secondly I am not sure that it is correct to issue a warning if the
comma is missing. The code before your patch parsed the expression
without requiring an line number and I feel that we should continue to
support that behaviour unless there is a good reason not too.
> NOTE: I have moved the add_lineno before the listing code. I am
> not sure if this is correct.
This does look wrong, or at least different. The listing code does
change the variable 'lineno' which is used by the call to add_lineno()
so the behaviour will change. Why did you move the call ? Were you
detecting incorrect line numbers in your output ?
Finally, since you are changing the behaviour of the .loc directive, it
would be great if you could add some documentation about it to the
assembler doc file (gas/doc/as.texinfo). This is optional, but nice.
Cheers
Nick
next prev parent reply other threads:[~2001-09-10 10:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-07 11:38 Tracy Kuhrt
2001-09-10 10:37 ` Nick Clifton [this message]
2001-09-10 10:54 ` Tracy Kuhrt
2001-09-10 13:21 ` Nick Clifton
2001-09-10 13:35 ` Tracy Kuhrt
2001-09-10 15:43 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3n143hrss.fsf@north-pole.nickc.cambridge.redhat.com \
--to=nickc@cambridge.redhat.com \
--cc=Tracy.Kuhrt@microchip.com \
--cc=binutils@sourceware.cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).