From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8429 invoked by alias); 15 Feb 2005 14:30:43 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 8360 invoked from network); 15 Feb 2005 14:30:36 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 15 Feb 2005 14:30:36 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j1FEUatU003513 for ; Tue, 15 Feb 2005 09:30:36 -0500 Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j1FEUZO09489 for ; Tue, 15 Feb 2005 09:30:35 -0500 Received: from localhost.localdomain.redhat.com (vpnuser4.surrey.redhat.com [172.16.9.4]) by pobox.surrey.redhat.com (8.12.8/8.12.8) with ESMTP id j1FEUYMR011382 for ; Tue, 15 Feb 2005 14:30:34 GMT To: binutils@sources.redhat.com Subject: Fix for compile time warning in binutils/nlmconv.c From: Nick Clifton Date: Tue, 15 Feb 2005 18:17:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2005-02/txt/msg00335.txt.bz2 Hi Guys, I am going to apply the patch below to fix a compile time warning when building nlmconv.c, although I am not sure if this is the proper way to fix the problem. The reason is that I am not sure why the parameterless prototype for localtime() is included at all. Presumably there are build environments out there where this function is not prototyped, or the header containing the prototype is not pulled in. To me this sounds like a configure problem, but for now I am keeping things simple. Cheers Nick binutils/ChangeLog 2005-02-15 Nick Clifton * nlmconv.c: Provide a full prototype for the localtime() function in order to avoid a compile time warning. Index: binutils/nlmconv.c =================================================================== RCS file: /cvs/src/src/binutils/nlmconv.c,v retrieving revision 1.21 diff -c -3 -p -r1.21 nlmconv.c *** binutils/nlmconv.c 4 Jan 2005 15:51:47 -0000 1.21 --- binutils/nlmconv.c 15 Feb 2005 14:20:18 -0000 *************** *** 59,65 **** extern char *strerror (int); #ifndef localtime ! extern struct tm *localtime (); #endif #ifndef SEEK_SET --- 59,65 ---- extern char *strerror (int); #ifndef localtime ! extern struct tm *localtime (const time_t *); #endif #ifndef SEEK_SET