From: Ian Lance Taylor <ian@airs.com>
To: dj@redhat.com
Cc: binutils@sourceware.org
Subject: Increment
Date: Sat, 27 May 2006 16:33:00 -0000 [thread overview]
Message-ID: <m3u07c5uig.fsf@gossamer.airs.com> (raw)
bfd_hash_lookup in bfd/hash.c has an incorrectly indented and
misplaced increment of table->count:
if (copy)
{
char *new;
table->count ++;
new = objalloc_alloc ((struct objalloc *) table->memory, len + 1);
if (!new)
{
bfd_set_error (bfd_error_no_memory);
return NULL;
}
memcpy (new, string, len + 1);
string = new;
}
Shouldn't that be incremented regardless of whether COPY is true?
Bug or error?
Ian
next reply other threads:[~2006-05-26 21:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-27 16:33 Ian Lance Taylor [this message]
2006-06-06 4:30 ` Increment Alan Modra
2006-06-06 10:52 ` Increment Alan Modra
2006-06-07 1:40 ` Increment Thiemo Seufer
2006-06-07 5:02 ` Increment Alan Modra
2006-06-09 13:42 ` Increment Andreas Schwab
2006-06-12 4:32 ` Increment Alan Modra
2006-06-12 10:50 ` Increment Andreas Schwab
2006-06-12 18:53 ` Increment DJ Delorie
2006-06-12 19:13 ` Increment H. J. Lu
2006-06-12 23:55 ` Increment Andreas Schwab
2006-06-13 1:11 ` Increment Alan Modra
2006-06-13 10:52 ` Increment Andreas Schwab
2006-06-13 8:53 ` Increment H. J. Lu
2006-06-13 13:49 ` Increment Andreas Schwab
2006-06-13 14:49 ` Increment Alan Modra
2006-06-13 14:52 ` Increment Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3u07c5uig.fsf@gossamer.airs.com \
--to=ian@airs.com \
--cc=binutils@sourceware.org \
--cc=dj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).