From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-46155-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 6572 invoked by alias); 26 May 2006 21:48:47 -0000
Received: (qmail 6541 invoked by uid 22791); 26 May 2006 21:48:45 -0000
X-Spam-Check-By: sourceware.org
Received: from yosemite.airs.com (HELO yosemite.airs.com) (205.217.158.180)     by sourceware.org (qpsmtpd/0.31) with SMTP; Fri, 26 May 2006 21:47:22 +0000
Received: (qmail 15440 invoked by uid 10); 26 May 2006 21:46:54 -0000
Received: (qmail 30468 invoked by uid 500); 26 May 2006 21:46:47 -0000
Mail-Followup-To: binutils@sourceware.org,   dj@redhat.com
To: dj@redhat.com
Cc: binutils@sourceware.org
Subject: Increment
From: Ian Lance Taylor <ian@airs.com>
Date: Sat, 27 May 2006 16:33:00 -0000
Message-ID: <m3u07c5uig.fsf@gossamer.airs.com>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.4
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-IsSubscribed: yes
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
X-SW-Source: 2006-05/txt/msg00481.txt.bz2

bfd_hash_lookup in bfd/hash.c has an incorrectly indented and
misplaced increment of table->count:

  if (copy)
    {
      char *new;
  table->count ++;

      new = objalloc_alloc ((struct objalloc *) table->memory, len + 1);
      if (!new)
	{
	  bfd_set_error (bfd_error_no_memory);
	  return NULL;
	}
      memcpy (new, string, len + 1);
      string = new;
    }

Shouldn't that be incremented regardless of whether COPY is true?

Bug or error?

Ian