From: Nick Clifton <nickc@redhat.com>
To: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
Cc: binutils@sources.redhat.com
Subject: Re: [PATCH] Code cleanup in bfd/reloc.c
Date: Fri, 16 May 2003 09:49:00 -0000 [thread overview]
Message-ID: <m3u1bvcjpn.fsf@redhat.com> (raw)
In-Reply-To: <20030514050641.GB8833@rembrandt.csv.ica.uni-stuttgart.de> (Thiemo Seufer's message of "Wed, 14 May 2003 07:06:41 +0200")
Hi Thiemo,
> this does a bit of code cleanup.
I am not sure of the point of this code cleanup.
It seems to me that the code is basically OK as it stands at the
moment. I appreciate that the patch reduces the number of lines and
variables when handling the 'special_function' but I do not like
eliminating the intialisation of 'flag' at the start of the function
and then being forced to add an else clause to the if statement at
line 1199, and an explicit return at 1907.
Cheers
Nick
prev parent reply other threads:[~2003-05-16 9:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-14 5:06 Thiemo Seufer
2003-05-16 9:49 ` Nick Clifton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3u1bvcjpn.fsf@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sources.redhat.com \
--cc=ica2_ts@csv.ica.uni-stuttgart.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).