Re: Binutils builds broken with -Werror

Re: Binutils builds broken with -Werror

[Nick Clifton]

Hi Guys,

  Jim's patch to prevent building the elf32-ia64.lo object file when
  producing a 32-bit BFD library missed one place - the
  _bfd_target_vector in bfd/targets.c.  So I am checking in the patch
  below to fix this.  Tested with a toolchain configured as
  "--enable-targets=all" but not with "--enable-64-bit-bfd".

Cheers
  Nick

bfd/ChangeLog
2005-03-24  Nick Clifton  <nickc@redhat.com>

	* targets.c (_bfd_target_vector): Only include the
	bfd_elf32_ia64_hpux_big_vec vector when building a 64-bit BFD with
	all targets enabled.

Index: bfd/targets.c
===================================================================
RCS file: /cvs/src/src/bfd/targets.c,v
retrieving revision 1.123
diff -c -3 -p -r1.123 targets.c
*** bfd/targets.c	1 Mar 2005 01:56:27 -0000	1.123
--- bfd/targets.c	24 Mar 2005 20:57:21 -0000
*************** static const bfd_target * const _bfd_tar
*** 867,873 ****
--- 867,875 ----
  #if 0
  	&bfd_elf32_ia64_big_vec,
  #endif
+ #ifdef BFD64
  	&bfd_elf32_ia64_hpux_big_vec,
+ #endif
  	&bfd_elf32_ip2k_vec,
  	&bfd_elf32_iq2000_vec,
  	&bfd_elf32_little_generic_vec,

Re: Binutils builds broken with -Werror

[Maciej W. Rozycki]

Hi Nick,

> > Prompted by Paul's notice I've checked automake documentation and done
> > some testing and he is indeed right.  But there's a working solution
> > actually suggested in automake info pages by using an auxiliary archive
> > library as detailed in the "Per-Object Flags Emulation" chapter there.
> 
> Would you care to submit a patch based on this feature ?

 I've run out of time for now, but I'm working on it.  I should have it 
ready after this weekend.

  Maciej

Re: Binutils builds broken with -Werror

[Nick Clifton]

Hi Maciej,

>  Prompted by Paul's notice I've checked automake documentation and done 
> some testing and he is indeed right.  But there's a working solution 
> actually suggested in automake info pages by using an auxiliary archive 
> library as detailed in the "Per-Object Flags Emulation" chapter there.

Would you care to submit a patch based on this feature ?

Cheers
   Nick

Re: Binutils builds broken with -Werror

[Nick Clifton]

Hi Maciej,

>  Prompted by Paul's notice I've checked automake documentation and done 
> some testing and he is indeed right.  But there's a working solution 
> actually suggested in automake info pages by using an auxiliary archive 
> library as detailed in the "Per-Object Flags Emulation" chapter there.

Would you care to submit a patch based on this feature ?

Cheers
   Nick

Re: Binutils builds broken with -Werror

[Nick Clifton]

Hi Andreas,

>>>NO_WERROR_COMPILE = $(COMPILE:Werror=Wno-error)
>>>do the desired trick?  
>>
>>Yes it will.  But is this construct also GNU Make specific ?

> It's POSIX.

Cool - in which case I guess we have to choose between this fix and a 
patch to the configure files.  I prefer patching Makefile.am since I 
have always had difficulty getting configure files to work.

Any objections to this patch then ?

+ # Disable -Werror, if it has been enabled, when building generated C 
source
+ # files since old versions of bison & yacc will produce working code which
+ # contain compile time warnings.
+ GENERATED_OFILES := $(GENERATED_CFILES:.c=.o)
+ NO_WERROR_COMPILE = $(COMPILE:Werror=Wno-error)
+ $(GENERATED_OFILES):
+ 	$(NO_WERROR_COMPILE) -c `basename $@ .o`.c

Cheers
   Nick

Re: Binutils builds broken with -Werror

[Andreas Schwab]

Nick Clifton <nickc@redhat.com> writes:

> Hi Dave,
>
>> + GENERATED_OFILES := $(GENERATED_CFILES:.c=.o)
>> + NO_WERROR_COMPILE = $(subst Werror,Wno-error,$(COMPILE))
>
>>   Hmm.  Won't this:
>> NO_WERROR_COMPILE = $(COMPILE:Werror=Wno-error)
>> do the desired trick?  
>
> Yes it will.  But is this construct also GNU Make specific ?

It's POSIX.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Binutils builds broken with -Werror

[Maciej W. Rozycki]

On Tue, 22 Mar 2005, Ian Lance Taylor wrote:

> > >  Well, since that -Werror is added by configure scripts in the first
> > > place, the most reasonable way of dealing with it is probably letting
> > > autoconf/automake do their jobs.  This flag could be substituted
> > > separately instead of along other flags in WARN_CFLAGS and then omitted
> > > selectively for generated files -- automake permits overriding default
> > > compilation flags in templates on a file by file basis.
> > 
> > Does it? I thought that only worked on a per-library basis.
> 
> No, you can override on a per-file basis using something like
>     foo_c_CFLAGS = 

 Prompted by Paul's notice I've checked automake documentation and done 
some testing and he is indeed right.  But there's a working solution 
actually suggested in automake info pages by using an auxiliary archive 
library as detailed in the "Per-Object Flags Emulation" chapter there.

  Maciej

Re: Binutils builds broken with -Werror

[Maciej W. Rozycki]

On Tue, 22 Mar 2005, Ian Lance Taylor wrote:

> > >  Well, since that -Werror is added by configure scripts in the first
> > > place, the most reasonable way of dealing with it is probably letting
> > > autoconf/automake do their jobs.  This flag could be substituted
> > > separately instead of along other flags in WARN_CFLAGS and then omitted
> > > selectively for generated files -- automake permits overriding default
> > > compilation flags in templates on a file by file basis.
> > 
> > Does it? I thought that only worked on a per-library basis.
> 
> No, you can override on a per-file basis using something like
>     foo_c_CFLAGS = 

 Prompted by Paul's notice I've checked automake documentation and done 
some testing and he is indeed right.  But there's a working solution 
actually suggested in automake info pages by using an auxiliary archive 
library as detailed in the "Per-Object Flags Emulation" chapter there.

  Maciej

Re: Binutils builds broken with -Werror

[Nick Clifton]

Hi Dave,

> + GENERATED_OFILES := $(GENERATED_CFILES:.c=.o)
> + NO_WERROR_COMPILE = $(subst Werror,Wno-error,$(COMPILE))

>   Hmm.  Won't this:
> 
> NO_WERROR_COMPILE = $(COMPILE:Werror=Wno-error)
> 
> do the desired trick?  

Yes it will.  But is this construct also GNU Make specific ?

Cheers
   Nick

Re: Binutils builds broken with -Werror

[Ian Lance Taylor]

Paul Brook <paul@codesourcery.com> writes:

> On Tuesday 22 March 2005 17:12, Maciej W. Rozycki wrote:
> > On Tue, 22 Mar 2005, Nick Clifton wrote:
> > > Hmm, well I am not wedded to GNU make, but do other versions of make
> > > support the $(subst FROM,TO,TEXT) function ?  If not then can anyone
> > > suggest a more portable way of achieving the same effect ?
> >
> >  Well, since that -Werror is added by configure scripts in the first
> > place, the most reasonable way of dealing with it is probably letting
> > autoconf/automake do their jobs.  This flag could be substituted
> > separately instead of along other flags in WARN_CFLAGS and then omitted
> > selectively for generated files -- automake permits overriding default
> > compilation flags in templates on a file by file basis.
> 
> Does it? I thought that only worked on a per-library basis.

No, you can override on a per-file basis using something like
    foo_c_CFLAGS = 

Ian

Re: Binutils builds broken with -Werror

[Ian Lance Taylor]

Paul Brook <paul@codesourcery.com> writes:

> On Tuesday 22 March 2005 17:12, Maciej W. Rozycki wrote:
> > On Tue, 22 Mar 2005, Nick Clifton wrote:
> > > Hmm, well I am not wedded to GNU make, but do other versions of make
> > > support the $(subst FROM,TO,TEXT) function ?  If not then can anyone
> > > suggest a more portable way of achieving the same effect ?
> >
> >  Well, since that -Werror is added by configure scripts in the first
> > place, the most reasonable way of dealing with it is probably letting
> > autoconf/automake do their jobs.  This flag could be substituted
> > separately instead of along other flags in WARN_CFLAGS and then omitted
> > selectively for generated files -- automake permits overriding default
> > compilation flags in templates on a file by file basis.
> 
> Does it? I thought that only worked on a per-library basis.

No, you can override on a per-file basis using something like
    foo_c_CFLAGS = 

Ian

RE: Binutils builds broken with -Werror

[Dave Korn]

----Original Message----
>From: Nick Clifton
>Sent: 22 March 2005 17:12

> Hi Ian,
> 
>>> Poo.  Well we can rely upon using a GNU-like make program, right ?  So
>>> how about this version then ?
>> 
>> 
>> That's an interesting question.  gcc has decided to require GNU make.
>> Do the binutils want to follow?
> 
> Hmm, well I am not wedded to GNU make, but do other versions of make
> support the $(subst FROM,TO,TEXT) function ?  If not then can anyone
> suggest a more portable way of achieving the same effect ?
> 
> Cheers
>    Nick


+ GENERATED_OFILES := $(GENERATED_CFILES:.c=.o)
+ NO_WERROR_COMPILE = $(subst Werror,Wno-error,$(COMPILE))


  Hmm.  Won't this:

NO_WERROR_COMPILE = $(COMPILE:Werror=Wno-error)

do the desired trick?  


    cheers,
      DaveK
-- 
Can't think of a witty .sigline today....

Re: Binutils builds broken with -Werror

[Paul Brook]

On Tuesday 22 March 2005 17:12, Maciej W. Rozycki wrote:
> On Tue, 22 Mar 2005, Nick Clifton wrote:
> > Hmm, well I am not wedded to GNU make, but do other versions of make
> > support the $(subst FROM,TO,TEXT) function ?  If not then can anyone
> > suggest a more portable way of achieving the same effect ?
>
>  Well, since that -Werror is added by configure scripts in the first
> place, the most reasonable way of dealing with it is probably letting
> autoconf/automake do their jobs.  This flag could be substituted
> separately instead of along other flags in WARN_CFLAGS and then omitted
> selectively for generated files -- automake permits overriding default
> compilation flags in templates on a file by file basis.

Does it? I thought that only worked on a per-library basis.

Paul

Re: Binutils builds broken with -Werror

[Paul Brook]

On Tuesday 22 March 2005 17:12, Maciej W. Rozycki wrote:
> On Tue, 22 Mar 2005, Nick Clifton wrote:
> > Hmm, well I am not wedded to GNU make, but do other versions of make
> > support the $(subst FROM,TO,TEXT) function ?  If not then can anyone
> > suggest a more portable way of achieving the same effect ?
>
>  Well, since that -Werror is added by configure scripts in the first
> place, the most reasonable way of dealing with it is probably letting
> autoconf/automake do their jobs.  This flag could be substituted
> separately instead of along other flags in WARN_CFLAGS and then omitted
> selectively for generated files -- automake permits overriding default
> compilation flags in templates on a file by file basis.

Does it? I thought that only worked on a per-library basis.

Paul

Re: Binutils builds broken with -Werror

[Maciej W. Rozycki]

On Tue, 22 Mar 2005, Nick Clifton wrote:

> Hmm, well I am not wedded to GNU make, but do other versions of make support
> the $(subst FROM,TO,TEXT) function ?  If not then can anyone suggest a more
> portable way of achieving the same effect ?

 Well, since that -Werror is added by configure scripts in the first 
place, the most reasonable way of dealing with it is probably letting 
autoconf/automake do their jobs.  This flag could be substituted 
separately instead of along other flags in WARN_CFLAGS and then omitted 
selectively for generated files -- automake permits overriding default 
compilation flags in templates on a file by file basis.

  Maciej

Re: Binutils builds broken with -Werror

[Nick Clifton]

Hi Ian,

>>Poo.  Well we can rely upon using a GNU-like make program, right ?  So
>>how about this version then ?
> 
> 
> That's an interesting question.  gcc has decided to require GNU make.
> Do the binutils want to follow?

Hmm, well I am not wedded to GNU make, but do other versions of make 
support the $(subst FROM,TO,TEXT) function ?  If not then can anyone 
suggest a more portable way of achieving the same effect ?

Cheers
   Nick

Re: Binutils builds broken with -Werror

[Ian Lance Taylor]

Nick Clifton <nickc@redhat.com> writes:

> Poo.  Well we can rely upon using a GNU-like make program, right ?  So
> how about this version then ?

That's an interesting question.  gcc has decided to require GNU make.
Do the binutils want to follow?

I have no strong opinion on the matter.  GNU make Makefiles can get
pretty horrible pretty fast, but that should be controllable in
principle.

Ian

Re: Binutils builds broken with -Werror

[Nick Clifton]

Hi Richard,

>>+ # Disable -Werror, if it has been enabled, when building generated C
>>source
>>+ # files since old versions of bison & yacc will produce working code which
>>+ # contain compile time warnings.
>>+ GENERATED_OFILES := $(GENERATED_CFILES:.c=.o)
>>+ $(GENERATED_OFILES):
>>+ 	$(COMPILE) -c `basename $@ .o`.c -Wno-error

> I don't think you should hard-code -Wno-error like this.  Isn't binutils
> supposed to buildable with non-gcc compilers?  (And it does build with
> MIPSpro FWIW, or at least it did recently.)

Poo.  Well we can rely upon using a GNU-like make program, right ?  So 
how about this version then ?

Cheers
   Nick

Index: binutils/Makefile.am
===================================================================
RCS file: /cvs/src/src/binutils/Makefile.am,v
retrieving revision 1.55
diff -c -3 -p -r1.55 Makefile.am
*** binutils/Makefile.am	22 Feb 2005 12:57:26 -0000	1.55
--- binutils/Makefile.am	22 Mar 2005 16:32:05 -0000
*************** GENERATED_CFILES = \
*** 101,106 ****
--- 101,114 ----
   	arparse.c arlex.c sysroff.c sysinfo.c syslex.c \
   	defparse.c deflex.c nlmheader.c rcparse.c rclex.c

+ # Disable -Werror, if it has been enabled, when building generated C 
source
+ # files since old versions of bison & yacc will produce working code which
+ # contain compile time warnings.
+ GENERATED_OFILES := $(GENERATED_CFILES:.c=.o)
+ NO_WERROR_COMPILE = $(subst Werror,Wno-error,$(COMPILE))
+ $(GENERATED_OFILES):
+ 	$(NO_WERROR_COMPILE) -c `basename $@ .o`.c
+
   DEBUG_SRCS = rddbg.c debug.c stabs.c ieee.c rdcoff.c
   WRITE_DEBUG_SRCS = $(DEBUG_SRCS) wrstabs.c

Re: Binutils builds broken with -Werror

[Richard Sandiford]

Nick Clifton <nickc@redhat.com> writes:
> + # Disable -Werror, if it has been enabled, when building generated C
> source
> + # files since old versions of bison & yacc will produce working code which
> + # contain compile time warnings.
> + GENERATED_OFILES := $(GENERATED_CFILES:.c=.o)
> + $(GENERATED_OFILES):
> + 	$(COMPILE) -c `basename $@ .o`.c -Wno-error
> +

I don't think you should hard-code -Wno-error like this.  Isn't binutils
supposed to buildable with non-gcc compilers?  (And it does build with
MIPSpro FWIW, or at least it did recently.)

Richard

Re: Binutils builds broken with -Werror

[Nick Clifton]

Hi Daniel,

> We need to either disable -Werror for generated files, or accomodate
> different versions of flex/bison more flexibly.  I recommend the former...

*sigh*  Yes you are right.   What do you think of the following patch ? 
  It works for me, but my makefile-fu is not the greatest so there might 
be a better way of expressing what we want.

This patch is for the binutils subdirectory.  I have a similar patch for 
the ld subdirectory and a simpler one for the gas subdirectory as that 
only has one generated source file.  If there are no objections to this 
method then I will apply the patches tomorrow.

Cheers
   Nick

Index: binutils/Makefile.am
===================================================================
RCS file: /cvs/src/src/binutils/Makefile.am,v
retrieving revision 1.55
diff -c -3 -p -r1.55 Makefile.am
*** binutils/Makefile.am	22 Feb 2005 12:57:26 -0000	1.55
--- binutils/Makefile.am	21 Mar 2005 08:27:56 -0000
*************** GENERATED_CFILES = \
*** 101,106 ****
--- 101,113 ----
   	arparse.c arlex.c sysroff.c sysinfo.c syslex.c \
   	defparse.c deflex.c nlmheader.c rcparse.c rclex.c

+ # Disable -Werror, if it has been enabled, when building generated C 
source
+ # files since old versions of bison & yacc will produce working code which
+ # contain compile time warnings.
+ GENERATED_OFILES := $(GENERATED_CFILES:.c=.o)
+ $(GENERATED_OFILES):
+ 	$(COMPILE) -c `basename $@ .o`.c -Wno-error
+
   DEBUG_SRCS = rddbg.c debug.c stabs.c ieee.c rdcoff.c
   WRITE_DEBUG_SRCS = $(DEBUG_SRCS) wrstabs.c

Binutils builds broken with -Werror

[Daniel Jacobowitz]

We need to either disable -Werror for generated files, or accomodate
different versions of flex/bison more flexibly.  I recommend the former...

itbl-lex.c:1693: warning: no previous prototype for `yyget_lineno'
itbl-lex.c:1702: warning: no previous prototype for `yyget_in'
itbl-lex.c:1710: warning: no previous prototype for `yyget_out'
itbl-lex.c:1718: warning: no previous prototype for `yyget_leng'
itbl-lex.c:1727: warning: no previous prototype for `yyget_text'
itbl-lex.c:1736: warning: no previous prototype for `yyset_lineno'
itbl-lex.c:1748: warning: no previous prototype for `yyset_in'
itbl-lex.c:1753: warning: no previous prototype for `yyset_out'
itbl-lex.c:1758: warning: no previous prototype for `yyget_debug'
itbl-lex.c:1763: warning: no previous prototype for `yyset_debug'
itbl-lex.c:1769: warning: no previous prototype for `yylex_destroy'
make[3]: *** [itbl-lex.o] Error 1

lex.yy.c:1841: warning: no previous prototype for `yyget_lineno'
lex.yy.c:1850: warning: no previous prototype for `yyget_in'
lex.yy.c:1858: warning: no previous prototype for `yyget_out'
lex.yy.c:1866: warning: no previous prototype for `yyget_leng'
lex.yy.c:1875: warning: no previous prototype for `yyget_text'
lex.yy.c:1884: warning: no previous prototype for `yyset_lineno'
lex.yy.c:1896: warning: no previous prototype for `yyset_in'
lex.yy.c:1901: warning: no previous prototype for `yyset_out'
lex.yy.c:1906: warning: no previous prototype for `yyget_debug'
lex.yy.c:1911: warning: no previous prototype for `yyset_debug'
lex.yy.c:1917: warning: no previous prototype for `yylex_destroy'
lex.yy.c:1349: warning: `yyunput' defined but not used
make[3]: *** [arlex.o] Error 1

-- 
Daniel Jacobowitz
CodeSourcery, LLC