public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [RFA] Correction to gprof.texi
@ 2001-06-11 16:41 Ben Elliston
  2001-06-12  3:42 ` Nick Clifton
  0 siblings, 1 reply; 2+ messages in thread
From: Ben Elliston @ 2001-06-11 16:41 UTC (permalink / raw)
  To: binutils

I am resubmitting this patch from several months ago; perhaps it was
dropped on the floor?  I have not checked it in myself, since I am not
absolutely certain that it is correct.  Could someone review it?

Ben


2001-06-12  Ben Elliston  <bje@redhat.com>

	* gprof.texi (File Format): Profile data files are stored in
	target byte order, not host byte order.


Index: gprof.texi
===================================================================
RCS file: /cvs/cvsfiles/devo/gprof/gprof.texi,v
retrieving revision 1.19
diff -u -c -r1.19 gprof.texi
*** gprof.texi	2001/04/19 12:45:32	1.19
--- gprof.texi	2001/06/11 23:40:09
***************
*** 1836,1844 ****
  The new file format is defined in header file @file{gmon_out.h}.  It
  consists of a header containing the magic cookie and a version number,
  as well as some spare bytes available for future extensions.  All data
! in a profile data file is in the native format of the host on which
! the profile was collected.  @sc{gnu} @code{gprof} adapts automatically to the
! byte-order in use.
  
  In the new file format, the header is followed by a sequence of
  records.  Currently, there are three different record types: histogram
--- 1836,1844 ----
  The new file format is defined in header file @file{gmon_out.h}.  It
  consists of a header containing the magic cookie and a version number,
  as well as some spare bytes available for future extensions.  All data
! in a profile data file is in the native format of the target for which
! the profile was collected.  @sc{gnu} @code{gprof} adapts automatically
! to the byte-order in use.
  
  In the new file format, the header is followed by a sequence of
  records.  Currently, there are three different record types: histogram

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [RFA] Correction to gprof.texi
  2001-06-11 16:41 [RFA] Correction to gprof.texi Ben Elliston
@ 2001-06-12  3:42 ` Nick Clifton
  0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2001-06-12  3:42 UTC (permalink / raw)
  To: Ben Elliston; +Cc: binutils

Hi Ben,

> I am resubmitting this patch from several months ago; perhaps it was 
> dropped on the floor?

I guess that it must have, sorry.

> I have not checked it in myself, since I am not
> absolutely certain that it is correct.  Could someone review it? 

It is correct.  Gprof is using the bfd routines to perform byte
swapping based on readin in data in the target's byte order and then
processing them in the host's byte order.

> 2001-06-12  Ben Elliston  <bje@redhat.com>
> 
> 	* gprof.texi (File Format): Profile data files are stored in
> 	target byte order, not host byte order.

Approved and applied.

Cheers
        Nick

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2001-06-12  3:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-06-11 16:41 [RFA] Correction to gprof.texi Ben Elliston
2001-06-12  3:42 ` Nick Clifton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).