From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-70579-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 27620 invoked by alias); 9 Mar 2011 16:15:49 -0000
Received: (qmail 27604 invoked by uid 22791); 9 Mar 2011 16:15:48 -0000
X-SWARE-Spam-Status: No, hits=-6.3 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Mar 2011 16:15:40 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p29GFb95032110	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 9 Mar 2011 11:15:37 -0500
Received: from hase (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p29GFZ9f028461;	Wed, 9 Mar 2011 11:15:36 -0500
From: Andreas Schwab <schwab@redhat.com>
To: Ian Lance Taylor <iant@google.com>
Cc: binutils@sourceware.org
Subject: Re: gold patch committed: Check IOV_MAX
References: <mcrfwqxqcqv.fsf@google.com> <m3mxl4y6rt.fsf@redhat.com>	<mcr4o7cpasl.fsf@google.com>
X-Yow: ALFRED JARRY!  Say something about th' DEATH of DISCO!!
Date: Wed, 09 Mar 2011 16:15:00 -0000
In-Reply-To: <mcr4o7cpasl.fsf@google.com> (Ian Lance Taylor's message of "Wed,	09 Mar 2011 07:34:50 -0800")
Message-ID: <m3wrk8w9qw.fsf@redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00185.txt.bz2

Ian Lance Taylor <iant@google.com> writes:

> Andreas Schwab <schwab@redhat.com> writes:
>
>> Ian Lance Taylor <iant@google.com> writes:
>>
>>> @@ -605,11 +606,22 @@ File_read::do_readv(off_t base, const Re
>>>  	       got, want, static_cast<long long>(base + first_offset));
>>>  }
>>>  
>>> +// Portable IOV_MAX.
>>> +
>>> +#if !defined(HAVE_READV)
>>> +#define GOLD_IOV_MAX 1
>>> +#elif defined(IOV_MAX)
>>> +#define GOLD_IOV_MAX IOV_MAX
>>> +#else
>>> +#define GOLD_IOV_MAX (File_read::max_readv_entries * 2)
>>> +#endif
>>> +
>>>  // Read several pieces of data from the file.
>>>  
>>>  void
>>>  File_read::read_multiple(off_t base, const Read_multiple& rm)
>>>  {
>>> +  static size_t iov_max = GOLD_IOV_MAX;
>>
>> const?
>
> I've written the code this way because IOV_MAX need not be a constant.

But that doesn't prevent iov_max from being const, doesn't it?

Andreas.

-- 
Andreas Schwab, schwab@redhat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84  5EC7 45C6 250E 6F00 984E
"And now for something completely different."