From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3913 invoked by alias); 11 Feb 2005 17:05:48 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 3854 invoked from network); 11 Feb 2005 17:05:42 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 11 Feb 2005 17:05:42 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j1BH5gVB007830 for ; Fri, 11 Feb 2005 12:05:42 -0500 Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j1BH5fO10354 for ; Fri, 11 Feb 2005 12:05:42 -0500 Received: from localhost.localdomain.redhat.com (vpnuser9.surrey.redhat.com [172.16.9.9]) by pobox.surrey.redhat.com (8.12.8/8.12.8) with ESMTP id j1BH5eMR004132 for ; Fri, 11 Feb 2005 17:05:41 GMT To: binutils@sources.redhat.com Subject: Fix compile time warning in bfd/coff-tic4x.c From: Nick Clifton Date: Fri, 11 Feb 2005 18:45:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2005-02/txt/msg00251.txt.bz2 Hi Guys, I am applying the patch below to fix a compile time warning building bfd/coff-tic4x.c. This was actually a case where the warning proved to be useful - there was an underlying bug that it picked up. Cheers Nick bfd/ChangeLog 2005-02-11 Nick Clifton * coff-tic4x.c (coff_rtype_to_howto): Move definition before inclusion of coffcode.h so that it is actually picked up. Index: bfd/coff-tic4x.c =================================================================== RCS file: /cvs/src/src/bfd/coff-tic4x.c,v retrieving revision 1.8 diff -c -3 -p -r1.8 coff-tic4x.c *** bfd/coff-tic4x.c 4 Jun 2003 11:38:30 -0000 1.8 --- bfd/coff-tic4x.c 11 Feb 2005 17:02:41 -0000 *************** ticoff_bfd_is_local_label_name (abfd, na *** 68,73 **** --- 68,77 ---- The COFF1 and COFF0 vectors use custom _bad_format_hook procs instead of setting BADMAG. */ #define BADMAG(x) COFF2_BADMAG(x) + + #undef coff_rtype_to_howto + #define coff_rtype_to_howto coff_tic4x_rtype_to_howto + #include "coffcode.h" static bfd_reloc_status_type *************** tic4x_lookup_howto (internal, dst) *** 172,180 **** abort(); } - #undef coff_rtype_to_howto - #define coff_rtype_to_howto coff_tic4x_rtype_to_howto - static reloc_howto_type * coff_tic4x_rtype_to_howto (abfd, sec, rel, h, sym, addendp) bfd *abfd ATTRIBUTE_UNUSED; --- 176,181 ----