From: Nick Clifton <nickc@redhat.com>
To: hjl@gnu.org
Cc: binutils@sources.redhat.com
Subject: Fix to elf common tests
Date: Mon, 21 Apr 2003 09:31:00 -0000 [thread overview]
Message-ID: <m3wuhofbaz.fsf@localhost.localdomain> (raw)
Hi HJ,
I would like to make a small change to the elf common tests you
created. The patch below adds an explicit "aligned(1)" attribute to
the declaration of foo1 in common1b.c. This is because not all
ports default to an alignment of 1 for their commons. The ARM port
for example defaults to an alignment of 4.
Do you have any problems with this ? There are no regressions in
the x86 Linux port with this patch applied.
Cheers
Nick
2003-04-21 Nick Clifton <nickc@redhat.com>
* ld-elfcomm/common1b.c (foo1): Add an explicit alignment for
the foo1 array.
Index: ld/testsuite/ld-elfcomm/common1b.c
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-elfcomm/common1b.c,v
retrieving revision 1.1
diff -c -3 -p -w -r1.1 common1b.c
*** ld/testsuite/ld-elfcomm/common1b.c 15 Apr 2003 09:38:10 -0000 1.1
--- ld/testsuite/ld-elfcomm/common1b.c 21 Apr 2003 09:27:40 -0000
***************
*** 1,3 ****
static char dummy1 = 'X';
! char foo1 [] = "Aligned at odd byte.";
char foo2 [4];
--- 1,3 ----
static char dummy1 = 'X';
! char foo1 [] __attribute__((aligned(1))) = "Aligned at odd byte.";
char foo2 [4];
next reply other threads:[~2003-04-21 9:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-21 9:31 Nick Clifton [this message]
2003-04-21 14:36 ` H. J. Lu
2003-04-21 14:49 ` H. J. Lu
2003-04-22 8:28 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3wuhofbaz.fsf@localhost.localdomain \
--to=nickc@redhat.com \
--cc=binutils@sources.redhat.com \
--cc=hjl@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).