From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11572 invoked by alias); 21 Apr 2003 09:31:20 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 11565 invoked from network); 21 Apr 2003 09:31:19 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 21 Apr 2003 09:31:19 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h3L9VID32385 for ; Mon, 21 Apr 2003 05:31:18 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h3L9VIq08921; Mon, 21 Apr 2003 05:31:18 -0400 Received: from localhost.localdomain.redhat.com (vpn50-24.rdu.redhat.com [172.16.50.24]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h3L9VFb11856; Mon, 21 Apr 2003 05:31:17 -0400 To: hjl@gnu.org Cc: binutils@sources.redhat.com Subject: Fix to elf common tests From: Nick Clifton Date: Mon, 21 Apr 2003 09:31:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-04/txt/msg00391.txt.bz2 Hi HJ, I would like to make a small change to the elf common tests you created. The patch below adds an explicit "aligned(1)" attribute to the declaration of foo1 in common1b.c. This is because not all ports default to an alignment of 1 for their commons. The ARM port for example defaults to an alignment of 4. Do you have any problems with this ? There are no regressions in the x86 Linux port with this patch applied. Cheers Nick 2003-04-21 Nick Clifton * ld-elfcomm/common1b.c (foo1): Add an explicit alignment for the foo1 array. Index: ld/testsuite/ld-elfcomm/common1b.c =================================================================== RCS file: /cvs/src/src/ld/testsuite/ld-elfcomm/common1b.c,v retrieving revision 1.1 diff -c -3 -p -w -r1.1 common1b.c *** ld/testsuite/ld-elfcomm/common1b.c 15 Apr 2003 09:38:10 -0000 1.1 --- ld/testsuite/ld-elfcomm/common1b.c 21 Apr 2003 09:27:40 -0000 *************** *** 1,3 **** static char dummy1 = 'X'; ! char foo1 [] = "Aligned at odd byte."; char foo2 [4]; --- 1,3 ---- static char dummy1 = 'X'; ! char foo1 [] __attribute__((aligned(1))) = "Aligned at odd byte."; char foo2 [4];